izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity
Files
5.4
UnrealEngineUWP/Engine/Source/Editor/AdvancedPreviewScene/Private/AdvancedPreviewSceneModule.cpp

32 lines
1.1 KiB
C++
Raw Permalink Normal View History

Updating copyright for Engine Editor. #rnx #rb none #ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904 #ROBOMERGE-BOT: (v613-10869866) [CL 10870586 by ryan durand in Main branch]
2019-12-26 15:33:43 -05:00
// Copyright Epic Games, Inc. All Rights Reserved.
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
#include "AdvancedPreviewSceneModule.h"
IWYU Pass 1 - Engine/Source/Editor/... #jira #preflight 6306736ac85b7fef22be7751 [CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
#include "AdvancedPreviewSceneCommands.h"
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3847469) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3805828 by Gil.Gribb UE4 - Fixed a bug in the lock free stalling task queue and adjusted a comment. The code is not current used, so this is not actually change the way the code works. Change 3806784 by Ben.Marsh UAT: Remove code to compile UBT when using UE4Build. It should already be compiled as a dependency of UAT. Change 3807549 by Graeme.Thornton Add a cook timer around VerifyCanCookPackage. A licensee reports this taking a lot of time so it'll be good to account for it. Change 3807727 by Graeme.Thornton Unhide the text asset format experimental editor option Change 3807746 by Josh.Engebretson Remove WER from iOS platform Change 3807928 by Robert.Manuszewski When async loading, GC Clusters will be created after packages have been processed to avoid situations where some of the objects that are being added to a cluster haven't been fully loaded yet Change 3808221 by Steve.Robb GitHub #4307 - Made GetModulePtr() thread safe by not using GetModule() ^ I'm not convinced by how much thread-safer this is really, but it's tidier anyway. Change 3809233 by Graeme.Thornton TBA: Misc changes to text asset commandlet - Rename mode to "loadsave" - Add -outputFormat option which can be assigned "text" or "binary" - When saving binary, use a differentiated filename so that source assets aren't overwritten Change 3809518 by Ben.Marsh Remove the outdated UnrealSync automation script. Change 3809643 by Steve.Robb GitHub #4277 : fix bug; FMath::FormatIntToHumanReadable 3rd comma and negative value #jira UE-53037 Change 3809862 by Steve.Robb GitHub #3342 : [FRotator.h] Fix to DecompressAxisFromByte to be more efficient and reflect its intent accurately #jira UE-42593 Change 3811190 by Graeme.Thornton Add support for writing specific log channels to their own files Change 3811197 by Graeme.Thornton Minor updates to output formatting and timing for the text asset commandlet Change 3811257 by Robert.Manuszewski Cluster creation will now be time-sliced Change 3811565 by Steve.Robb Define out non-monolithic module functions. Change 3812561 by Steve.Robb GitHub #3886 : Enable Brace-Initialization for Declaring Variables Incorrect semi-colon search removed after discussion with author. Test added. #jira UE-48242 Change 3812864 by Steve.Robb Removal of some unproven code which was supposed to fix hot reloading BP class functions in plugins. See: https://udn.unrealengine.com/questions/376978/aitask-blueprint-nodes-disappear-when-their-module.html #jira UE-53089 Change 3820358 by Ben.Marsh PR #4358: Incredibuild use ShowAgent by default (Contributed by projectgheist) Change 3822594 by Ben.Marsh UAT: Improvements to log file handling. - Always create log files in the final location, rather than writing to a temp directory and copying in later. - Now supports -Verbose and -VeryVerbose for increasing log verbosity, rather than -Verbose=XXX. - Keep a backlog of log output before the log system is initialized, and flush it to the log file once it is. - Allow buildmachines to specify the uebp_FinalLogFolder environment variable, which is used to form paths for display. When build machines copy log files elsewhere after UAT finishes (eg. a network share), this allows error messages to display the right location. Change 3823695 by Ben.Marsh UGS: Fix issue where precompiled binaries would not be shown as available for a change until scrolling the last submitted code change into the buffer (other symptoms, like de-focussing the main window would cause it to go back to an unavailable state, since the changes buffer was shrunk). Now always queries changes up to the last change for which zipped binaries are available. Change 3823845 by Ben.Marsh UBT: Exclude C# projects for unsupported platforms when generating project files. Change 3824180 by Ben.Marsh UGS: Add an option to show changes by build machines, and move the "only show reviewed" option in there too (Options > Show Changes). #jira Change 3825777 by Steve.Robb Fix to return value of StringToBytes. Change 3825810 by Ben.Marsh UBT: Reduce length of include paths for MSVC toolchain. Change 3825822 by Robert.Manuszewski Optimized PIE lazy pointer fixup. Should be up to 8x faster now. Change 3826734 by Ben.Marsh Remove code to disable TextureFormatAndroid on Linux. It seems to be an editor dependency. Change 3827730 by Steve.Robb Try to avoid decltype(auto) if it's not supported. See: https://udn.unrealengine.com/questions/395644/build-417-with-c11-on-linux-ttuple-errors.html Change 3827745 by Steve.Robb Initializer list support for TMap. Change 3827770 by Steve.Robb GitHub #4399 : Added a CONSTEXPR qualifiers to FVariant::GetType() #jira UE-53813 Change 3829189 by Ben.Marsh UBT: Now always writes a minimal log file. By default, just contains the regular console output and any reasons why actions are outdated and needed to be executed. UAT directs child UBT instances to output logs into its own log folder, so that build machines can save them off. Change 3830444 by Steve.Robb BuildVersion and ModuleManifest moved to Core, and parsing of these files reimplemented to avoid a JSON library. This should be revisited when Core has its own JSON library. Change 3830718 by Ben.Marsh Fix incorrect group name being returned by FStatNameAndInfo::GetGroupName() for stat groups. The editor populates the viewport stats list by calling this for every registered stat and stat group (via FLevelViewportCommands::HandleNewStatGroup). The menu entry attempts to show the stat name with STAT_XXX stripped from the start as the menu item label, with the free-form text description as a tooltip. For stat groups, the it would previously just return the stat group name as "Groups" (due to the raw naming convention of "//Groups//STATGROUP_Foo//..."). Since this didn't match the expected naming convention in FLevelViewportCommands::HandleNewStat (ie. STAT_XXX or STATGROUP_XXX), it would fail to add it. When the first actual stat belonging to that group is added, it would add a menu entry for the group based on that, but the stat description no longer makes sense as a tooltip for the group. As a result, all the editor tooltips were junk. #jira UE-53845 Change 3831064 by Ben.Marsh Fix log file contention when spawning UBT recursively. Change 3832654 by Ben.Marsh UGS: Fix error panel not being selected when opened, and weird alignment/color issues on it. Change 3832680 by Ben.Marsh UGS: Fix failing to detect workspace if synced to a different stream. Seems to be a regression caused by recent P4D upgrade. Change 3832695 by Ben.Marsh UGS: Invert the options in the 'Show Changes' submenu for simplicity. Change 3833528 by Ben.Marsh UAT: Script to rewrite source files with public include paths relative to the 'Public' folder. Usage is: RebasePublicIncludePaths -UpdateDir=<Dir> [-Project=<Dir>] [-Write]. Change 3833543 by Ben.Marsh UBT: Allow targets to opt-out of having public include paths added for every dependent module. This reduces the command line length when building a target, which has recently become a problem with larger games (due to Microsoft's compiler embedding the command line into each object file, with a maximum length of 64kb). All engine modules are compiled with this enabled; games may opt into it by setting bLegacyPublicIncludePaths = false; from their .target.cs, as may individual modules. Change 3834354 by Robert.Manuszewski Archetype pointer will now be cached to avoid locking the object tables when acquiring its info. It should also be faster this way regardless of any locks. #jira UE-52035 Change 3834400 by Robert.Manuszewski Fixing crash on exit caused by cached archetypes not being cleaned up before static exit cleanup. #jira UE-52035 Change 3834947 by Steve.Robb USE_FORMAT_STRING_TYPE_CHECKING removed from FMsg::Logf and FMsg::Logf_Internal. Change 3835004 by Ben.Marsh Fix code that relies on dubious behavior of requiring referenced "include path only" modules having their _API macros set to be empty, even if the module is actually implemented in a separate DLL. Change 3835340 by Ben.Marsh Fix errors making installed build from directories with spaces in the name. Change 3835972 by Ben.Marsh UBT: Improved diagnostic message for targets which don't need a version file. Change 3836019 by Ben.Marsh UBT: Fix warnings caused by defining linkage macros for third party libraries. Change 3836269 by Ben.Marsh Fix message box larger than the screen height being created when a large number of modules are incompatible on startup. Change 3836543 by Ben.Marsh Enable SoundMod plugin on Linux, since it's already supported through the editor. Change 3836546 by Ben.Marsh PR #4412: fix type mismatch (Contributed by nakapon) Change 3836805 by Ben.Marsh Fix commandlet to compile marketplace plugins. Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3837036 by Ben.Marsh UBT: Write the previous and new contents of intermediate files to the log if they change. Makes it easier to debug unexpected rebuilds. Change 3837037 by Ben.Marsh UBT: Fix engine modules having inconsistent definitions depending on whether modules are only referenced for their include paths vs being linked into a binary (due to different _API macro). Change 3837040 by Ben.Marsh UBT: Remove code that initializes members in ModuleRules and TargetRules objects before the constructor is run. This is no longer necessary, now that the backwards-compatible default constructors have been removed. Change 3837247 by Ben.Marsh UBT: Remove UELinkerFixups module, now that plugins and precompiled modules do not require hacks to force initialization (since they're linked in as object files). Encryption and signing keys are now set via macros expanded from the IMPLEMENT_PRIMARY_GAME_MODULE macro, via project-specific macros added in the TargetRules constructor. Change 3837262 by Ben.Marsh UBT: Set whether a module is an engine module or not via a default value for the rules assembly. All non-program engine and enterprise modules are created with this flag set to true; program targets and modules are now created from a different assembly that sets it to false. This removes hacks from UEBuildModule needed to adjust behavior for different module types based on the directory containing the module. Also add a bUseBackwardsCompatibleDefaults flag to the TargetRules class, also initialized to a default value from a setting passed to the RulesAssembly constructor. This controls whether modules created for the target should be configured to allow breaking changes to default settings, and is set to false for all engine targets, and true for all project targets. Change 3837343 by Ben.Marsh UBT: Remove the OverrideExecutableFileExtension target property. Change the only current use for this (the MayaLiveLinkPlugin target) to use a post build step to copy the file instead. Change 3837356 by Ben.Marsh Fix invalid character encodings. Change 3837727 by Graeme.Thornton UnrealPak: KeyGenerator: Only generate prime table when required, not all the time Change 3837823 by Ben.Marsh UBT: Output warnings and errors when compiling module rules assembly in a way that allows them to be double-clicked in the Visual Studio output window. Change 3837831 by Graeme.Thornton UBT: When parsing crypto settings, always load legacy data first, then allow the new system to override it. Provides the same key backwards compatibility that the editor settings class gives Change 3837857 by Robert.Manuszewski PR #4404: Make FGCArrayPool singleton global instead of per-CU (Contributed by mhutch) Change 3837943 by Robert.Manuszewski PR #4405: Fix FGarbageCollectionTracer (Contributed by mhutch) Change 3838451 by Ben.Marsh UBT: Fix exceptions thrown on a background thread while caching C++ includes not being caught and logged correctly. Now captures exceptions and re-throws on the main thread. #jira UE-53996 Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 3843790 by Graeme.Thornton UnrealPak: Log the size of all encrypted data Change 3844258 by Ben.Marsh Fix plugin compile failure when created via new plugin wizard. Passing -plugin on the command line is unnecessary, and is now reserved for packaging external plugins for the marketplace. Also extend the length of time that the error toast stays visible, and don't delete the plugin on failure. #jira UE-54157 Change 3845796 by Ben.Marsh Workaround for slow performance of String.EndsWith() on Mono. Change 3845823 by Ben.Marsh Fix case sensitive matching of platform names in -TargetPlatform=X argument to BuildCookRun. #jira UE-54123 Change 3845901 by Arciel.Rekman Linux: fix crash due to lambda lifetime issues (UE-54040). - The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+). (Edigrating 3819174 to Dev-Core) Change 3846439 by Ben.Marsh Revert CL 3822742 to always call Process.WaitForExit(). The Android target platform module in the editor spawns ADB.EXE, which inherits the editor's stdout/stderr handles and forks itself. Process.WaitForExit() waits for EOF on those pipes, which never occurs because the forked process never terminates. Proper fix is probably to have the engine explicitly duplicate stdout/stderr handles for new pipes to output process, but too risky before copying up to Main. Change 3816608 by Ben.Marsh UBT: Use DirectoryReference objects for all include paths. Change 3816954 by Ben.Marsh UBT: Remove bIncludeDependentLibrariesInLibrary option. This is not widely supported by platform toolchains, and is not used anywhere. Change 3816986 by Ben.Marsh UBT: Remove UEBuildBinaryConfig; UEBuildBinary objects are now just created directly. Change 3816991 by Ben.Marsh UBT: Deprecate PlatformSpecificDynamicallyLoadedModules. We no longer have any special behavior for these modules. Change 3823090 by Ben.Marsh UAT: Improve logging for child UAT instances. - Calling RunUAT now requires an identifier for prefixing into the parent log, which is also used to determine the name of the log folder. - Stdout is no longer written to its own output file, since it's written to the parent stdout, the parent log file, and the child log file anyway. - Log folders for child UAT instances are left intact, rather than being copied to the parent folder. The derived names for the copied names were confusing and hard to read. - Output from UAT is no longer returned as a string. It should not be parsed anyway (but may be huge!). ProcessResult now supports running without capturing output. Change 3826082 by Ben.Marsh UBT: Add a check to make sure that all modules that are precompiled are correctly marked to enable it, even if they are part of the build target. Change 3827025 by Ben.Marsh UBT: Move the compile output directory into a property on the module, and explicitly pass it to the toolchain when compiling. Change 3829927 by James.Hopkin Made HTTP interface const correct Change 3833533 by Ben.Marsh Rewrite engine source files to base include paths relative to the "Public" directory. This allows reducing the number of public include paths that have to be added for engine modules. Change 3835826 by Ben.Marsh UBT: Precompiled targets now generate a separate manifest for each precompiled module, rather than adding object files to a library. This fixes issues where object files from static libraries would not be linked into a target if a symbol in them was not referenced. Change 3835969 by Ben.Marsh UBT: Fix cases where text is being written directly to the console rather than via logging functions. Change 3837777 by Steve.Robb Format string type checking added to FOutputDevice::Logf. Fixes for those. Change 3838569 by Steve.Robb Algo moved up a folder. [CL 3847482 by Ben Marsh in Main branch]
2018-01-20 11:19:29 -05:00
#include "Modules/ModuleManager.h"
IWYU Pass 1 - Engine/Source/Editor/... #jira #preflight 6306736ac85b7fef22be7751 [CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00
#include "SAdvancedPreviewDetailsTab.h"
#include "Widgets/DeclarativeSyntaxSupport.h"
class UObject;
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
void FAdvancedPreviewSceneModule::StartupModule()
{
FAdvancedPreviewSceneCommands::Register();
}
void FAdvancedPreviewSceneModule::ShutdownModule()
{
}
Copy up from Dev-Editor @10681378 #rb none [CL 10837446 by Chris Gagnon in Dev-Tools-Staging branch]
2019-12-19 18:07:47 -05:00
TSharedRef<SWidget> FAdvancedPreviewSceneModule::CreateAdvancedPreviewSceneSettingsWidget(const TSharedRef<FAdvancedPreviewScene>& InPreviewScene, UObject* InAdditionalSettings, const TArray<FDetailCustomizationInfo>& InDetailCustomizations, const TArray<FPropertyTypeCustomizationInfo>& InPropertyTypeCustomizations, const TArray<FDetailDelegates>& InDelegates)
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
{
return SNew(SAdvancedPreviewDetailsTab, InPreviewScene)
.AdditionalSettings(InAdditionalSettings)
.DetailCustomizations(InDetailCustomizations)
Copy up from Dev-Editor @10681378 #rb none [CL 10837446 by Chris Gagnon in Dev-Tools-Staging branch]
2019-12-19 18:07:47 -05:00
.PropertyTypeCustomizations(InPropertyTypeCustomizations)
.Delegates(InDelegates);
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3384744) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3294073 on 2017/02/09 by Thomas.Sarkanen Delete old location of FriendViewModel.h that did not get picked up correctly in the merge Change 3354003 on 2017/03/20 by Thomas.Sarkanen Back out changelist 3353914 Change 3355932 on 2017/03/21 by Thomas.Sarkanen Back out changelist 3354003 Reinstating merge from Main: Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839 Change 3358776 on 2017/03/22 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3360075 on 2017/03/23 by James.Golding Back out changelist 3358776, as it was made after smoke testing. Will re-submit after copy to main. Change 3362695 on 2017/03/24 by Thomas.Sarkanen Use correct extender when building menus for AnimationEditor, SkeletalMeshEditor & SkeletonEditor #jira UE-41100 - Persona code calling incorrect extenders when building menus. Change 3362696 on 2017/03/24 by Thomas.Sarkanen Facial animation experimental feature now pops up restart editor toast #jira UE-40989 - User is not prompted to restart the editor when enabling the Facial Animation Importer Change 3362699 on 2017/03/24 by Thomas.Sarkanen Enable snapping for translation in animation viewports #jira UE-39747 - Translating sockets in Persona is not affected by Snap Options #jira UE-39748 - Translating bones in Persona is not affected by Snap Options Change 3362700 on 2017/03/24 by Thomas.Sarkanen Curve source nodes now dont update their source title if the source is a pin The title of the node is not recached when the pin default changes, so we cant display it in the title #jira UE-40108 - When changing a Curve Source Node doesn't update source binding name when typed in Change 3362721 on 2017/03/24 by Thomas.Sarkanen CVar r.SkeletalMeshLODBias no longer affects meshes in animation viewports #jira UE-35733 - GSkeletalMeshLODBias affects render LOD in Persona Change 3362724 on 2017/03/24 by Thomas.Sarkanen Fix animation preview scene keyboard bindings Also moved advanced preview scene into its own module #jira UE-41505 - Pressing the hotkey I and O do not hide the floor and environment if the Preview Scene Settings tab isn't opened. Change 3362783 on 2017/03/24 by Ori.Cohen Fix incorrect locking and check when an editor static shape is changed. Originally this code assumed it would only get called at runtime, where there is only 1 shape. In the case of the async scene and static shapes - there are two shapes and if you update the body setup in the editor this will crash. Change 3362796 on 2017/03/24 by Ori.Cohen Fix welded capsules not using the right rotation #JIRA UE-41546 Change 3362803 on 2017/03/24 by Ori.Cohen Recreate physics when changing mobility of components - fixes debug rendering issue #JIRA UE-39328 Change 3363013 on 2017/03/24 by Thomas.Sarkanen Fix CIS issue Change 3363202 on 2017/03/24 by Ori.Cohen Fix bad #endif Change 3363295 on 2017/03/24 by Ori.Cohen Remove bWelded and use WeldParent everywhere. This fixes a bad case where a kinematic is returned as the root welded of simulated children. #JIRA UE-40783 Change 3363435 on 2017/03/24 by Jon.Nabozny Fix infinite jump on client when Jump Max Hold Time is not 0. #jira UE-41004 Change 3363451 on 2017/03/24 by Jon.Nabozny Fix USkeletalMeshComponent::PoseTickedThisFrame to use a frame counter instead of world time (which isn't changed while paused). #jira UE-39567 Change 3363504 on 2017/03/24 by Jon.Nabozny Fix SCE_NP_MATCHING2_REQUEST_EVENT_SEARCH_ROOM_A to treat result data as linked list instead of array. (Code originally came from SCE via UDN) #jira UE-41049 Change 3363532 on 2017/03/24 by Ori.Cohen Change default to SkipSimulatedBones. #JIRA UE-41404 Change 3363537 on 2017/03/24 by Ori.Cohen Remove the unsupported option of HideBone with DisableCollision. If we want this in the future we can add it. #JIRA UE-30826 Change 3363681 on 2017/03/24 by Jon.Nabozny Reapply 3292286 after it was clobbered by 3360002 (Only clobbered in Ocean). #jira UE-37512 Change 3363722 on 2017/03/24 by mason.seay Updated map to improve testing Change 3365351 on 2017/03/27 by Thomas.Sarkanen Fix non-PCH CIS errors #jira UE-43335 - CIS fail: 'FAdvancedPreviewSceneCommands is not a class name Change 3365422 on 2017/03/27 by Thomas.Sarkanen Fixed skinned mesh LOD not updating in editor under various physics-related circumstances #jira UE-42013 - Skeletal meshes with recently generated LODs will not change LODs in viewport Change 3365423 on 2017/03/27 by Thomas.Sarkanen Fix ensure when setting Spline IK Bone Axis to 'None' Node is currently not in use, so I've avoided deprecating this for now. Values should be preserved. #jira UE-39723 - Ensure when setting Bone Axis to None in Spline IK Change 3365424 on 2017/03/27 by Thomas.Sarkanen Fix control rigs being convertable to possessables Also prevent 'export to anim sequence' button from appearing on standard level sequences #jira UE-42070 - Crash converting a control rig to Possessable Change 3365425 on 2017/03/27 by Thomas.Sarkanen When selecting bones that are non-required, we dont render gizmos or text labels #jira UE-35737 - Bone labels flicker between two locations when removing from LOD levels in Persona Change 3365426 on 2017/03/27 by Thomas.Sarkanen Fixed foot placement IK doing line traces on worker threads Also exposed const access to required bones array (the proxy already does this, so I figure the instance should get it too). Note: Node is not actually used #jira UE-43179 - Fix FAnimNode_FootPlacementIK doing line trace on worker thread Change 3365428 on 2017/03/27 by Thomas.Sarkanen Skeleton selection no does not lag behind choice made in viewport #jira UE-42236 - Mesh Overlay always lags behind actual selection Change 3365429 on 2017/03/27 by Thomas.Sarkanen Fix anim BPs that contain state machines having blank palettes #jira UE-42172 - AnimBP Palette is blank on existing AnimBPs Change 3365435 on 2017/03/27 by Jurre.deBaare Undoing Channel selection in Paint mode does not work #fix use duplicated CDO object instead of CDO directly #jira UE-42621 Change 3365436 on 2017/03/27 by Jurre.deBaare Functionless undo/redo transactions created when importing Alembic file and changing conversion settings #fix use duplicated CDO object instead of CDO directly #jira UE-40347 Change 3365437 on 2017/03/27 by Jurre.deBaare Ensure that HLOD cannot be set up in sub-levels #fix added functionality to check whether or not a level is used as a sub/streaming level in any other content, and if so show a widget similar to the checkout notice to inform the user why the hlod outliner is disabled #jira UE-40301 Change 3365438 on 2017/03/27 by Jurre.deBaare 2D Blendspace breaks when aligning samples in a straight line #fix for some reason the number of samples to considerate was limit to 3 (old code) so removed it since it doesn't make sense #jira UE-42744 Change 3365439 on 2017/03/27 by Jurre.deBaare Color View Mode doesn't reset when closing/reopening editor #fix added a delegate to OnEditorClose to ensure we can reset the viewport modes while they still exist, this issue would happen if the user closes the editor with mesh paint mode open, exiting the mode would only happen after destructing most of the editor #jira UE-42466 Change 3365440 on 2017/03/27 by Jurre.deBaare LOD Model field scrubbing is very sensitive #fix made sure that max slider value is also driven by data #jira UE-42980 Change 3365441 on 2017/03/27 by Jurre.deBaare Replacing an asset in a sequence player node does not register in undo history #fix added transaction for dropping anim assets on player nodes #jira UE-39152 Change 3365442 on 2017/03/27 by Jurre.deBaare Crash on Mac importing some alembic files #fix disable multithread abc file reading with HDF5 backend #jira UE-39783 Change 3365443 on 2017/03/27 by Jurre.deBaare Moving over Alembic feature: "Add support for 'finding' materials according to the face-set names in abc files" Change 3365444 on 2017/03/27 by Jurre.deBaare Moving over Alembic fixes: - Time offset issues > changed how we determine frame indices and frame steps - Incorrect tangent issues > enforce tangent calculation during skeletal mesh import - Automatically set recompute tangent flag on skeletal mesh sections Change 3365451 on 2017/03/27 by Jurre.deBaare CIS: include needed for GetTransientPackage Change 3365460 on 2017/03/27 by Jurre.deBaare CIS: apparently CIS wants explicit cast to UObject Change 3365463 on 2017/03/27 by Jurre.deBaare CIS: final fix, was actually UPackage include missing ugh Change 3365486 on 2017/03/27 by Thomas.Sarkanen Fix case error in include for Linux builds Change 3365499 on 2017/03/27 by James.Golding Fix editing collision settings sometimes not 'sticking' - wait until after LoadProfileConfig (which modified Profiles array) to copy to 'SavedData' Fix FCollsiionProfileData typo #jira UE-42490 Change 3365500 on 2017/03/27 by Jurre.deBaare Turning on LOD Model Painting does not copy paint to other LODs on Skeletal Mesh #fix neede to pre edit / post edit the skeletal mesh to ensure the color buffers were re-initialised #jira UE-42637 Change 3365501 on 2017/03/27 by James.Golding Disable rather than hide anim picker when no mesh assigned #jira UE-35537 Change 3365505 on 2017/03/27 by James.Golding Fix USkinnedMeshComponent::FindClosestBone ignoring bRequirePhysicsAsset, because BodySetupIndexMap.FindRef would return 0 if bone not present https://udn.unrealengine.com/questions/353125/uskinnedmeshcomponentfindclosestbone-does-not-resp.html #jira UE-43061 Change 3365515 on 2017/03/27 by Jurre.deBaare Using Alt+Click to break Transition node connections cannot be undone using the Undo command #fix added transactions to breaking node links #jira UE-39068 Change 3365528 on 2017/03/27 by Jurre.deBaare Blendspaces don't update to reflect sync marker changes that have occurred on animations in the blend #fix added validation on blendspaces when removing or adding sync markers in animation editor #jira UE-39814 Change 3365535 on 2017/03/27 by Jurre.deBaare Camera moves at the same time as erasing paint when clicking Paint settings and back into Viewport #fix lock camera if erasing as well #jira UE-42474 Change 3365539 on 2017/03/27 by Jurre.deBaare Painting on animation sequence paints on invisible T-pose skeleton #fix during painting enforce bUseRefPoseOnInitAnim so you're always painting on a ref-pose skeletal mesh #jira UE-42484 Change 3365545 on 2017/03/27 by Jurre.deBaare Fill Tool does not fill the mesh with the selected Texture Weight Index when used in Weight Vertex Painting #fix added function to generate color according to texture weight settings and index, and fill using that color when the editor is in texture weight mode #jira UE-43091 Change 3365549 on 2017/03/27 by Jurre.deBaare CIS: include fix Change 3365555 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365561 on 2017/03/27 by Jurre.deBaare Missing change from 3365545 Change 3365918 on 2017/03/27 by Ori.Cohen PR #3424: fix compile error when PHYSX_MEMORY_STATS=1 (Contributed by kayama-shift) #JIRA UE-43337 Change 3366234 on 2017/03/27 by Ori.Cohen Moved call to UpdateHasValidBodies into OnRegister. Original suggested fix came from github, but I think the bounds need to update even if OnCreatePhysics isn't called. #JIRA UE-43339 #pr 3427 Change 3367252 on 2017/03/28 by Jurre.deBaare Vertex Weight Painting options are no longer present in MeshPaint mode #fix implemented singleton pattern for paint mode settings to ensure customization works correctly #jira UE-43357 Change 3367340 on 2017/03/28 by Jurre.deBaare GC fix for recent changes to painting / alembic settings Change 3367445 on 2017/03/28 by Thomas.Sarkanen Fix fallout from Main merge OrionEditor needs to depend on the new AdvancedPreviewScene module. Change 3367741 on 2017/03/28 by Ori.Cohen Remove unused physics warning when moving simulated object during physics #jira UE-41465 Change 3368072 on 2017/03/28 by Ori.Cohen Removed collision aggregates from ISMC collision. This is not a good candidate for aggregates as the bounding boxes generated could be huge (for example several trees that are very far away). This fixes perf regression from the PhysX 3.4 upgrade #JIRA UE-42956 Change 3368479 on 2017/03/28 by Ori.Cohen Fix GetClosestPoint incorrectly considering welded bodies. #JIRA UE-39329 Change 3368620 on 2017/03/28 by Lina.Halper Added code comment #rb:none #jira: UE-38836 Change 3368752 on 2017/03/28 by mason.seay Updated test map since UE-338836 came back as by design Change 3369370 on 2017/03/29 by James.Golding Fix StaticMesh Editor drawing complex collision if 'use simple as complex' is enabled Add separate options for showing simple and complex collision in StaticMesh Editor #jira UE-42844 Change 3369438 on 2017/03/29 by Lina.Halper Fix issue where it updates more often when you give too high update rate - i.e. 60 #jira: UE-38844 #code review: Laurent.Delayen Change 3369462 on 2017/03/29 by Thomas.Sarkanen Add preview mesh to animation blueprints Auto set preview mesh for animation assets and animation blueprints based off meshes. #jira UE-40032 - Creating animation assets from right-clicking skel mesh results in showing incorrect mesh in Persona Change 3369463 on 2017/03/29 by Thomas.Sarkanen We now select current preview mesh in the preview mesh dropdown Change 3369464 on 2017/03/29 by Thomas.Sarkanen Ticks now appear properly on anim sequence scrub bar #jira UE-41197 - No additional ticks appear on the timeline when you zoom in Change 3369465 on 2017/03/29 by Thomas.Sarkanen Persona now depends publicly on SkeletonEditor GitHub PR #3431 from kayama-shift #jira UE-43344 - GitHub 3431 : Persona module must depend on SkeletonEditor publically Change 3369466 on 2017/03/29 by Thomas.Sarkanen Blueprints are now only dirtied if edited properties are from objects in the Blueprint's package #jira UE-38956 - Changing Bone Transform between World and Local Location dirties Anim Blueprints Change 3369467 on 2017/03/29 by Thomas.Sarkanen Tweaked combo box alignment for world/local transform Appearance is now closer to that of the level editor Change 3369469 on 2017/03/29 by Thomas.Sarkanen Prevent switching to unsupported widget modes when editing control rigs #jira UE-42557 - When in Animation Mode, if you select a controller with the translation gizmo active, when you select a non animation controller the gizmo renders incorrectly Change 3369588 on 2017/03/29 by Thomas.Sarkanen Make import data and thumbnail data transactional #jira UE-41579 - Undo not working for several Asset Details options in Skeletal Mesh editor (Persona) Change 3369609 on 2017/03/29 by Thomas.Sarkanen Montages are now correctly initialized when created They can be used straight away without first opening them in the montage edtior. Moved initialization of composite sections from SMontageEditor to AnimMontageFactory. #jira UE-41219 - Animation montages created via Right click Create montage, that aren't opened in persona will not animate when used in an AnimBP Change 3369610 on 2017/03/29 by Thomas.Sarkanen Fixed anim class being set by name, causing duplicate-named anim BPs to be incorrectly resolved #jira UE-39833 - SkelMesh Component > Anim Class does not handle identical AnimBP names Change 3369647 on 2017/03/29 by Ori.Cohen Fix mass debug not working when moving components in the editor. #JIRA UE-43437 Change 3369875 on 2017/03/29 by Ori.Cohen Added the call into overlap instead of computePenetration when possible. There are edge cases that exist when computePenetration returns false but overlap returns true. Originally we were using computePenetration for all overlaps to make it consistent. However, computePenetration doesn't handle trimeshes correctly in certain cases. The reason for this is so that we can at least resolve a known issue with overlap events with complex collision. Nvidia may give us a flag for computePenetration to not do back-face culling which would give us a more consistent result. #JIRA UE-25923 Change 3370144 on 2017/03/29 by Lina.Halper Fix on the retargeting child anim BP #rb: Martin.Wilson #jira: UE-39928 Change 3371480 on 2017/03/30 by James.Golding Changes by BryanG at Nvidia required to get them up and running with plugins that override some skeletal mesh stuff. #jira UE-42132 Change 3371484 on 2017/03/30 by Thomas.Sarkanen We now propagate thread safety flags to child Animation Blueprints Change 3371486 on 2017/03/30 by Thomas.Sarkanen Fixed crash and effector selection issues for two bone IK Crash occured when selecting the root bone as the end of the chain. Viewport selection was not working at all as we werent creating any selection proxy actors any more. Change 3371497 on 2017/03/30 by Thomas.Sarkanen Added warning when Sequencer tries to write to properties that have changed type #jira UE-42098 - Sequencer writes rotation data to transform properties, causes assert Change 3371614 on 2017/03/30 by Martin.Wilson Clean up deprecated property value after load so we dont get extra anim blueprint references #jira UE-42501 Change 3371619 on 2017/03/30 by James.Golding Fix CIS by removing unneeded UNREALED_API from FImportSkeletalMeshArgs Change 3372452 on 2017/03/30 by Jon.Nabozny Add flag to CharacterMovementComponent to determine whether or not character should Sweep while using NavWalking, instead of relying on GenerateOverlaps flag. #jira UE-36546 Change 3373043 on 2017/03/30 by Lina.Halper - Consolidating to FastLerp to simply code - Added comment on FastLerp as the result is not normalized #rb: Michael.Noland, David.Hill Change 3373292 on 2017/03/30 by Jeff.Farris Made Actor.DispatchPhysicsCollisionHit virtual. (Copied CL 3261103 from Robo Recall to Dev-AnimPhys) Change 3373293 on 2017/03/30 by Jeff.Farris Added PhysicalAnimationComponent.GetBodyTargetTransform (Copied 3256175 from RoboRecall to Dev-AnimPhys) Change 3373318 on 2017/03/30 by Jeff.Farris Added option for components to opt out of physics impulses on damage. (Copied CL 3282585 from RoboRecall to Dev-AnimPhys) Change 3374064 on 2017/03/31 by Thomas.Sarkanen Renaming curves in animations is now saved properly Guids were not being set, so loading code obliterated the rename after an editor restart #jira UE-40582 - Curve name is not updated when user changes it in persona editor. Change 3374175 on 2017/03/31 by Thomas.Sarkanen Two bone IK UI consistency fixes Completely removed all bone select actors. They have a terrible UX anyway. We now rely only on our custom hit proxy and use a unified path to generate effector locations to draw and manipulate. #jira UE-42359 - Two Bone IK modifying effector location from viewport when bone is not set Change 3374216 on 2017/03/31 by Martin.Wilson Clear raw curve data during cooking + change Paragon game code so that it reads from the compressed curve data on Anim Sequences, not the raw data #jira UE-37897 Change 3374253 on 2017/03/31 by Thomas.Sarkanen Supplementary fix to CL 3371497 Adding name exposure for property types that we support Change 3374298 on 2017/03/31 by Jeff.Farris Code change from nVidia that improves physX perf (afterIntegration time). (Copied CL 3302239 from Robo Recall to Dev-AnimPhys) Change 3374432 on 2017/03/31 by Lina.Halper Make sure AcitveBoneIndices contains parent #jira: UE-14597 #rb: Martin.Wilson #code review: Benn.Gallagher, Alexis.Matte, James.Golding Change 3374836 on 2017/03/31 by Jon.Nabozny Fixup hits returned before start of trace in raycast_capsule. This change is copied from CL-3297212 #jira UE-42532 Change 3375195 on 2017/03/31 by Lina.Halper resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375282 on 2017/03/31 by Lina.Halper Fix odin content for animation : resave animation sequence for increasing info to warning #code review: Thomas.Sarkanen #jira: UE-40643 Change 3375288 on 2017/03/31 by Lina.Halper reverting code of degrading warning to info to avoid warning #jira: UE-40643 Change 3375865 on 2017/04/01 by Lina.Halper fix build error Change 3375868 on 2017/04/01 by Lina.Halper fix build warning on shadow var #code review: Thomas.Sarkanen Change 3376283 on 2017/04/03 by Thomas.Sarkanen Reworked, more generic property path handling in object change listener This allows all paths (auto vs manual key) to use the same code path, as well as regularizing the special-case handling of structs and arrays (and combinations thereof). The gist of the new implementation is to traverse the property path until we come across any property that satisfies our crirtera (exposed function, Interp flag etc.) Tweaked PropertyHandleToPropertyPath to correctly handle the slightly different way FPropertyNodes are arranged inside IPropertyHandle chains. IPropertyHandle chains contain arrays in a manner designed for display in the property editor, e.g. Container.Array.Array[ArrayIndex].StructInner. We need to collapse adjacent array properties as we are looking for Container.Array[ArrayIndex].StructInner to form a well-formed 'property path'. Small tweak to FPropertyChangedParams::GetPropertyValue. This is to handle property paths that end in an array (e.g. Struct.Array[0]). #jira UE-42271 - Pressing enter while the spine is in IK doesn't set any keys Change 3376320 on 2017/04/03 by Benn.Gallagher Merging from OR39 - Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver #jira OR-36926 Change 3376413 on 2017/04/03 by Benn.Gallagher Merge from OR - Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system. #jira OR-36927 Change 3376421 on 2017/04/03 by Benn.Gallagher Missed file from OR cloth fixes merge Change 3376456 on 2017/04/03 by Lina.Halper Resave fortnite animation to remove warning #rb: none Change 3376479 on 2017/04/03 by Jon.Nabozny Touch PhysXLibs to ensure physx links properly. (Needed for CL-3374836) Change 3376610 on 2017/04/03 by Martin.Wilson Fix for crash when reimporting lodded mesh with virtual bones #jira UE-43557 Change 3376618 on 2017/04/03 by Jurre.deBaare Mesh Paint decrement rate is too slow when used with hotkeys #fix change way we increase/decrease brush value #jira UE-43402 Change 3376650 on 2017/04/03 by Benn.Gallagher Converted clothing asset editor warnings into toasts + logs so they are more discoverable by the user. #jira UE-41739 Change 3376771 on 2017/04/03 by Benn.Gallagher Fixed clothing selection dropdowns to no longer get out of sync with actual state (if the binding fails it falls back to the "None" selection correctly internally) #jira UE-41737 Change 3378117 on 2017/04/04 by Thomas.Sarkanen Prevented ensure by reverting to default unit vectors if zero-sized lookat/lookup vectors are specified Also added a warning to inform users of the issue. #jira UE-43360 - Enabling Use LookUp Axis causes handled ensure to occur Change 3378118 on 2017/04/04 by Thomas.Sarkanen Fix 2-bone IK flickering First changed non-triangular range check to be >= instead of >. Also removed fallback to doubled-back as this singularity also occurs at min stretch + float epsilon (which caused the flicker). We are OK to call ACos with out-of-range values as it clamps internally and the subsequent calculations work in these degenerate cases. #jira UE-43525 - Mesh Flicker when Two Bone IK is stretched Change 3378192 on 2017/04/04 by Benn.Gallagher Trivial fix to clothing dropdowns to unbind clothing assets when switching Change 3378206 on 2017/04/04 by Thomas.Sarkanen Fix IncludeTool static analysis errors Traced this back to the checkin that moved advanced preview scene into its own module. Further refined this to be the dependency on SharedSettingsWidgets. Simplest solution was to move the details customization back into the DetailsCustomizations module. #jira UE-43563 - //UE4/Dev-AnimPhys: Compile IncludeTool Static analysis Win64 completed with 1 error Change 3378207 on 2017/04/04 by Thomas.Sarkanen Fix static analysis warning Change 3378267 on 2017/04/04 by Benn.Gallagher Disabled "Accurate" wind mode selection for 4.16 by hiding enum option for windmode. Looks like there are some simulation issues that need resolved. Wind will act as it always has for 4.16. Change 3378268 on 2017/04/04 by Benn.Gallagher Fixed bounds calculation on clothing to stop dissapearances or flickering at the edge of the screen. #jira UE-40407 Change 3378342 on 2017/04/04 by Jurre.deBaare Bone LOD preview doesn't get update if change removed bones array directly in Skeletalmesh editor #fix ensure that we update the skeleton tree when changes to the bones are made #misc made sure the reapply button its visibility is dynamic #misc made sure we always re-add previously removed bones when necessary #jira UE-40500 Change 3378374 on 2017/04/04 by Thomas.Sarkanen Fixed animation not working for dynamically-bound wheeled-vehicle anim instances Vehicle anim instance now looks for a wheeled vehicle component when it initializes. #jira UE-41048 - Set Anim Instance Class no longer works with Wheeled Vehicle Pawns Change 3378518 on 2017/04/04 by Jon.Nabozny Fix jump height becoming frame dependent when JumpMaxHoldTime > 0. #jira UE-23695 Change 3378538 on 2017/04/04 by Martin.Wilson Speculative fix for unreproducable crash on loading animations #jira OR-37157 Change 3378592 on 2017/04/04 by Jurre.deBaare Mesh painting tools not working outside of QAGame #fix required a direct loadmodule call Change 3378622 on 2017/04/04 by Jurre.deBaare CIS shadow variable fix Change 3378742 on 2017/04/04 by Thomas.Sarkanen Fixed crash entering PIE in Orion Change 3378907 on 2017/04/04 by Benn.Gallagher Re-added wind adaptiive effects to legacy wind path. Fixed math error in damping calculations (log2/loge). #jira UE-42044 Change 3379240 on 2017/04/04 by Jon.Nabozny Fix SkeletalMeshComponent GetWeldedBodies not returning actual Skeletal Bodies Change 3379415 on 2017/04/04 by Jon.Nabozny Fix Skeletal Meshes imported with non-identity transform from reapplying transform when simulation is enabled / disabled. #JIRA UE-32598 Change 3379502 on 2017/04/04 by Lina.Halper Mirroring issue with flipping rotation due to not counting scale #jira: UE-33646, UE-34489 #rb: Ori.Cohen #code review: Zak.Middleton Change 3380544 on 2017/04/05 by Thomas.Sarkanen Fix warning spam when playing back UMG sequences animating visibility Reduced runtime overhead to a simple size check. This catches 90% of problem issues with much less runtime overhead. It would be well worth getting an FName-based type check working at some point, although we would need speciall case enum handling. Also removed message log usage in shipping/test builds. #jira UE-43621 - Large number of Sequencer warnings occur after opening Paragon in Pie - Property type mismatch for property 'Visibility'. Expected 'uint8', found 'ESlateVisibility'. Change 3380605 on 2017/04/05 by Benn.Gallagher Fix clothing simulation to correctly index a master pose component for clothing pose data. Fixes integration blocking crash in UT when picking up the flag which sets a master pose mid-game. #jira UE-43624 Change 3381025 on 2017/04/05 by Jon.Nabozny Change ensure in UpdateKinematicBonesToAnim to ensureMsgf so we can track down potential content issues. Change 3381475 on 2017/04/05 by Lina.Halper Fix crash on creating montage and setting slot node #jira: UE-43698 #rb: Ori.Cohen Change 3381558 on 2017/04/05 by Lina.Halper Better clean up of flipping issue of quaternion issue #jira: UE-33646, UE-34489 #rb: Zak.Middleton Change 3381789 on 2017/04/05 by Jon.Nabozny Revert InitAnim changes from CL-3379415 to fix cook warnings. (Will have proper fix for 4.17 instead). Change 3381978 on 2017/04/05 by Aaron.McLeran #jira UE-43654 Fixing oculus audio SDK sample rate issue Change 3383181 on 2017/04/06 by Lina.Halper Remove copy right of Dual quaternion since we no longer uses #code review:Leslie.Nivison Change 3383283 on 2017/04/06 by Ori.Cohen Fixed missing invalidation for body setup when modifying materials #JIRA UE-43680 Change 3383602 on 2017/04/06 by Lina.Halper Fixed scroller in retargeting window #jira: UE-43736 Change 3384369 on 2017/04/07 by Jurre.deBaare Wrong bone is sometimes highlighted in skeleton editor #fix new behaviour caused the user to try and select a bone if we didn't find on through hit proxies #jira UE-43735 Change 3384744 on 2017/04/07 by Jon.Nabozny Fix body rotation being killed on load. #JIRA UE-43771 [CL 3385232 by Thomas Sarkanen in Main branch]
2017-04-07 16:51:51 -04:00
}
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3847469) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3805828 by Gil.Gribb UE4 - Fixed a bug in the lock free stalling task queue and adjusted a comment. The code is not current used, so this is not actually change the way the code works. Change 3806784 by Ben.Marsh UAT: Remove code to compile UBT when using UE4Build. It should already be compiled as a dependency of UAT. Change 3807549 by Graeme.Thornton Add a cook timer around VerifyCanCookPackage. A licensee reports this taking a lot of time so it'll be good to account for it. Change 3807727 by Graeme.Thornton Unhide the text asset format experimental editor option Change 3807746 by Josh.Engebretson Remove WER from iOS platform Change 3807928 by Robert.Manuszewski When async loading, GC Clusters will be created after packages have been processed to avoid situations where some of the objects that are being added to a cluster haven't been fully loaded yet Change 3808221 by Steve.Robb GitHub #4307 - Made GetModulePtr() thread safe by not using GetModule() ^ I'm not convinced by how much thread-safer this is really, but it's tidier anyway. Change 3809233 by Graeme.Thornton TBA: Misc changes to text asset commandlet - Rename mode to "loadsave" - Add -outputFormat option which can be assigned "text" or "binary" - When saving binary, use a differentiated filename so that source assets aren't overwritten Change 3809518 by Ben.Marsh Remove the outdated UnrealSync automation script. Change 3809643 by Steve.Robb GitHub #4277 : fix bug; FMath::FormatIntToHumanReadable 3rd comma and negative value #jira UE-53037 Change 3809862 by Steve.Robb GitHub #3342 : [FRotator.h] Fix to DecompressAxisFromByte to be more efficient and reflect its intent accurately #jira UE-42593 Change 3811190 by Graeme.Thornton Add support for writing specific log channels to their own files Change 3811197 by Graeme.Thornton Minor updates to output formatting and timing for the text asset commandlet Change 3811257 by Robert.Manuszewski Cluster creation will now be time-sliced Change 3811565 by Steve.Robb Define out non-monolithic module functions. Change 3812561 by Steve.Robb GitHub #3886 : Enable Brace-Initialization for Declaring Variables Incorrect semi-colon search removed after discussion with author. Test added. #jira UE-48242 Change 3812864 by Steve.Robb Removal of some unproven code which was supposed to fix hot reloading BP class functions in plugins. See: https://udn.unrealengine.com/questions/376978/aitask-blueprint-nodes-disappear-when-their-module.html #jira UE-53089 Change 3820358 by Ben.Marsh PR #4358: Incredibuild use ShowAgent by default (Contributed by projectgheist) Change 3822594 by Ben.Marsh UAT: Improvements to log file handling. - Always create log files in the final location, rather than writing to a temp directory and copying in later. - Now supports -Verbose and -VeryVerbose for increasing log verbosity, rather than -Verbose=XXX. - Keep a backlog of log output before the log system is initialized, and flush it to the log file once it is. - Allow buildmachines to specify the uebp_FinalLogFolder environment variable, which is used to form paths for display. When build machines copy log files elsewhere after UAT finishes (eg. a network share), this allows error messages to display the right location. Change 3823695 by Ben.Marsh UGS: Fix issue where precompiled binaries would not be shown as available for a change until scrolling the last submitted code change into the buffer (other symptoms, like de-focussing the main window would cause it to go back to an unavailable state, since the changes buffer was shrunk). Now always queries changes up to the last change for which zipped binaries are available. Change 3823845 by Ben.Marsh UBT: Exclude C# projects for unsupported platforms when generating project files. Change 3824180 by Ben.Marsh UGS: Add an option to show changes by build machines, and move the "only show reviewed" option in there too (Options > Show Changes). #jira Change 3825777 by Steve.Robb Fix to return value of StringToBytes. Change 3825810 by Ben.Marsh UBT: Reduce length of include paths for MSVC toolchain. Change 3825822 by Robert.Manuszewski Optimized PIE lazy pointer fixup. Should be up to 8x faster now. Change 3826734 by Ben.Marsh Remove code to disable TextureFormatAndroid on Linux. It seems to be an editor dependency. Change 3827730 by Steve.Robb Try to avoid decltype(auto) if it's not supported. See: https://udn.unrealengine.com/questions/395644/build-417-with-c11-on-linux-ttuple-errors.html Change 3827745 by Steve.Robb Initializer list support for TMap. Change 3827770 by Steve.Robb GitHub #4399 : Added a CONSTEXPR qualifiers to FVariant::GetType() #jira UE-53813 Change 3829189 by Ben.Marsh UBT: Now always writes a minimal log file. By default, just contains the regular console output and any reasons why actions are outdated and needed to be executed. UAT directs child UBT instances to output logs into its own log folder, so that build machines can save them off. Change 3830444 by Steve.Robb BuildVersion and ModuleManifest moved to Core, and parsing of these files reimplemented to avoid a JSON library. This should be revisited when Core has its own JSON library. Change 3830718 by Ben.Marsh Fix incorrect group name being returned by FStatNameAndInfo::GetGroupName() for stat groups. The editor populates the viewport stats list by calling this for every registered stat and stat group (via FLevelViewportCommands::HandleNewStatGroup). The menu entry attempts to show the stat name with STAT_XXX stripped from the start as the menu item label, with the free-form text description as a tooltip. For stat groups, the it would previously just return the stat group name as "Groups" (due to the raw naming convention of "//Groups//STATGROUP_Foo//..."). Since this didn't match the expected naming convention in FLevelViewportCommands::HandleNewStat (ie. STAT_XXX or STATGROUP_XXX), it would fail to add it. When the first actual stat belonging to that group is added, it would add a menu entry for the group based on that, but the stat description no longer makes sense as a tooltip for the group. As a result, all the editor tooltips were junk. #jira UE-53845 Change 3831064 by Ben.Marsh Fix log file contention when spawning UBT recursively. Change 3832654 by Ben.Marsh UGS: Fix error panel not being selected when opened, and weird alignment/color issues on it. Change 3832680 by Ben.Marsh UGS: Fix failing to detect workspace if synced to a different stream. Seems to be a regression caused by recent P4D upgrade. Change 3832695 by Ben.Marsh UGS: Invert the options in the 'Show Changes' submenu for simplicity. Change 3833528 by Ben.Marsh UAT: Script to rewrite source files with public include paths relative to the 'Public' folder. Usage is: RebasePublicIncludePaths -UpdateDir=<Dir> [-Project=<Dir>] [-Write]. Change 3833543 by Ben.Marsh UBT: Allow targets to opt-out of having public include paths added for every dependent module. This reduces the command line length when building a target, which has recently become a problem with larger games (due to Microsoft's compiler embedding the command line into each object file, with a maximum length of 64kb). All engine modules are compiled with this enabled; games may opt into it by setting bLegacyPublicIncludePaths = false; from their .target.cs, as may individual modules. Change 3834354 by Robert.Manuszewski Archetype pointer will now be cached to avoid locking the object tables when acquiring its info. It should also be faster this way regardless of any locks. #jira UE-52035 Change 3834400 by Robert.Manuszewski Fixing crash on exit caused by cached archetypes not being cleaned up before static exit cleanup. #jira UE-52035 Change 3834947 by Steve.Robb USE_FORMAT_STRING_TYPE_CHECKING removed from FMsg::Logf and FMsg::Logf_Internal. Change 3835004 by Ben.Marsh Fix code that relies on dubious behavior of requiring referenced "include path only" modules having their _API macros set to be empty, even if the module is actually implemented in a separate DLL. Change 3835340 by Ben.Marsh Fix errors making installed build from directories with spaces in the name. Change 3835972 by Ben.Marsh UBT: Improved diagnostic message for targets which don't need a version file. Change 3836019 by Ben.Marsh UBT: Fix warnings caused by defining linkage macros for third party libraries. Change 3836269 by Ben.Marsh Fix message box larger than the screen height being created when a large number of modules are incompatible on startup. Change 3836543 by Ben.Marsh Enable SoundMod plugin on Linux, since it's already supported through the editor. Change 3836546 by Ben.Marsh PR #4412: fix type mismatch (Contributed by nakapon) Change 3836805 by Ben.Marsh Fix commandlet to compile marketplace plugins. Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3837036 by Ben.Marsh UBT: Write the previous and new contents of intermediate files to the log if they change. Makes it easier to debug unexpected rebuilds. Change 3837037 by Ben.Marsh UBT: Fix engine modules having inconsistent definitions depending on whether modules are only referenced for their include paths vs being linked into a binary (due to different _API macro). Change 3837040 by Ben.Marsh UBT: Remove code that initializes members in ModuleRules and TargetRules objects before the constructor is run. This is no longer necessary, now that the backwards-compatible default constructors have been removed. Change 3837247 by Ben.Marsh UBT: Remove UELinkerFixups module, now that plugins and precompiled modules do not require hacks to force initialization (since they're linked in as object files). Encryption and signing keys are now set via macros expanded from the IMPLEMENT_PRIMARY_GAME_MODULE macro, via project-specific macros added in the TargetRules constructor. Change 3837262 by Ben.Marsh UBT: Set whether a module is an engine module or not via a default value for the rules assembly. All non-program engine and enterprise modules are created with this flag set to true; program targets and modules are now created from a different assembly that sets it to false. This removes hacks from UEBuildModule needed to adjust behavior for different module types based on the directory containing the module. Also add a bUseBackwardsCompatibleDefaults flag to the TargetRules class, also initialized to a default value from a setting passed to the RulesAssembly constructor. This controls whether modules created for the target should be configured to allow breaking changes to default settings, and is set to false for all engine targets, and true for all project targets. Change 3837343 by Ben.Marsh UBT: Remove the OverrideExecutableFileExtension target property. Change the only current use for this (the MayaLiveLinkPlugin target) to use a post build step to copy the file instead. Change 3837356 by Ben.Marsh Fix invalid character encodings. Change 3837727 by Graeme.Thornton UnrealPak: KeyGenerator: Only generate prime table when required, not all the time Change 3837823 by Ben.Marsh UBT: Output warnings and errors when compiling module rules assembly in a way that allows them to be double-clicked in the Visual Studio output window. Change 3837831 by Graeme.Thornton UBT: When parsing crypto settings, always load legacy data first, then allow the new system to override it. Provides the same key backwards compatibility that the editor settings class gives Change 3837857 by Robert.Manuszewski PR #4404: Make FGCArrayPool singleton global instead of per-CU (Contributed by mhutch) Change 3837943 by Robert.Manuszewski PR #4405: Fix FGarbageCollectionTracer (Contributed by mhutch) Change 3838451 by Ben.Marsh UBT: Fix exceptions thrown on a background thread while caching C++ includes not being caught and logged correctly. Now captures exceptions and re-throws on the main thread. #jira UE-53996 Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 3843790 by Graeme.Thornton UnrealPak: Log the size of all encrypted data Change 3844258 by Ben.Marsh Fix plugin compile failure when created via new plugin wizard. Passing -plugin on the command line is unnecessary, and is now reserved for packaging external plugins for the marketplace. Also extend the length of time that the error toast stays visible, and don't delete the plugin on failure. #jira UE-54157 Change 3845796 by Ben.Marsh Workaround for slow performance of String.EndsWith() on Mono. Change 3845823 by Ben.Marsh Fix case sensitive matching of platform names in -TargetPlatform=X argument to BuildCookRun. #jira UE-54123 Change 3845901 by Arciel.Rekman Linux: fix crash due to lambda lifetime issues (UE-54040). - The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+). (Edigrating 3819174 to Dev-Core) Change 3846439 by Ben.Marsh Revert CL 3822742 to always call Process.WaitForExit(). The Android target platform module in the editor spawns ADB.EXE, which inherits the editor's stdout/stderr handles and forks itself. Process.WaitForExit() waits for EOF on those pipes, which never occurs because the forked process never terminates. Proper fix is probably to have the engine explicitly duplicate stdout/stderr handles for new pipes to output process, but too risky before copying up to Main. Change 3816608 by Ben.Marsh UBT: Use DirectoryReference objects for all include paths. Change 3816954 by Ben.Marsh UBT: Remove bIncludeDependentLibrariesInLibrary option. This is not widely supported by platform toolchains, and is not used anywhere. Change 3816986 by Ben.Marsh UBT: Remove UEBuildBinaryConfig; UEBuildBinary objects are now just created directly. Change 3816991 by Ben.Marsh UBT: Deprecate PlatformSpecificDynamicallyLoadedModules. We no longer have any special behavior for these modules. Change 3823090 by Ben.Marsh UAT: Improve logging for child UAT instances. - Calling RunUAT now requires an identifier for prefixing into the parent log, which is also used to determine the name of the log folder. - Stdout is no longer written to its own output file, since it's written to the parent stdout, the parent log file, and the child log file anyway. - Log folders for child UAT instances are left intact, rather than being copied to the parent folder. The derived names for the copied names were confusing and hard to read. - Output from UAT is no longer returned as a string. It should not be parsed anyway (but may be huge!). ProcessResult now supports running without capturing output. Change 3826082 by Ben.Marsh UBT: Add a check to make sure that all modules that are precompiled are correctly marked to enable it, even if they are part of the build target. Change 3827025 by Ben.Marsh UBT: Move the compile output directory into a property on the module, and explicitly pass it to the toolchain when compiling. Change 3829927 by James.Hopkin Made HTTP interface const correct Change 3833533 by Ben.Marsh Rewrite engine source files to base include paths relative to the "Public" directory. This allows reducing the number of public include paths that have to be added for engine modules. Change 3835826 by Ben.Marsh UBT: Precompiled targets now generate a separate manifest for each precompiled module, rather than adding object files to a library. This fixes issues where object files from static libraries would not be linked into a target if a symbol in them was not referenced. Change 3835969 by Ben.Marsh UBT: Fix cases where text is being written directly to the console rather than via logging functions. Change 3837777 by Steve.Robb Format string type checking added to FOutputDevice::Logf. Fixes for those. Change 3838569 by Steve.Robb Algo moved up a folder. [CL 3847482 by Ben Marsh in Main branch]
2018-01-20 11:19:29 -05:00
IMPLEMENT_MODULE(FAdvancedPreviewSceneModule, AdvancedPreviewScene);
Reference in New Issue Copy Permalink