3145 Commits
Author SHA1 Message Date
Kenix3andGitHub f85feadc27 Adds a REVIEWING.md documentation file (#160)
* Adds a first pass of REVIEWING.md

* Update REVIEWING.md

* Clarifies better what files can be in the header.

* More clarity on how to resolve jenkins build errors.

* Adds a link to the Code Review Guidelines to README.md

* Adds code review guidelines link to contributing.md

* Clarifies trello procedures.

* Adds warning that NON_MATCHING equivalence isn't reviewed for yet.
2021-05-30 11:20:29 -04:00
Anghelo CarvajalandGitHub 2f239c939d ovl_Obj_Milk_Bin OK (#161)
* First pass

* second pass

* Everything matches now

* Fix ori

* final pass

* Add description

* Fix warnings (I hope)

* move dlist to top of the file

* Fix conflicts
2021-05-25 21:15:41 -04:00
6c86016603 partially finish code_0x8012EC80, document all of gSaveContext (#138)
* not ok, why?

* OK!

* fix data

* finish data etc

* work on save context

* save finished

* first func done

* roomInf

* done for now

* add missing file

* add most og names for struct members

* fix accidental change

* Update z_en_ginko_man.c

* Update z_scene.c

* maybe fix stuff hopefully

* proto

* sasa

* Update include/z64save.h

Co-authored-by: Anghelo Carvajal <anghelo.carvajal.14@sansano.usm.cl>

* Update z64save.h

Co-authored-by: Anghelo Carvajal <anghelo.carvajal.14@sansano.usm.cl>
2021-05-25 18:49:11 -04:00
cf3eb3b2e1 Ovl_En_Fg OK (#133)
* En_Fg Frogs 9/18 decompiled

* En_Fg Frogs One Non-Matching

* documentation and cleanup

* final matched function

* code_script

* whitespace

* Fixed some mistakes, EnFg_UpdateDust no longer matches?

* fixed nonmatching

* Minor fixes and documentation

* PR suggestions

* Fixed genericHeader rename to common

* Fix Warnings

* PR Good Documentation Suggestions

* update names

* more pr suggestions

Co-authored-by: Jared Collette <jcollette@4000v-udp25-l.eng.unimelb.edu.au>
Co-authored-by: engineer124 <engineer124enginer124@gmail.com>
2021-05-22 11:36:21 -04:00
f4687fbbe7 General Cleanup (#155)
* minor fixes

* Consolidate into globalCtx

* fix error

* Fix Warnings

Co-authored-by: engineer124 <engineer124enginer124@gmail.com>
2021-05-20 21:24:47 -04:00
Zach BanksandGitHub 8c62c102cf CONTRIBUTING.md (#157)
* Draft CONTRIBUTING.md

* Expand PR process; mention KZ

* More TODO

* Add notes about documenting

* Address (most) PR comments

* Finish responding to PR comments; add PR template

* Fix grammar

* Add missing periods. More actor examples. Remove ref to booleans

* Add note about `NON_EQUIVALENT`; bold asset warning

* Condense PR template

* PR feedback from Kenix; Condense PR template

* Incorporate Thar0's feedback
2021-05-20 21:06:30 -04:00
Anghelo CarvajalandGitHub 062a813fba Misc fixes (#159)
* Fix `extract_assets` not properly checking if scenes files were updated

* fix `first_diff.py` path due to the baserom renaming

* FlexSkeletonHeader and other stuff

* fix some SkeletonHeader instead of FlexSkeletonHeader

* Add blob compilation to makefile

* CURRENT_DAY and type swaps

* Remove extra cast

* run format

* zbanks suggestions
2021-05-20 18:52:07 -04:00
Zach BanksandGitHub 458dd13141 ovl_Bg_Ladder: OK (Wooden Ladder) (#135)
* ovl_Bg_Ladder: OK (Wooden Ladder)

* Change sLadderDLists type; add comment about thisx

* Add macros for BgLadder params; rename object symbols
2021-05-20 18:06:00 -04:00
Parker BurnettandGitHub cb89346c28 Obj_moon_stone Matching (#154)
* most all matching, just one func left

* forgot about the object script

* Moon's Tear OK

* fixing suggestions

* fixing actor pointers
2021-05-20 17:43:27 -04:00
Derek HensleyandGitHub e17b05b8fa Ovl_Bg_Ctower_Rot Ok (#149)
* Ovl_Bg_Ctower_Rot Ok

* Move enum to h file

* Rename D_808E2564 to bgCtowerRotDlists

* Rename D_808E2564 to bgCtowerRotDlists take 2
2021-05-20 17:23:23 -04:00
Anghelo CarvajalandGitHub 25afa196f6 Make Jenkins check if a PR will add new warnings (#150)
* warning count

* update warnings

* Update warnings

* Use `tee`

* Suggestions of zbanks

* I hope this will fix it
2021-05-19 22:14:20 -04:00
Zach BanksandGitHub 43ccf66c48 ovl_En_Torch2 OK (Elegy of Emptiness Shell) (#130)
* ovl_En_Torch2 OK (Elegy of Emptiness Statue)

* Identify dlists; address PR comments

* Rename object segment symbols
2021-05-19 20:58:32 -04:00
Derek HensleyandGitHub 5e7e5a1d9f Ovl_Obj_Tokei_Step OK (#122)
* Everything matches but func_80AD6508

* Changed func_80AD6508 to non_matching

* Some cleanup

* Everything matches

* Finished cleanup and documentation

* Updated BgMeshHeader to Collision Header

* Add newline

* Update functions.txt

* Better function names

* format

* Better naming
2021-05-19 20:24:33 -04:00
Zach BanksandGitHub ad9c5565ee z_view matching (#134) 2021-05-19 17:01:22 -04:00
Anghelo CarvajalandGitHub f3dc829456 ovl_Eff_Dust OK (#136)
* some easy functions

Signed-off-by: Angie <angheloalf95@gmail.com>

* init is cursed

Signed-off-by: Angie <angheloalf95@gmail.com>

* func_80919230 is weird

Signed-off-by: Angie <angheloalf95@gmail.com>

* I'm dumb

Signed-off-by: Angie <angheloalf95@gmail.com>

* func_80919768 nonmatching

Signed-off-by: Angie <angheloalf95@gmail.com>

* everything is wrong

Signed-off-by: Angie <angheloalf95@gmail.com>

* This thing still doesn't want to match

Signed-off-by: Angie <angheloalf95@gmail.com>

* improved a bit

Signed-off-by: Angie <angheloalf95@gmail.com>

* a bit of renaming, but it still doesn't work

Signed-off-by: Angie <angheloalf95@gmail.com>

* almost matching

* func_80919768 ok

* func_809199FC ok

* init was dumb

* add enum and other minor changes

* run format
2021-05-18 23:01:48 -04:00
Anghelo CarvajalandGitHub 4d6d9c27a4 code_0x8017FEB0 OK (#137)
* almost every function

* atans ok

* import data and rodata

* format `atan_first_8th_array`

* fix signature and rodata

* rename to angle

* Rename the functions to match their OoT counterparts

* rename code_0x8017FEB0 to sys_math_atan
2021-05-18 22:58:30 -04:00
Zach BanksandGitHub dea3c8fd79 Fix all warnings raised by IDO (#152)
* Fix all warnings raised by IDO, ignore trailing commas

* Set -woff=624,...; keep const in printf functions

* Remove redefined macros in irqmgr.c

* Remove DECR macro & reformat

* Address PR comments from AngheloAlf
2021-05-18 22:28:04 -04:00
Anghelo CarvajalandGitHub 7f14659919 diff.py symlink and graphovl.py (#151)
* Add `diff.py` symlink

* Add graphovl.py

* remove graphovl

* add graphovl subrepo

* git subrepo pull --force tools/graphovl

subrepo:
  subdir:   "tools/graphovl"
  merged:   "577e7159"
upstream:
  origin:   "https://github.com/AngheloAlf/graphovl.git"
  branch:   "master"
  commit:   "577e7159"
git-subrepo:
  version:  "0.4.3"
  origin:   "???"
  commit:   "???"
2021-05-18 22:21:14 -04:00
Anghelo CarvajalandGitHub c56934038a Format everything (#141)
* Add trailing comma

* Run format and add some missing trailing commas

* Enforce the same clang-format version for everybody

* z_en_m_fire1
2021-05-18 20:00:36 -04:00
Zach BanksandGitHub 091219d742 Small env fixes: git submodules & python3 (#127)
* Small env fixes: for git submodules & python3

Using `/usr/bin/env python3` is preferred over `/usr/bin/python3`
because it is compatible with virtualenvs, etc. It picks the version of
`python3` currently on the `PATH`, rather than the system-wide default.

For the git submodules, I had two issues:

The ZAPD repo is currently pointing at a commit not on the master
branch, which has to be specifically fetched. Adding `--remote` to the
update command fixes this.

The decomp-permuter has primary branch `main` not `master` like this
repo, so this has to be specified in `.gitmodules` when using `--remote`.

* Rework `git submodule update...` part of Makefile
2021-05-18 19:53:11 -04:00
Anghelo CarvajalandGitHub 0e3e008da4 Hotfix: Fix running make init without -jN (#139)
* `assembly` target

* update phony

* temporary cp

* add todo

* use @hensldm suggestion
2021-05-18 19:20:31 -04:00
Parker BurnettandGitHub 490924df23 QOL addtions to the readme (#104)
* adding changes to the README

* adding in progress shield

adding in the shield icon to show percentage complete

* updating the files, added gitignore for ctx.c

* fixing the typos

* fixing things to hopefully build now
2021-05-18 18:39:08 -04:00
Zach BanksandGitHub c6fb5665d4 Split code BSS segment by file (#140)
Discussed on Discord: https://discord.com/channels/688807550715560050/688851976746041391/843916746989633547
2021-05-18 17:35:22 -04:00
Kenix3andGitHub 5a776fabde Updates progress.py script for the new location of built assets (#143) 2021-05-18 17:22:43 -04:00
Derek HensleyandGitHub 4279f12414 Ovl Bg_Ctower_Gear OK (#123)
* BgCtowerGear OK

* Added description header

* Updated functions.txt

* Added MACRO to get type

* Renamed init chains to match tyype

* Added one more use of Macro, and addressed PR comment

* Fixed data copy error and better naming
2021-05-13 22:15:06 -04:00