* Started uncommenting statics, but then realized this actor has BSS, lol.
* Import .data and .bss. Run format.sh.
* ObjSyokudai_Init OK and mostly documented.
* ObjSyokudai_Destroy OK and fully documented.
* ObjSyokudai_Draw OK and partially documented.
* Good progress on ObjSyokudai_Update, but NOT OK.
* Instruction match, but needs regalloc and stack.
* Stack is closer now.
* Obj_Syokudai OK, no new warnings, ran formatter.
* Documented .data and .bss variables.
* Final documentation pass before PR.
* Add header, fix build errors.
* Use COLTYPE_METAL and COLTYPE_WOOD macros.
* Apply suggestions from code review
engineer124's suggestions.
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Apply suggestions from code review
engineer124: WaterBox* instead of UNK_PTR
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Update src/overlays/actors/ovl_Obj_Syokudai/z_obj_syokudai.c
engineer124: AC_HARD -> AC_HIT so Jenkins stops complaining
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Hopefully fix Jenkins via z_bg_lotus WaterBox*.
* Rename sp2C to waterBox in BgLotus.
* Run format.sh.
* Update include/functions.h
Change func_800F22C4 param_1 from s8 to s16.
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Change func_801A5CFC param_1 to sfxId in prototype
* Document interactions.
* Run formatter.
* Clarify that posDiff is relative to stick *tip*.
* Changed interaction comparisons to better fit enum
* snuffTimer enum
* Added more #defines.
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* eeeee
* nonequivalents
* draw
* Import data
* Match Daytelop_LoadGraphics
* draw kinda better
* extract daytelops and gameover
* SEGMENT_ROM macros
* Use extracted symbols for daytelop
* match Daytelop_Draw
* Fix bss
* draw cleanup
* Daytelop_Update from non equivalent to non matching
* Some renames and spec
* Run formatter
* enum
* sfx
* Use SEGMENT_ROM_START macros everywhere
* more macros
* run formatter
* Add description
* update variables.txt
* Remove extra stuff in gbi.h
* Would this fix it?
* and again
* whoops
* Apply suggestions from code review
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
* Tharo's suggestions
* match Daytelop_Update
* run formatter
* fix merge issues
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
* Modify Kibako to use the same ID/FLAG macros as Kibako2
* Define KIBAKO_BANK_INDEX
* Add explanatory comment at the top of the file
* Add Kibako function names to functions.txt
* Define KIBAKO_BOMBER_CAN_HIDE_IN_BOX
* EnBigpo: start
* EnBigpo: uhh, this struct is weird
* EnBigpo: progress
* EnBigpo: so many of these functions are tiny
* EnBigpo nasty four loop function
* EnBigpo: hate draw functions
* EnBigpo: all functions attempted
* EnBigpo: data migrated, does not OK, 2 bytes off...
* Multi: Attempting to OK, issues
* EnBigpo: more docs
* EnBigpo: more docs2
* EnBigpo: more docs and cleaning
* EnBigpo: removed data to try to find the issues, matched a draw function thanks to Tharo
* EnBigpo: progress? maybe not
* EnBigpo: matched another function
* EnBigpo: overwrite limbdraw matches now
* EnBigpo: one more nonmatching rejected
* EnBigPo: not actual progress, probably
* Match Init, down to single stack pointer on second func
* EnBigPo OK
* EnBigpo: docs and cleaning
* EnBigpo: more docs and cleaning
* EnBigpo: back to OK with no warnings
* EnBigpo: more docs and cleaning
* EnBigpo: docs and cleaning
* EnBigpo: hmm, rename_sym doesn't like renaming system functions but I'm 98% sure I know what these are
* Multiple: changed some function names, maybe changed too much... hmm
* EnBigpo: even more changes to docs
* EnBigpo: formater pass
* EnBigpo: small fixes
* EnBigpo: c file description
* Apply suggestions from code review
Apply camera suggestions from eng124
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* EnBigpo: updating all requested changes and reverting one incorrect macro
* Apply suggestions from code review
Some of eng124's recommendations, need to add the last by hand
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* EnBigpo: back to OK
* EnBigpo: Minor cleanup changes
* Functions fixed: added function changes to actorfixer and fixed dinofos
* EnBigpo: BINANG_ROT180
* Apply suggestions from code review
First batch of requested changes, the simpler ones that shouldn't require checking
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
* EnBigpo: fixes to recommended changes, back to OK
* EnBigpo: move idleTimer docs out of struct
* Sprite: removed old commented out pragma, it matches, I still dont get it
* EnBigpo: more changes I had to check first
* EnBigpo: more requested changes, and some macro uses found
* EnBigpo: forgot a requested change
* Update src/overlays/actors/ovl_En_Bigpo/z_en_bigpo.c
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* EnBigPo: missed a disphead array access
* Apply suggestions from code review
More requested changes
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* EnBigpo: more hex to dec
* EnBigpo: more hex to dec 2
* Update src/overlays/actors/ovl_En_Bigpo/z_en_bigpo.c
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Update include/functions.h
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* EnBigpo: build being weird
* EnBigpo: weird, rename_sym didn't catch this earlier
* Tools: fixed actorfixer to use Play_CameraSetAtEye forgot I blew this change away trying to get build again,
* Update src/overlays/actors/ovl_En_Bigpo/z_en_bigpo.h
Co-authored-by: Kenix3 <kenixwhisperwind@gmail.com>
* EnBigpo: cutscene functions changed name to indicate they are stages
* EnBigpo: Rename Particles to Effect
* EnBigpo: changed draw function names, changed function comment format
* EnBigpo: renamed limbdraw functions, formater pass
Co-authored-by: isghj8 <isghj8@gmail.com>
Co-authored-by: engineer124 <engineer124engineer124@gmail.com>
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
Co-authored-by: Kenix3 <kenixwhisperwind@gmail.com>
Elliptic Ellipsis
EllipticEllipsisandGitHub
emilybrooksandGitHub
MaideandGitHub
Tom OvertonandGitHub
Kenix3andGitHub
