Obj_Kendo_Kanban OK and Documented (Decomp was mostly done already) (#1057)

* stuff

* Renaming in-process

- Changed action names and setup names based on examples.
- Undid some ill-advised changes that broke matching.
- Misc variable naming. Need verification and not all complete.

* wip renaming

* A bit more progress on determining names for everything.

* Done with naming.

* Touchup before review

* Updates from review:

- Leave displacementY/unk_AC0 naming to z_actor work.
- Remove unnecessary include of z64math.h, indirect inclusion preferred
- Add trailing comma for better formatting of sDisplayLists
- Rename of static vectors sNullVec3f->sZeroVec, sUnitVectorX->sUnitVecX
- Restore pad instead of using local const. Change const to #define
- Prefer index over idx
- Remove 'b' prefix from bHasNewRootCornerPos
- Const -> Enum and formatting in ObjKendoKanban_IsPlayerOnTop
- Rename 'Aerial' to 'Tumble'

* Missed items in review:
- Missed an instance of displacementY->unk_AC0 renaming (Cause of build failure)
- Whitespace formatting
- UNK_TYPE2 undo

* More adjustments from review:
- Undo accidental formatting changes to z64player.h, restoring to master.
- Naming and Formatting changes.
- Removing some comments.

* From review, qualify enum and #define with obj name, whitespace cleanup.
This commit is contained in:
StickyThwomp
2022-09-24 15:00:53 -03:00
committed by GitHub
parent 0aede274ae
commit d968e58f9c
4 changed files with 242 additions and 235 deletions
+9 -9
View File
@@ -14230,15 +14230,15 @@
0x80B64DFC:("func_80B64DFC",),
0x80B654C0:("ObjKendoKanban_Init",),
0x80B65840:("ObjKendoKanban_Destroy",),
0x80B65880:("func_80B65880",),
0x80B65894:("func_80B65894",),
0x80B658A4:("func_80B658A4",),
0x80B65CE0:("func_80B65CE0",),
0x80B65D54:("func_80B65D54",),
0x80B65D68:("func_80B65D68",),
0x80B65DA8:("func_80B65DA8",),
0x80B6618C:("func_80B6618C",),
0x80B66304:("func_80B66304",),
0x80B65880:("ObjKendoKanban_SetupDoNothing",),
0x80B65894:("ObjKendoKanban_DoNothing",),
0x80B658A4:("ObjKendoKanban_SetupTumble",),
0x80B65CE0:("ObjKendoKanban_Tumble",),
0x80B65D54:("ObjKendoKanban_SetupSettled",),
0x80B65D68:("ObjKendoKanban_Settled",),
0x80B65DA8:("ObjKendoKanban_HandlePhysics",),
0x80B6618C:("ObjKendoKanban_IsPlayerOnTop",),
0x80B66304:("ObjKendoKanban_UpdateCollision",),
0x80B66418:("ObjKendoKanban_Update",),
0x80B66454:("ObjKendoKanban_Draw",),
0x80B66A20:("ObjHariko_Init",),