From 6ed017b3620618b848ae6296eab4424928b0f4fc Mon Sep 17 00:00:00 2001
From: Archez <Archez@users.noreply.github.com>
Date: Wed, 15 May 2024 07:52:47 -0400
Subject: [PATCH] prevent infinite loop in save migration (#396)

---
 mm/2s2h/SaveManager/SaveManager.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/mm/2s2h/SaveManager/SaveManager.cpp b/mm/2s2h/SaveManager/SaveManager.cpp
index 2e427c2fd..285291cb9 100644
--- a/mm/2s2h/SaveManager/SaveManager.cpp
+++ b/mm/2s2h/SaveManager/SaveManager.cpp
@@ -56,7 +56,9 @@ const std::unordered_map<uint32_t, std::function<void(nlohmann::json&)>> migrati
 
 void SaveManager_MigrateSave(nlohmann::json& j) {
     int version = j.value("version", 0);
-    while (version != CURRENT_SAVE_VERSION) {
+
+    // BENTODO: what should we do if the version number is greater?
+    while (version < CURRENT_SAVE_VERSION) {
         if (migrations.contains(version)) {
             auto migration = migrations.at(version);
             migration(j);
@@ -241,4 +243,4 @@ extern "C" s32 SaveManager_SysFlashrom_ReadData(void* saveBuffer, u32 pageNum, u
             return 0;
         }
     }
-}
\ No newline at end of file
+}