From c63d7adcedd4ebaa26fc5c4395fb8f02a916b5d5 Mon Sep 17 00:00:00 2001 From: Alejandro Javier Asenjo Nitti Date: Thu, 9 Nov 2023 22:38:07 -0300 Subject: [PATCH 1/4] warning --- include/rand.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rand.h b/include/rand.h index 01e6efe2e..ad13e22a4 100644 --- a/include/rand.h +++ b/include/rand.h @@ -20,4 +20,4 @@ f32 Rand_Centered_Variable(u32* rndNum); extern u32 gRandFloat; -#endif \ No newline at end of file +#endif From 0c0622dd8a99e19873f0056dad8e8b43a9137a23 Mon Sep 17 00:00:00 2001 From: Alejandro Javier Asenjo Nitti Date: Thu, 9 Nov 2023 23:10:27 -0300 Subject: [PATCH 2/4] ovl_En_Wdhand_reloc --- spec | 4 ---- 1 file changed, 4 deletions(-) diff --git a/spec b/spec index 4dadcdcad..10869f4ef 100644 --- a/spec +++ b/spec @@ -3389,11 +3389,7 @@ beginseg name "ovl_En_Wdhand" compress include "build/src/overlays/actors/ovl_En_Wdhand/z_en_wdhand.o" - #ifdef NON_MATCHING include "build/src/overlays/actors/ovl_En_Wdhand/ovl_En_Wdhand_reloc.o" - #else - include "build/data/ovl_En_Wdhand/ovl_En_Wdhand.reloc.o" - #endif endseg beginseg From f182586aac3d47642b3e0f2b8102e00286e37343 Mon Sep 17 00:00:00 2001 From: Alejandro Javier Asenjo Nitti Date: Thu, 9 Nov 2023 23:47:44 -0300 Subject: [PATCH 3/4] correct typos in z_collision_check.c --- src/code/z_collision_check.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/code/z_collision_check.c b/src/code/z_collision_check.c index 753f24bb5..0f91ef007 100644 --- a/src/code/z_collision_check.c +++ b/src/code/z_collision_check.c @@ -1398,8 +1398,8 @@ void CollisionCheck_BlueBlood(PlayState* play, Collider* collider, Vec3f* v) { s32 effectIndex; D_801EEC00.position.x = v->x; - D_801EEC00.position.x = v->y; - D_801EEC00.position.x = v->z; + D_801EEC00.position.y = v->y; + D_801EEC00.position.z = v->z; D_801EEC00.uDiv = 5; D_801EEC00.vDiv = 5; D_801EEC00.colorStart[0].r = 10; @@ -1456,8 +1456,8 @@ void CollisionCheck_GreenBlood(PlayState* play, Collider* collider, Vec3f* v) { s32 effectIndex; D_801EF0C8.position.x = v->x; - D_801EF0C8.position.x = v->y; - D_801EF0C8.position.x = v->z; + D_801EF0C8.position.y = v->y; + D_801EF0C8.position.z = v->z; D_801EF0C8.uDiv = 5; D_801EF0C8.vDiv = 5; D_801EF0C8.colorStart[0].r = 10; @@ -3729,8 +3729,8 @@ void CollisionCheck_SpawnRedBlood(PlayState* play, Vec3f* v) { s32 effectIndex; D_801EE200.position.x = v->x; - D_801EE200.position.x = v->y; - D_801EE200.position.x = v->z; + D_801EE200.position.y = v->y; + D_801EE200.position.z = v->z; D_801EE200.uDiv = 5; D_801EE200.vDiv = 5; D_801EE200.colorStart[0].r = 128; @@ -3787,8 +3787,8 @@ void CollisionCheck_SpawnWaterDroplets(PlayState* play, Vec3f* v) { s32 effectIndex; D_801EE738.position.x = v->x; - D_801EE738.position.x = v->y; - D_801EE738.position.x = v->z; + D_801EE738.position.y = v->y; + D_801EE738.position.z = v->z; D_801EE738.uDiv = 5; D_801EE738.vDiv = 5; D_801EE738.colorStart[0].r = 255; From 34af7b3dc5ca7f394c93a8e55e2e1727338f656c Mon Sep 17 00:00:00 2001 From: Alejandro Javier Asenjo Nitti Date: Fri, 10 Nov 2023 00:11:43 -0300 Subject: [PATCH 4/4] Fix most hardcoded pointers in extracted assets --- assets/xml/objects/gameplay_field_keep.xml | 7 ++++- assets/xml/objects/gameplay_keep.xml | 31 +++++++++++++++------ assets/xml/objects/object_hana.xml | 1 + assets/xml/objects/object_moonend.xml | 11 +++++--- assets/xml/objects/object_ssh.xml | 1 - assets/xml/objects/object_syokudai.xml | 1 + assets/xml/objects/object_syoten.xml | 9 ++++-- assets/xml/objects/object_wood02.xml | 1 + assets/xml/objects/object_zog.xml | 2 +- assets/xml/overlays/ovl_Obj_Grass.xml | 1 + assets/xml/overlays/ovl_Obj_Jgame_Light.xml | 7 ++--- 11 files changed, 50 insertions(+), 22 deletions(-) diff --git a/assets/xml/objects/gameplay_field_keep.xml b/assets/xml/objects/gameplay_field_keep.xml index 32427cfe8..cc9d04e70 100644 --- a/assets/xml/objects/gameplay_field_keep.xml +++ b/assets/xml/objects/gameplay_field_keep.xml @@ -40,13 +40,18 @@ + + + + + - + diff --git a/assets/xml/objects/gameplay_keep.xml b/assets/xml/objects/gameplay_keep.xml index b51f0afb6..785fa3e1d 100644 --- a/assets/xml/objects/gameplay_keep.xml +++ b/assets/xml/objects/gameplay_keep.xml @@ -880,7 +880,7 @@ - + @@ -971,7 +971,8 @@ - + + @@ -1029,7 +1030,7 @@ - + @@ -1050,8 +1051,13 @@ + + + + + @@ -1290,7 +1296,7 @@ - + @@ -1306,7 +1312,7 @@ - + @@ -1327,8 +1333,10 @@ + - + + @@ -1418,6 +1426,11 @@ + + + + + @@ -1435,8 +1448,10 @@ + - + + @@ -1468,7 +1483,7 @@ - + diff --git a/assets/xml/objects/object_hana.xml b/assets/xml/objects/object_hana.xml index 872bdc806..79593345a 100644 --- a/assets/xml/objects/object_hana.xml +++ b/assets/xml/objects/object_hana.xml @@ -1,4 +1,5 @@  + diff --git a/assets/xml/objects/object_moonend.xml b/assets/xml/objects/object_moonend.xml index 4e4b5a6f2..c23659dce 100644 --- a/assets/xml/objects/object_moonend.xml +++ b/assets/xml/objects/object_moonend.xml @@ -1,7 +1,8 @@  - - + + + @@ -20,8 +21,10 @@ - - + + + + diff --git a/assets/xml/objects/object_ssh.xml b/assets/xml/objects/object_ssh.xml index 29cd1fab1..5e6893077 100644 --- a/assets/xml/objects/object_ssh.xml +++ b/assets/xml/objects/object_ssh.xml @@ -15,7 +15,6 @@ - diff --git a/assets/xml/objects/object_syokudai.xml b/assets/xml/objects/object_syokudai.xml index 01ab0ef90..84b9c8bca 100644 --- a/assets/xml/objects/object_syokudai.xml +++ b/assets/xml/objects/object_syokudai.xml @@ -1,4 +1,5 @@  + diff --git a/assets/xml/objects/object_syoten.xml b/assets/xml/objects/object_syoten.xml index 2e546f471..95563b989 100644 --- a/assets/xml/objects/object_syoten.xml +++ b/assets/xml/objects/object_syoten.xml @@ -1,7 +1,8 @@  - - + + + @@ -13,8 +14,10 @@ + - + + diff --git a/assets/xml/objects/object_wood02.xml b/assets/xml/objects/object_wood02.xml index 6ef693f34..6265ebf04 100644 --- a/assets/xml/objects/object_wood02.xml +++ b/assets/xml/objects/object_wood02.xml @@ -1,4 +1,5 @@  + diff --git a/assets/xml/objects/object_zog.xml b/assets/xml/objects/object_zog.xml index b6d9d26ed..c6bc9eed7 100644 --- a/assets/xml/objects/object_zog.xml +++ b/assets/xml/objects/object_zog.xml @@ -79,7 +79,7 @@ - + diff --git a/assets/xml/overlays/ovl_Obj_Grass.xml b/assets/xml/overlays/ovl_Obj_Grass.xml index e1002b369..5c8d55e4a 100644 --- a/assets/xml/overlays/ovl_Obj_Grass.xml +++ b/assets/xml/overlays/ovl_Obj_Grass.xml @@ -1,4 +1,5 @@ + diff --git a/assets/xml/overlays/ovl_Obj_Jgame_Light.xml b/assets/xml/overlays/ovl_Obj_Jgame_Light.xml index e6b740aca..d1f182271 100644 --- a/assets/xml/overlays/ovl_Obj_Jgame_Light.xml +++ b/assets/xml/overlays/ovl_Obj_Jgame_Light.xml @@ -1,12 +1,11 @@ - - + - + + -