encounter/objdiff
0
0
Fork 0
mirror of https://github.com/encounter/objdiff.git synced 2026-07-10 12:18:36 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix several issues with string literal detection (#351)

Browse Source 
* Support detecting more symbol names for strings

* Fix string detectiong being broken for encodings that use null terminators

* Add test cases for string detection and decoding

* Fix test helper function sometimes being considered dead code

* Clippy fixes
This commit is contained in:
LagoLunatic
2026-05-03 21:27:12 -04:00
committed by GitHub
parent 3cebee6766
commit 13f1267eac
7 changed files with 139 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
objdiff-wasm/src/api.rs
+2 -2
View File
@@ -225,7 +225,7 @@ impl GuestDisplay for Component {
let obj_diff = diff.get::<ResourceObjectDiff>();
let obj = obj_diff.0.as_ref();
let symbol_display = from_symbol_ref(symbol_ref);
diff::display::symbol_context(obj, symbol_display.symbol as usize)
diff::display::symbol_context(obj, symbol_display.symbol)
.into_iter()
.map(ContextItem::from)
.collect()
@@ -237,7 +237,7 @@ impl GuestDisplay for Component {
let addend = 0; // TODO
let override_color = None; // TODO: colorize replaced/deleted/inserted relocations
let symbol_display = from_symbol_ref(symbol_ref);
diff::display::symbol_hover(obj, symbol_display.symbol as usize, addend, override_color)
diff::display::symbol_hover(obj, symbol_display.symbol, addend, override_color)
.into_iter()
.map(HoverItem::from)
.collect()