encounter/llvm-project
0
0
Fork 0
mirror of https://github.com/encounter/llvm-project.git synced 2026-03-30 11:27:19 -07:00
Code Issues Packages Projects Releases Wiki Activity
259,217 Commits 42 Branches 155 Tags
08eb343cce893e2594de62f1ab976ed03536cb56
Commit Graph

276 Commits

Author SHA1 Message Date
Craig Topper 00b47eec0f [APInt] Make use of whichWord and maskBit to simplify some code. NFC 
llvm-svn: 299342
 2017-04-02 19:35:18 +00:00
Craig Topper 55229b780d [APInt] Add a public typedef for the internal type of APInt use it instead of integerPart. Make APINT_BITS_PER_WORD and APINT_WORD_SIZE public. 
This patch is one step to attempt to unify the main APInt interface and the tc functions used by APFloat.

This patch adds a WordType to APInt and uses that in all the tc functions. I've added temporary typedefs to APFloat to alias it to integerPart to keep the patch size down. I'll work on removing that in a future patch.

In future patches I hope to reuse the tc functions to implement some of the main APInt functionality.

I may remove APINT_ from BITS_PER_WORD and WORD_SIZE constants so that we don't have the repetitive APInt::APINT_ externally.

Differential Revision: https://reviews.llvm.org/D31523

llvm-svn: 299341
 2017-04-02 19:17:22 +00:00
Craig Topper 15e484aa2b [X86] Use tcAdd/tcSubtract to implement the slow case of operator+=/operator-=. 
llvm-svn: 299326
 2017-04-02 06:59:43 +00:00
Craig Topper b8f1068765 [APInt] Combine declaration and initialization. NFC 
llvm-svn: 299325
 2017-04-02 06:59:41 +00:00
Craig Topper b7d8faa231 [APInt] Simplify some code by using operator+=(uint64_t) instead of doing a more complex assignment into a temporary APInt just to use the APInt operator+=. 
llvm-svn: 299324
 2017-04-02 06:59:38 +00:00
Craig Topper d7ed50de26 [APInt] Fix typo in comment. NFC 
llvm-svn: 299323
 2017-04-02 06:59:36 +00:00
Craig Topper 68a3ed2e1b [APInt] Use conditional operator to simplify some code. NFC 
llvm-svn: 299320
 2017-04-01 21:50:10 +00:00
Craig Topper a742cb5fc8 [APInt] Implement flipAllBitsSlowCase with tcComplement. NFCI 
llvm-svn: 299319
 2017-04-01 21:50:08 +00:00
Craig Topper 99cfe4f99d [APInt] Fix indentation. NFC 
llvm-svn: 299318
 2017-04-01 21:50:06 +00:00
Craig Topper b2aaa5da42 [APInt] Implement AndAssignSlowCase using tcAnd. Do the same for Or and Xor. NFCI 
llvm-svn: 299317
 2017-04-01 21:50:03 +00:00
Craig Topper 278ebd2f98 [APInt] Allow GreatestCommonDivisor to take rvalue inputs efficiently. Use moves instead of copies in the loop. 
Summary:
GreatestComonDivisor currently makes a copy of both its inputs. Then in the loop we do one move and two copies, plus any allocation the urem call does.

This patch changes it to take its inputs by value so that we can do a move of any rvalue inputs instead of copying. Then in the loop we do 3 move assignments and no copies. This way the only possible allocations we have in the loop is from the urem call.

Reviewers: dblaikie, RKSimon, hans

Reviewed By: dblaikie

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D31572

llvm-svn: 299314
 2017-04-01 20:30:57 +00:00
Craig Topper 9ab8d7f9c3 [APInt] Remove the mul/urem/srem/udiv/sdiv functions from the APIntOps namespace. Replace the few usages with calls to the class methods. NFC 
llvm-svn: 299292
 2017-04-01 05:08:57 +00:00
Craig Topper e7e3560288 [APInt] Rewrite getLoBits in a way that will do one less memory allocation in the multiword case. Rewrite getHiBits to use the class method version of lshr instead of the one in APIntOps. NFCI 
llvm-svn: 299243
 2017-03-31 18:48:14 +00:00
Craig Topper 6a8518086a [APInt] Reformat tc functions to put opening curly braces on the end of the previous line. NFC 
llvm-svn: 298900
 2017-03-28 05:32:55 +00:00
Craig Topper 76f4246fac [APInt] Remove an anonymous namespace around static functions. NFC 
llvm-svn: 298899
 2017-03-28 05:32:53 +00:00
Craig Topper b003816be7 [APInt] Combine variable declaration and initialization where possible in the tc functions. NFCI 
llvm-svn: 298898
 2017-03-28 05:32:52 +00:00
Craig Topper 592b134aa1 [APInt] Use 'unsigned' instead of 'unsigned int' in the interface to the APInt tc functions. This is more consistent with the rest of the codebase. NFC 
llvm-svn: 298897
 2017-03-28 05:32:48 +00:00
Craig Topper f496f9a273 [APInt] Move the single word cases of the bitwise operators inline. 
llvm-svn: 298894
 2017-03-28 04:00:47 +00:00
Craig Topper 6ebeb7041e [APInt] Move operator=(uint64_t) inline as its pretty simple and is often used with small constants that the compiler can optimize. 
While there recognize that we only need to clearUnusedBits on the single word case.

llvm-svn: 298881
 2017-03-27 20:07:31 +00:00
Craig Topper 70d8ca9276 [APInt] Move operator&=(uint64_t) inline and use memset to clear the upper words. 
This method is pretty new and probably isn't use much in the code base so this should have a negligible size impact. The OR and XOR operators are already inline.

llvm-svn: 298870
 2017-03-27 18:16:17 +00:00
Craig Topper afc9e35343 [APInt] Move the >64 bit case for flipAllBits out of line. 
This is more consistent with what we do for other operations. This shrinks the opt binary on my build by ~72k.

llvm-svn: 298858
 2017-03-27 17:10:21 +00:00
Craig Topper 0085ffb940 [APInt] Don't initialize VAL to 0 in APInt constructors. Push it down to the initSlowCase and other init methods. 
I'm not sure if zeroing VAL before writing pVal is really necessary, but at least one other place did it in code.

But by taking the store out of line, this reduces the opt binary by about 20k on my local x86-64 build.

llvm-svn: 298233
 2017-03-20 01:29:52 +00:00
Simon Pilgrim b02667c469 [APInt] Add APInt::insertBits() method to insert an APInt into a larger APInt 
We currently have to insert bits via a temporary variable of the same size as the target with various shift/mask stages, resulting in further temporary variables, all of which require the allocation of memory for large APInts (MaskSizeInBits > 64).

This is another of the compile time issues identified in PR32037 (see also D30265).

This patch adds the APInt::insertBits() helper method which avoids the temporary memory allocation and masks/inserts the raw bits directly into the target.

Differential Revision: https://reviews.llvm.org/D30780

llvm-svn: 297458
 2017-03-10 13:44:32 +00:00
Simon Pilgrim 0099beb51f Fixed typos in comments. NFCI. 
llvm-svn: 297379
 2017-03-09 13:57:04 +00:00
Craig Topper b60a46fea1 [APInt] Add rvalue reference support to and, or, xor operations to allow their memory allocation to be reused when possible 
This extends an earlier change that did similar for add and sub operations.

With this first patch we lose the fastpath for the single word case as operator&= and friends don't support it. This can be added there if we think that's important.

I had to change some functions in the APInt class since the operator overloads were moved out of the class and can't be used inside the class now. The getBitsSet change collides with another outstanding patch to implement it with setBits. But I didn't want to make this patch dependent on that series.

I've also removed the Or, And, Xor functions which were rarely or never used. I already commited two changes to remove the only uses of Or that existed.

Differential Revision: https://reviews.llvm.org/D30612

llvm-svn: 297121
 2017-03-07 05:36:19 +00:00