mirror of
https://github.com/encounter/ghidra-cli.git
synced 2026-07-10 03:18:56 -07:00
Alexander KiselevandClaude Opus 4.6
b72ddd1894
The comment tests used hardcoded addresses (0x118910, 0x118920, etc.) that assumed a specific binary layout. These addresses don't have code units on CI-compiled binaries, causing "No code unit at address" errors. Now uses get_function_address/get_function_addresses helpers to dynamically resolve valid addresses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
139 lines
3.3 KiB
Rust
139 lines
3.3 KiB
Rust
//! Tests for comment operations.
|
|
|
|
use assert_cmd::Command;
|
|
use predicates::prelude::*;
|
|
use serial_test::serial;
|
|
|
|
#[macro_use]
|
|
mod common;
|
|
use common::{
|
|
ensure_test_project, get_function_address, get_function_addresses, DaemonTestHarness,
|
|
};
|
|
|
|
const TEST_PROJECT: &str = "comment-test";
|
|
const TEST_PROGRAM: &str = "sample_binary";
|
|
|
|
#[test]
|
|
#[serial]
|
|
fn test_comment_set_and_get() {
|
|
require_ghidra!();
|
|
ensure_test_project(TEST_PROJECT, TEST_PROGRAM);
|
|
|
|
let harness =
|
|
DaemonTestHarness::new(TEST_PROJECT, TEST_PROGRAM).expect("Failed to start daemon");
|
|
|
|
// Dynamically resolve an address with a code unit
|
|
let addr = get_function_address(&harness, TEST_PROJECT, TEST_PROGRAM, "main");
|
|
|
|
Command::cargo_bin("ghidra")
|
|
.unwrap()
|
|
.arg("comment")
|
|
.arg("set")
|
|
.arg(&addr)
|
|
.arg("test comment from integration test")
|
|
.arg("--project")
|
|
.arg(TEST_PROJECT)
|
|
.arg("--program")
|
|
.arg(TEST_PROGRAM)
|
|
.assert()
|
|
.success();
|
|
|
|
// Get the comment back
|
|
Command::cargo_bin("ghidra")
|
|
.unwrap()
|
|
.arg("comment")
|
|
.arg("get")
|
|
.arg(&addr)
|
|
.arg("--project")
|
|
.arg(TEST_PROJECT)
|
|
.arg("--program")
|
|
.arg(TEST_PROGRAM)
|
|
.assert()
|
|
.success()
|
|
.stdout(predicate::str::contains("test comment"));
|
|
|
|
drop(harness);
|
|
}
|
|
|
|
#[test]
|
|
#[serial]
|
|
fn test_comment_list() {
|
|
require_ghidra!();
|
|
ensure_test_project(TEST_PROJECT, TEST_PROGRAM);
|
|
|
|
let harness =
|
|
DaemonTestHarness::new(TEST_PROJECT, TEST_PROGRAM).expect("Failed to start daemon");
|
|
|
|
// Use a dynamically resolved function address
|
|
let addrs = get_function_addresses(&harness, TEST_PROJECT, TEST_PROGRAM, 2);
|
|
let addr = &addrs[0];
|
|
|
|
Command::cargo_bin("ghidra")
|
|
.unwrap()
|
|
.arg("comment")
|
|
.arg("set")
|
|
.arg(addr)
|
|
.arg("another comment")
|
|
.arg("--project")
|
|
.arg(TEST_PROJECT)
|
|
.arg("--program")
|
|
.arg(TEST_PROGRAM)
|
|
.assert()
|
|
.success();
|
|
|
|
Command::cargo_bin("ghidra")
|
|
.unwrap()
|
|
.arg("comment")
|
|
.arg("list")
|
|
.arg("--project")
|
|
.arg(TEST_PROJECT)
|
|
.arg("--program")
|
|
.arg(TEST_PROGRAM)
|
|
.assert()
|
|
.success()
|
|
.stdout(predicate::str::contains("comments"));
|
|
|
|
drop(harness);
|
|
}
|
|
|
|
#[test]
|
|
#[serial]
|
|
fn test_comment_delete() {
|
|
require_ghidra!();
|
|
ensure_test_project(TEST_PROJECT, TEST_PROGRAM);
|
|
|
|
let harness =
|
|
DaemonTestHarness::new(TEST_PROJECT, TEST_PROGRAM).expect("Failed to start daemon");
|
|
|
|
// Use a dynamically resolved function address
|
|
let addrs = get_function_addresses(&harness, TEST_PROJECT, TEST_PROGRAM, 3);
|
|
let addr = &addrs[addrs.len() - 1];
|
|
|
|
Command::cargo_bin("ghidra")
|
|
.unwrap()
|
|
.arg("comment")
|
|
.arg("set")
|
|
.arg(addr)
|
|
.arg("to be deleted")
|
|
.arg("--project")
|
|
.arg(TEST_PROJECT)
|
|
.arg("--program")
|
|
.arg(TEST_PROGRAM)
|
|
.assert()
|
|
.success();
|
|
|
|
Command::cargo_bin("ghidra")
|
|
.unwrap()
|
|
.arg("comment")
|
|
.arg("delete")
|
|
.arg(addr)
|
|
.arg("--project")
|
|
.arg(TEST_PROJECT)
|
|
.arg("--program")
|
|
.arg(TEST_PROGRAM)
|
|
.assert()
|
|
.success();
|
|
|
|
drop(harness);
|
|
}
|