- Fix rustfmt issue in tests/common/mod.rs (single-line .context() chain)
- Remove stale drop(harness) calls that now drop &'static references
- Use _harness for unused bindings that only ensure bridge initialization
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Root cause: on macOS, `ghidra stop` triggers Ghidra's project close
which truncates .gpr to 0 bytes and leaves .rep with only metadata
stubs (~index.dat, project.prp) but no actual program data. This
causes all subsequent bridge starts to fail with "program file(s)
not found".
Changes:
- Remove `ghidra stop` from CI setup (corrupts macOS projects)
- Remove Step 3 bridge stop from ensure_test_project (same issue)
- Validate .gpr is non-empty AND idata/ has program data beyond
just ~index.dat stubs
- Clean up stale project files before re-import
- Bump cache keys v3→v4 to invalidate broken caches
- Remove diagnostic output from test.yml
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The ghidra-setup job left the bridge running after import+analyze,
so the Ghidra JVM hadn't flushed the project database to the .rep
directory when the post-job cache save ran. This resulted in caches
containing only the ~1KB .gpr file without any analysis data.
- Stop bridge after import+analyze in ghidra-setup (both workflows)
- Bump cache keys v2→v3 to invalidate broken empty caches
- Validate .rep has actual files, not just an empty directory
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The `ghidra restart` call in test_daemon_restart and the `ghidra import`/
`ghidra analyze` calls in project_tests also spawn JVM processes via
analyzeHeadless. Using assert_cmd's .output()/.assert() creates piped
stdout/stderr, and the grandchild JVM inherits these handles on Windows,
blocking forever.
Replace all JVM-spawning commands in tests with run_cli_with_timeout()
which uses Stdio::null(). Make the helper public so it can be used from
daemon_tests and project_tests.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
On Windows, assert_cmd::output() creates piped stdout/stderr for the ghidra
CLI subprocess. When the CLI spawns analyzeHeadless.bat (which spawns
java.exe), the grandchild JVM inherits these pipe handles. Even after
ghidra.exe exits, the pipes remain open because the JVM holds inherited
handles, causing wait_with_output() to block indefinitely.
Replace piped I/O with Stdio::null() in ensure_test_project() and
DaemonTestHarness::new(). Add run_cli_with_timeout() helper that uses
spawn() + try_wait() polling with manual timeout instead of output().
Also fix rustfmt issues in bridge.rs.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add eprintln between import and analyze steps in ensure_test_project()
to identify exactly which step hangs on Windows CI.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace naive 2s sleep in DaemonTestHarness::drop() with proper bridge
cleanup: stop_bridge() + poll is_pid_alive() to wait for JVM exit
- Add TCP connect timeouts (10s client, 5s bridge checks) to prevent
indefinite blocking on partially-alive bridges
- Add /T flag to Windows taskkill to kill entire process tree
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Making import/analyze failures fatal caused widespread test failures.
Revert to warning-only behavior but keep the .rep directory check
for cache validation (detects incomplete cached projects).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- ensure_test_project checks both .gpr and .rep directory (not just
.gpr) to detect incomplete projects from failed imports
- Clean up partial project state before re-importing
- Make import and analyze failures fatal (panic) instead of silently
continuing with a broken project
- Use per-job cache keys (github.job) so parallel CI jobs don't
overwrite each other's project caches
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The comment tests used hardcoded addresses (0x118910, 0x118920, etc.)
that assumed a specific binary layout. These addresses don't have code
units on CI-compiled binaries, causing "No code unit at address" errors.
Now uses get_function_address/get_function_addresses helpers to
dynamically resolve valid addresses.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test harness used dirs::data_local_dir() (~/.local/share) to compute
the project path, but the CLI defaults to dirs::cache_dir() (~/.cache).
This caused different MD5 hashes for port file lookup, so the test harness
could never find the port file written by the bridge.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Refactor disassembly tests to dynamically resolve addresses and validate instruction schemas.
- Introduce error handling tests for invalid inputs in disassembly.
- Improve patching tests by validating output structure and ensuring graceful failure on invalid inputs.
- Add snapshot tests for output format regression detection in patching and querying commands.
- Update function list and memory map tests to validate JSON output against typed schemas.
- Ensure all tests utilize dynamic address resolution instead of hardcoded values for robustness.
- Implemented `install_pyghidra` function to set up PyGhidra in a Python virtual environment for Ghidra installations.
- Enhanced `install_ghidra` to call `install_pyghidra` after Ghidra installation.
- Updated daemon command handling to include program name in start, restart, and stop commands.
- Refactored project path resolution to streamline project management.
- Improved socket path handling to respect `GHIDRA_CLI_SOCKET` environment variable for testing.
- Modified tests to remove ignore flags, allowing for automated testing without Ghidra installation.
- Added analysis step in test project setup to ensure comments and other features work correctly.
Add E2E test infrastructure:
- DaemonTestHarness for managing daemon lifecycle in tests
- Test fixtures and helpers in tests/common/
- Sample binary fixture for integration tests
Add test coverage:
- command_tests.rs: version, doctor, config commands
- project_tests.rs: project create/list/info/delete, import, analyze
- daemon_tests.rs: daemon start/status/ping/stop/clear-cache
- query_tests.rs: function list, strings, memory, decompile, xref
- unimplemented_tests.rs: 39 tests for graceful error messages
Fix CLI bugs:
- DisasmArgs: rename count to num_instructions (--instructions/-n)
to avoid conflict with QueryOptions.count
- GraphExportArgs: add unique arg id for format positional to avoid
conflict with QueryOptions.format
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
