53 Commits

Author SHA1 Message Date
Alexandre Ardhuin 0a66d8a7a4 implicit-casts:false in fuchsia_remote_debug_protocol (#45239) 2019-11-22 20:33:47 +01:00
Greg Spencer a60bf8e23a Spell check of Flutter docs (#45200)
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00
Alexandre Ardhuin df4bf453ab more UI-as-code (#35516) 2019-09-17 16:23:44 +02:00
Alexandre Ardhuin 758009ba70 more ui-as-code (#35393)
* more ui-as-code

* address review comments
2019-07-02 21:11:56 +02:00
Dan Field 6d4b0abfa8 Ignore some JSON RPC errors (#32710) 2019-05-14 16:04:04 -07:00
Dan Field a8504405a8 Revert "Handle notification errors (#31868)" (#31886)
This reverts commit c0d5fd23ab.
2019-04-30 23:27:30 -07:00
Dan Field c0d5fd23ab Handle notification errors (#31868) 2019-04-30 15:42:22 -07:00
Dan Field 1db5d66932 Capture JSON RPC errors that presently get swallowed (#31584)
* Update packages
* Capture JSON RPC errors that presently get swallowed
2019-04-25 08:27:00 -07:00
Zachary Anderson 39ebae2bab [fuchsia] Fix isolate filter (#30458) 2019-04-03 21:14:37 -07:00
Alexandre Ardhuin 440ce8fde6 Fix indentations of statements in BlockFunctionBody (#28933)
* fix indentof statements in BlockFunctionBody

* fix indentof statements in BlockFunctionBody in tests
2019-03-07 21:09:28 +01:00
Phil Quitslund 802eca29d2 set literal conversions (#27811) 2019-03-06 11:05:16 -08:00
Zachary Anderson ea4cffde60 [fuchsia] Fix paths to find and ls (#28280) 2019-02-22 08:38:02 -08:00
Alexandre Ardhuin 5169ab5974 format parameter list (#27261) 2019-02-21 09:27:07 +01:00
Alexandre Ardhuin ef276ffea5 format initializer list of constructors (#27111) 2019-01-29 21:47:16 +01:00
Andrew Davies 33cd720db6 [frdp] Adds paths for find and ls for Fuchsia execution. (#26680)
Adds full path for `find` and `ls` commands.
2019-01-22 10:49:17 -08:00
Zachary Anderson b18a2b1794 [fuchsia] Get Dart VM service ports from The Hub (#25332) 2018-12-17 11:10:47 -08:00
Andrew Davies b722a744e6 [frdp] Add includeNonFlutterIsolates flag. (#23693)
Previously there was no way to add this flag when searching for
Isolates.
2018-10-29 16:18:30 -07:00
Andrew Davies 1531ef60ec [frdp] Add configurable timeouts for VM. (#22893)
This adds configurable timeouts for the Dart VM. Due to some testing
machines running things quite slowly, this is becoming more necessary.
2018-10-10 16:11:01 -07:00
Andrew Davies 9ceb9ab305 [flutter_driver] Adds fuchsia compat for connect() (#22633)
Adds a Fuchsia compatibility function that allows for connecting to a
specific Isolate by name when running Flutter Driver on a Fuchsia
device.  This will check over multiple Dart VM's in an attempt to find
an Isolate by its name.
2018-10-08 11:09:07 -07:00
Andrew Davies 39daab2900 [frdp] Add optional dart isolate filter. (#22590)
* [frdp] Add optional dart isolate filter.

It's now default to filter out non-flutter isolates when searching
across Dart VM's.  This is due to a possible issue wherein an Isolate
for testing might have the same name as the flutter Isolate.

In addition, logging messages have been added in dart_vm.dart for
debugging.
2018-10-05 12:31:05 -07:00
Alexandre Ardhuin c26b56cba3 apply lint prefer_void_to_null in packages/fuchsia_remote_debug_protocol (#22690) 2018-10-05 06:48:20 +02:00
Alexandre Ardhuin 5de96bb734 unnecessary this in field initializers (#22522) 2018-10-02 17:14:59 +02:00
Alexandre Ardhuin f62afdcf57 add missing type parameter on methods (#22096) 2018-10-01 21:29:08 +02:00
Andrew Davies 1c2f478e9e [frdp][connection] Exception checks in _getDartVm (#22386)
Through some integration testing checks, it looks like it's possible
that connecting to a new instance of the Dart VM may fail even after the
Dart VM instance has been discovered.

This means that _getDartVm should be checked in more than just one
place.  This changes the function to return a null value in the event of
a 'well-known' exception (`HttpException` or `TimeoutException`
specifically).

As a result, code now calling _getDartVm checks for null and handles it
as appropriate, and the DartVm RPC calls are all updated with
consistent timeout params.
2018-09-28 11:40:36 -07:00
Andrew Davies 491c4e2138 [frdp] Removes regex check for Isolate search. (#22100)
This will now make it so that the Dart VM class returns any Isolate that
matches the passed Pattern, without checking for any specific strings
like "main()"

This causes the search to skip over Isolates that would have matched.
2018-09-24 15:30:49 -07:00