699 Commits

Author SHA1 Message Date
Sam Rawlins 5005824763 Mark unused but desired private constructors as such (#46200) 2020-01-07 12:03:03 -08:00
Alexandre Ardhuin 4f9b6cf017 enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Francisco Magdaleno a46d1791fc Reland "Revert "Add visual density to the gallery options (#46090)"... (#47702)" (#48094)
This reverts commit e46671f323.
2020-01-02 15:50:59 -08:00
Dan Field 24f39d40a4 Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#48081)
This reverts commit 04ea3183ce.
2020-01-02 11:47:28 -08:00
Francisco Magdaleno 04ea3183ce Revert "Add many more global analyses. (#47875)" (#48080)
This reverts commit e768c92fbc.
2020-01-02 09:25:59 -08:00
Ian Hickson e768c92fbc Add many more global analyses. (#47875)
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
2019-12-30 17:12:19 -08:00
Francisco Magdaleno e46671f323 Revert "Add visual density to the gallery options (#46090)"... (#47702)
* Revert "Add visual density to the gallery options (#46090)"

This reverts commit 924efae96c.

* Revert "fix analysis (#47594)"

This reverts commit 49c7845907.
2019-12-23 15:42:53 -08:00
Alexandre Ardhuin 49c7845907 fix analysis (#47594) 2019-12-21 20:53:14 +01:00
Greg Spencer 924efae96c Add visual density to the gallery options (#46090)
This PR adds an option to the gallery options that sets the visual density to one of "standard" (the default), "comfortable", or "compact".
2019-12-20 20:36:29 -08:00
Jonah Williams 5ba2830c83 [flutter_tool][gallery] Standardize target platform override behavior in tool and update flutter gallery to support it (#46206) 2019-12-12 15:20:52 -08:00
Alexandre Ardhuin ec0842e0d3 implicit-casts:false in examples (#45805) 2019-12-05 21:33:07 +01:00
Kate Lovett 2a5e528a18 Fixing SliverOverlapAbsorber & SliverOverlapInjector child property (#44283) 2019-12-02 17:08:02 -08:00
Ian Hickson a78fb87dfe Relicense Shrine demo to match rest of repository (#45718)
* Relicense Shrine demo to match rest of repository

The Shrine demo was Apache-licensed. The code was mostly
Google-written, with contributions from:

 - Michelle Dudley (@michdud)

 - Abhijeeth Padarthi <rkinabhi@gmail.com> (@rkinabhi)

 - @a14n

I contacted all three, and they confirmed their approval for this
change, as described below.

Abhijeeth Padarthi said by e-mail on Thu, Nov 21, 2019 at 5:48 PM:

> hi Ian,
>
> sure :)
>
> let me know if I need to do anything on my end..

Michelle Dudley wrote by e-mail on Sun, Nov 24, 2019 at 2:07 PM:

> Hi Ian,
>
> That would be ok with me.
>
> Thanks,
>
> Michelle

@a14n said on Discord's Flutter server in the #hackers channel at 10:44PM on Thursday, November 21, 2019:

> @Hixie no problem I agree with this relicensing

* Remove shrine loophole from license checker.
2019-11-27 16:25:56 -08:00
Ian Hickson 449f4a6673 License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Greg Spencer 245d1b51ce Add macOS to TargetPlatform (#43457)
This PR adds TargetPlatform.macOS to the TargetPlatform enum. This allows us to begin implementation of some adaptive UI based on which target platform is desired.

I haven't updated the tests here, that will come in a follow-up PR.
2019-11-26 18:32:34 -08:00
Alexandre Ardhuin fcb40a05bb make some BuildContext methods generics (#44189)
* make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic

* make BuildContext.inheritFromWidgetOfExactType generic

* make BuildContext.ancestorInheritedElementForWidgetOfExactType generic

* make BuildContext.ancestorWidgetOfExactType generic

* fix snippet

* bump scoped_model on temp version

* update names

* Revert "bump scoped_model on temp version"

This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0.

* address review comments

* fix ci

* address review comments

* repeat the deprecation notice

* fix uppercase

* use of recommanded deprecation syntax

* address review comment
2019-11-22 17:35:20 +01:00
Justin McCandless 299fbc422f Fix typo (#45125)
Typo in a title in a gallery demo
2019-11-20 17:05:01 -08:00
Todd Volkert 2c7af1e24e Revert "[Gallery] Add Material Study app Rally as an example app (#44907)" (#45279)
This reverts commit 399aebc4b7.

It contained Apache 2.0 licensed files, which aren't allowed in flutter/flutter
2019-11-20 12:18:44 -08:00
Todd Volkert ce8e2bb7cf Revert "[Material] Update the Slider and RangeSlider to the latest Material spec (#44351)" (#45268)
This reverts commit 421bf64703.

Was causing severe breakages in Google.
2019-11-20 10:42:23 -08:00
Jonah Williams 70dcbf4e55 Add minimum macOS application to Flutter Gallery (#45259) 2019-11-20 09:44:17 -08:00
Anthony 421bf64703 [Material] Update the Slider and RangeSlider to the latest Material spec (#44351)
Update the Slider and RangeSlider to the latest Material spec. This introduces an updated track, updated thumbs, updated tick marks, and a new value indicator shape. The old paddle value indicator shape is also updated so that text scaling works consistently.
2019-11-20 18:18:40 +01:00
Per Classon 399aebc4b7 [Gallery] Add Material Study app Rally as an example app (#44907)
Add Material Study app Rally as an example app
2019-11-19 12:12:56 +01:00
Ian Hickson 1ce4a4f36f Make sure all our .dart files have license headers (#44467) 2019-11-08 16:53:21 -08:00
liyuqian 2eb8caf13c Re-enable Pesto in profile/release mode (#44299)
See https://github.com/flutter/flutter/issues/9257#issuecomment-550503833
2019-11-07 14:05:56 -08:00
LongCatIsLooong 62db22d152 CupertinoDynamicColor improvements (#44317) 2019-11-07 13:14:08 -08:00