From 69728097bde14b1c989fd549eacaa886bc3d9cc5 Mon Sep 17 00:00:00 2001 From: liyuqian Date: Mon, 9 Dec 2019 15:18:02 -0800 Subject: [PATCH] Remove unused observer and raise the waiting time (#46626) --- .../macrobenchmarks/test_memory/large_images.dart | 11 ----------- .../bin/tasks/fast_scroll_large_images__memory.dart | 2 +- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/dev/benchmarks/macrobenchmarks/test_memory/large_images.dart b/dev/benchmarks/macrobenchmarks/test_memory/large_images.dart index 62c14d6b0..b017b1ed2 100644 --- a/dev/benchmarks/macrobenchmarks/test_memory/large_images.dart +++ b/dev/benchmarks/macrobenchmarks/test_memory/large_images.dart @@ -16,20 +16,9 @@ Future endOfAnimation() async { } while (SchedulerBinding.instance.hasScheduledFrame); } -int iteration = 0; - -class LifecycleObserver extends WidgetsBindingObserver { - @override - void didChangeAppLifecycleState(AppLifecycleState state) { - debugPrint('==== MEMORY BENCHMARK ==== $state ===='); - debugPrint('This was lifecycle event number $iteration in this instance'); - } -} - Future main() async { runApp(const MacrobenchmarksApp(initialRoute: kLargeImagesRouteName)); await endOfAnimation(); await Future.delayed(const Duration(milliseconds: 50)); debugPrint('==== MEMORY BENCHMARK ==== READY ===='); - WidgetsBinding.instance.addObserver(LifecycleObserver()); } diff --git a/dev/devicelab/bin/tasks/fast_scroll_large_images__memory.dart b/dev/devicelab/bin/tasks/fast_scroll_large_images__memory.dart index b07f163bd..b3e2c9eac 100644 --- a/dev/devicelab/bin/tasks/fast_scroll_large_images__memory.dart +++ b/dev/devicelab/bin/tasks/fast_scroll_large_images__memory.dart @@ -30,7 +30,7 @@ class FastScrollLargeImagesMemoryTest extends MemoryTest { await launchApp(); await recordStart(); await device.shellExec('input', ['swipe', '0 1500 0 0 50']); - await Future.delayed(const Duration(milliseconds: 10000)); + await Future.delayed(const Duration(milliseconds: 15000)); await recordEnd(); } }