mirror of
https://github.com/encounter/engine.git
synced 2026-03-30 11:09:55 -07:00
Kaushik Iska
632a37b5d5
The core underlying issue is that vector push_back could re-allocate and cause us to segfault. I have switched the backing queues to a map per @jason-simmons suggestion in flutter/flutter#38778. I've also added a test to capture the aforementioned bug. I've run internal tests several times to validate that this is fixed. General threading note for this class is that only the following operations take a write lock on the meta mutex: 1. Create 2. Dispose The rest of the operations take read lock on the meta mutex and acquire finer grained locks for the duration of the operation. We can not grab read lock for the entire duration of NotifyObservers for example because observer can in-turn create other queues -- Which we should not block. Additional changes: 1. Make as many methods as possible const. Unlocked methods are all const. 2. Migrate all the queue members to a struct, and have a map. 3. Get rid of the un-used Swap functionality.
76 lines
1.8 KiB
C++
76 lines
1.8 KiB
C++
// Copyright 2013 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef FLUTTER_FML_MESSAGE_LOOP_IMPL_H_
|
|
#define FLUTTER_FML_MESSAGE_LOOP_IMPL_H_
|
|
|
|
#include <atomic>
|
|
#include <deque>
|
|
#include <map>
|
|
#include <mutex>
|
|
#include <queue>
|
|
#include <utility>
|
|
|
|
#include "flutter/fml/closure.h"
|
|
#include "flutter/fml/delayed_task.h"
|
|
#include "flutter/fml/macros.h"
|
|
#include "flutter/fml/memory/ref_counted.h"
|
|
#include "flutter/fml/message_loop.h"
|
|
#include "flutter/fml/message_loop_task_queues.h"
|
|
#include "flutter/fml/synchronization/thread_annotations.h"
|
|
#include "flutter/fml/time/time_point.h"
|
|
#include "flutter/fml/wakeable.h"
|
|
|
|
namespace fml {
|
|
|
|
class MessageLoopImpl : public Wakeable,
|
|
public fml::RefCountedThreadSafe<MessageLoopImpl> {
|
|
public:
|
|
static fml::RefPtr<MessageLoopImpl> Create();
|
|
|
|
virtual ~MessageLoopImpl();
|
|
|
|
virtual void Run() = 0;
|
|
|
|
virtual void Terminate() = 0;
|
|
|
|
void PostTask(fml::closure task, fml::TimePoint target_time);
|
|
|
|
void AddTaskObserver(intptr_t key, fml::closure callback);
|
|
|
|
void RemoveTaskObserver(intptr_t key);
|
|
|
|
void DoRun();
|
|
|
|
void DoTerminate();
|
|
|
|
virtual TaskQueueId GetTaskQueueId() const;
|
|
|
|
protected:
|
|
// Exposed for the embedder shell which allows clients to poll for events
|
|
// instead of dedicating a thread to the message loop.
|
|
friend class MessageLoop;
|
|
|
|
void RunExpiredTasksNow();
|
|
|
|
void RunSingleExpiredTaskNow();
|
|
|
|
protected:
|
|
MessageLoopImpl();
|
|
|
|
private:
|
|
fml::RefPtr<MessageLoopTaskQueues> task_queue_;
|
|
TaskQueueId queue_id_;
|
|
|
|
std::atomic_bool terminated_;
|
|
|
|
void FlushTasks(FlushType type);
|
|
|
|
FML_DISALLOW_COPY_AND_ASSIGN(MessageLoopImpl);
|
|
};
|
|
|
|
} // namespace fml
|
|
|
|
#endif // FLUTTER_FML_MESSAGE_LOOP_IMPL_H_
|