181ad4e18f
Use futures to images used for comparison with fixtures in embedder unit-tests. ( #14465 )
...
This earlier pattern was to use callbacks with latching.
2019-12-12 14:07:53 -08:00
0a40f3d784
Assert that arc end caps on canvases with root surface transformations are drawn correctly. ( #14359 )
...
Verifies that the Skia commit https://skia-review.googlesource.com/c/skia/+/259174 has been pulled into the engine. This should have happened in the roll https://github.com/flutter/engine/pull/14345 .
Fixes https://github.com/flutter/flutter/issues/46691
Fixes b/142280381
2019-12-11 15:17:34 -08:00
d117ac979c
Wire up Opacity on Fuchsia, round 2 ( #14024 )
...
* Remove erroneous ChildView opacity
* Wire frame metrics through contexts
* Maintain layer stack inside of SceneBuilder
* Remove EnsureSingleChild
* Centralize system-composite and elevation logic
* Wire up OpacityLayer to Scenic
2019-12-04 19:29:31 -08:00
e6887328a1
Fix platform view offsets incorrectly taking into account device pixel ratios. ( #14135 )
...
This issue was hidden by an incorrect test expectation that has been corrected.
Fixes b/144555069
Fixes https://github.com/flutter/flutter/issues/45991
2019-12-04 13:15:47 -08:00
2fc1e1bce1
Relanding: Add Flow unittests and fixtures ( #14091 )
2019-12-03 14:33:02 -08:00
84bf72917c
Revert PRs to unblock David and Jim's work ( #14088 )
...
* Revert "Add flow test fixtures and tests (#13986 )"
This reverts commit 620f5281b8#13976 )"
This reverts commit a86ef94656
2019-12-03 12:02:37 -08:00
620f5281b8
Add flow test fixtures and tests ( #13986 )
2019-12-03 09:43:02 -08:00
9f6401362d
Don't crash but warn when the scene builder specifies no layers. ( #14008 )
2019-11-25 15:38:41 -08:00
89e395853c
Refactor to passing functions by const ref ( #13975 )
...
Moved our code to passing functions by const ref
2019-11-22 12:20:02 -08:00
75ea3e2445
Expose the platform view mutator stack to custom compositors. ( #13731 )
...
This allows custom compositors to affect scene builder modifications made
to the platform view.
Fixes https://github.com/flutter/flutter/issues/44211
Fixes b/143612326
2019-11-19 10:35:41 -08:00
132d38cd22
Moves pointer event sanitizing to engine. ( #13697 )
...
* Moves pointer event sanitizing to engine
* fix comment format
* fix formatting
* addressing comment
* fix format
* fix format
* addressing comment
2019-11-19 09:48:25 -08:00
762294cf2d
Revert "RendererContextSwitch guard flutter's gl context rework. ( #13812 )" ( #13906 )
...
This reverts commit f456423cfbflutter/flutter#45098
(images don't load on iOS).
2019-11-18 18:28:04 -08:00
6bab64e6dc
Fix test to account for pixel ratio transformations being framework responsibility. ( #13850 )
...
This incorrect assumption led to the introduction of a failure on an external embedder. Also dries up the section that copies the picture to the embedder managed render targets.
Fixes https://github.com/flutter/flutter/issues/43906
Fixes https://b.corp.google.com/issues/143529469
2019-11-14 12:15:33 -08:00
f456423cfb
RendererContextSwitch guard flutter's gl context rework. ( #13812 )
2019-11-14 11:50:45 -08:00
a59c96910d
Document the coordinate space of points in FlutterPointerEvent. ( #13782 )
2019-11-12 12:21:50 -08:00
6d66993b1d
Revert "Reland "Guarding EAGLContext used by Flutter #13314 " ( #13759 )" ( #13788 )
...
This reverts commit 2dcfaaeb5d
2019-11-11 17:17:18 -08:00
2dcfaaeb5d
Reland "Guarding EAGLContext used by Flutter #13314 " ( #13759 )
2019-11-08 20:09:18 -08:00
8a99d10748
Turn on RasterCache based on view hierarchy ( #13762 )
...
This is a duplicate of flutter/engine#13360 with the test switched to use the software backend instead of the GL backend.
After some debugging and testing on another GL embedder I think the issue with the test is some bug having to do with the GL implementation in the test harness specifically.
Fixes flutter/flutter#38903
2019-11-08 17:14:50 -08:00
f5754357b6
Revert "Reland "Guarding EAGLContext used by Flutter #13314 " ( #13755 )" ( #13757 )
...
This reverts commit 618e6666ce
2019-11-08 13:44:29 -08:00
618e6666ce
Reland "Guarding EAGLContext used by Flutter #13314 " ( #13755 )
2019-11-08 12:26:48 -08:00
2036530c4d
Revert "Always use IOSGLContextSwitch to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext ( #13314 )" ( #13753 )
2019-11-08 10:59:45 -08:00
bec554211b
Always use IOSGLContextSwitch to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext ( #13314 )
2019-11-08 10:02:23 -08:00
7590336bbc
Create a new picture recorder even when the embedder supplied render target is recycled. ( #13744 )
...
The earlier assumption was that the render target would be re-materialized per frame. The render target needs its own picture recorder to be create per frame as well. When render targets are cached in the registry, an existing target will be reused. But submitting the previous frame would have discarded the recorder already. The layer tree paint would then attempt to dererence a null canvas causing a crash at runtime.
Added tests to ensure that this does not happen both with and without a custom compositor specified by the embedder. I am going to rework this code so that the external view embedders thinks of render target access on a per frame basis but that is a larger change. This smaller patchset should unblock broken builds.
Fixes b/144093523
2019-11-07 19:53:51 -08:00
d59b1583b0
Ensure that the device pixel ratio is taken into account with window metrics in physical pixels. ( #13708 )
...
This was originally patched in https://github.com/flutter/engine/pull/13193 but
the unit-tests were written under the mistaken assumption (that has been
documented already) that the Flutter window metrics used logical pixel
coordinates. That mistake has been corrected and additional tests to verify
rendering intent has been added.
Fixes https://github.com/flutter/flutter/issues/43906
Fixes https://b.corp.google.com/issues/143529469
2019-11-06 11:16:18 -08:00
e609577d12
Revert "Turn on RasterCache based on view hierarchy ( #13360 )" ( #13442 )
...
This caused EmbedderTest.VerifyB143464703 to fail after merging into
master.
```
../../flutter/shell/platform/embedder/tests/embedder_unittests.cc:3111: Failure
Value of: ImageMatchesFixture("verifyb143464703.png", renderered_scene)
Actual: false
Expected: true
[ FAILED ] EmbedderTest.VerifyB143464703 (2507 ms)
```
This reverts commit 3ad3bc76a5
2019-10-30 11:25:29 -07:00
Chinmay Garde
David Worsham
liyuqian
gaaclarke
chunhtai
Todd Volkert
Chris Yang
Michael Klimushyn