22 Commits

Author SHA1 Message Date
gaaclarke 84497ba495 Started setting the FlutterOverlayView's bounds when it gets added to its superview. (#14018) 2019-12-05 13:53:07 -08:00
Todd Volkert 762294cf2d Revert "RendererContextSwitch guard flutter's gl context rework. (#13812)" (#13906)
This reverts commit f456423cfb.

This is being reverted because it caused flutter/flutter#45098
(images don't load on iOS).
2019-11-18 18:28:04 -08:00
Chris Yang f456423cfb RendererContextSwitch guard flutter's gl context rework. (#13812) 2019-11-14 11:50:45 -08:00
Chris Yang 6d66993b1d Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13759)" (#13788)
This reverts commit 2dcfaaeb5d.
2019-11-11 17:17:18 -08:00
Chris Yang 2dcfaaeb5d Reland "Guarding EAGLContext used by Flutter #13314" (#13759) 2019-11-08 20:09:18 -08:00
Chris Yang f5754357b6 Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13755)" (#13757)
This reverts commit 618e6666ce.
2019-11-08 13:44:29 -08:00
Chris Yang 618e6666ce Reland "Guarding EAGLContext used by Flutter #13314" (#13755) 2019-11-08 12:26:48 -08:00
Chris Yang 2036530c4d Revert "Always use IOSGLContextSwitch to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (#13314)" (#13753) 2019-11-08 10:59:45 -08:00
Chris Yang bec554211b Always use IOSGLContextSwitch to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (#13314) 2019-11-08 10:02:23 -08:00
Amir Hardon 8997f34819 Fix stale platform view gr context on iOS (#13469)
When gr context is changed (this happens when sending the app to the background and then to the foreground) we need to update it for all the platform view overlay surfaces.

The update logic was caching the previous gr context to figure if it had to be updated, but after updating it for a given overlay we were updating the cached context. In apps with multiple platform views this will result in overlays with a stale gr context.

This fixes flutter/flutter#36437
And I believe it should fix flutter/flutter#36999 as well (though I don't have repro code to verify).
2019-10-31 16:51:11 -07:00
Amir Hardon c63aefd28b Fix iOS crash when multiple platform views are in the scene (#13449)
Having 2 or more platform views simultaneously in the layer tree was crashing immediately on iOS with GL backend.

This regressed in #11070 which passed gl_context to a function in a loop using std::move (which meant on the second iteration the caller is no longer the owner of the field).

I added a scenarios_app test, though this test doesn't run on a physical device on CI so it would have only caught the problem when running locally (flutter/flutter#43852).
2019-10-31 10:30:15 -07:00
Dan Field 6bd0ef3dfe dart analysis of tests, cleanup (#13033) 2019-10-09 15:13:29 -07:00
Chris Yang e45f690910 Remove unused imports in the scenario app (#12728) 2019-10-02 04:19:19 +08:00
Chris Yang bf620dc568 Reland "Add iOS platform view mutation XCUITests to the scenario app(#11652)" (#12707) 2019-10-02 01:51:31 +08:00
Kaushik Iska 289d1eaaa9 Revert "Add iOS platform view mutation XCUITests to the scenario app (#11652)" (#12292)
This reverts commit b73cfdad4f.
2019-09-15 17:57:54 -07:00
Chris Yang b73cfdad4f Add iOS platform view mutation XCUITests to the scenario app (#11652) 2019-09-16 07:56:24 +08:00
xster 7d8c6d9c1a Reland add some AppLifecycleTests 2019-09-13 10:34:36 -07:00
Alexander Aprelev 850d80c352 Revert "Add some AppLifecycleTests (#11890)" (#12264)
This reverts commit 46ff05346b as it breaks mac tests https://ci.chromium.org/p/flutter/builders/prod/Mac%20Host%20Engine/2156.
2019-09-13 09:16:03 -07:00
xster 46ff05346b Add some AppLifecycleTests (#11890) 2019-09-12 16:36:30 -07:00
Dan Field c8f02c95ea Add tests for platform views (#11319) 2019-08-20 20:48:40 -07:00
Dan Field aea0d7a651 test scenario_app on CI (#10065) 2019-07-26 15:59:18 -07:00
Dan Field a0ec52886b Embedding testing app (#10007) 2019-07-23 12:41:03 -07:00