728 Commits

Author SHA1 Message Date
Chris Bracken 23df3e6bcb Revert "Add support for on/off switch labels when built on iOS 13. (#12467)" (#15370)
Broke a fake implementation of Accessibility features in the framework.
While this change is unlikely to break any users in the wild, this is a
breaking change by the standards set out in our documentation and
should follow the breaking change announcement process. Details can be
found at https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes.

The error in question:

    Missing concrete implementation of 'getter AccessibilityFeatures.onOffSwitchLabels' • packages/flutter_test/test/window_test.dart:252:7 • non_abstract_class_inherits_abstract_member

This reverts commit d12f2a6096.
2020-01-09 10:33:51 -08:00
brandondiamond d12f2a6096 Add support for on/off switch labels when built on iOS 13. (#12467) 2020-01-08 18:26:44 -08:00
Jim Graham 929b1edff5 Engine support for ImageFiltered widget (#14491)
web_ui support coming in https://github.com/flutter/flutter/issues/47163
2019-12-19 16:47:08 -08:00
Jim Graham 22413efc48 Update formatting in web_ui scene bulder to match flutter style and dartfmt. (#14539) 2019-12-19 12:50:39 -08:00
Kaushik Iska f2dbeb8aa7 Reland Wire up Opacity on Fuchsia (#14559)
This reverts commit 6ea69a0d43.

On top of the revert, it reverted a commit in the PR:
https://github.com/flutter/engine/pull/14024

This reverts commit ea67e5b0b9.
2019-12-18 16:05:38 -08:00
Kaushik Iska 6ea69a0d43 Revert "Wire up Opacity on Fuchsia, round 2 (#14024)" (#14543)
This reverts commit d117ac979c.
2019-12-18 10:29:47 -08:00
Lau Ching Jun c327cae7ab Revert "Fix off-by-one fromRGBO alpha value calculation (#13777)" (#14548)
This reverts commit 9f2daad648.
2019-12-18 00:22:50 -08:00
Tomás Arias 9f2daad648 Fix off-by-one fromRGBO alpha value calculation (#13777)
Constructing colors using `fromRGBO` should return the same values as the CSS
`rgba()` notation.  rgba(0, 0, 255, 0.5) is the same as `#0000ff80`

However `fromRGBO` sometimes creates a color with an off-by-one alpha value:

    expect(Color.fromRGBO(0, 0, 255, 0.5), Color(0x800000ff));

Expected: Color:<Color(0x800000ff)>
  Actual: Color:<Color(0x7f0000ff)>

If we use `withOpacity` to create the same color, it returns the correct color:

    expect(Color.fromRGBO(0, 0, 255, 1).withOpacity(0.5), Color(0x800000ff));

This should also be changed in lib/web_ui/lib/src/ui/painting.dart in a
followup change.
2019-12-17 09:34:30 -08:00
Jason Simmons bdd4e4d948 Do not assume that createTypeface is called before getStyle in the AssetManagerFontStyleSet (#14343) 2019-12-13 09:23:08 -08:00
Alexander Aprelev 0081e8c516 Remove unused _TypeNone enum field. (#14440)
* Remove unused field
* Similarly remove _TypeNone from web_ui
2019-12-12 09:43:44 -08:00
Dwayne Slater 80d80ff6e6 Add ability to control dithering on Paint (#13868) 2019-12-11 14:53:50 -08:00
Chinmay Garde 49d6552e76 Verify accounting for loop counts in Gif and WebP assets is consistent. (#14321)
Asserts that the Skia fix is pulled into Flutter Engine https://skia-review.googlesource.com/c/skia/+/259161. This should have happened in https://github.com/flutter/engine/pull/14315.

Fixes https://github.com/flutter/flutter/issues/46289
Fixes https://github.com/flutter/flutter/issues/45246
2019-12-10 20:04:15 -08:00
David Worsham d117ac979c Wire up Opacity on Fuchsia, round 2 (#14024)
* Remove erroneous ChildView opacity

* Wire frame metrics through contexts

* Maintain layer stack inside of SceneBuilder

* Remove EnsureSingleChild

* Centralize system-composite and elevation logic

* Wire up OpacityLayer to Scenic
2019-12-04 19:29:31 -08:00
Brian Osman 1a96087747 Update to newer path fill-type API in Skia (#14070) 2019-12-03 11:57:54 -05:00
Jason Simmons c7ec5bbc1c Convert images to raster on the GPU thread for Image.toByteData (#13647)
If the image is a cross-context image that might be read from the GPU thread
during onscreen rendering, then it is not safe to read it concurrently from
the IO thread as part of Image.toByteData.

If the GPU thread does not have a graphics context, then fall back to
converting the image on the IO thread.

Fixes https://github.com/flutter/flutter/issues/30697
2019-11-25 14:44:57 -08:00
Brian Osman 388f814d0e Use new SkPathDirection enum, previous one is deprecated (#14005) 2019-11-25 14:03:16 -05:00
gaaclarke 97a23a80e1 Made a way to turn off the OpenGL operations on the IO thread for backgrounded apps (#13908) 2019-11-22 14:08:33 -08:00
gaaclarke 89e395853c Refactor to passing functions by const ref (#13975)
Moved our code to passing functions by const ref
2019-11-22 12:20:02 -08:00
Jim Graham ffcd8564a2 Imagefilter wrapper object (#13711)
Make ImageFilter objects comparable and printable.

This will help in areas in the Widget and RenderObject trees which try to avoid marking objects for updates if a setter is called with the same value (previously all ImageFilter objects would compare as not equal and appear to be new values).
2019-11-19 13:43:06 -08:00
chunhtai 132d38cd22 Moves pointer event sanitizing to engine. (#13697)
* Moves pointer event sanitizing to engine

* fix comment format

* fix formatting

* addressing comment

* fix format

* fix format

* addressing comment
2019-11-19 09:48:25 -08:00
Kate Lovett f4fba66c2f Adding opacity -> alpha method to Color class (#13902) 2019-11-19 09:48:04 -08:00
Gary Qian b3463e3580 getLineBoundary edge condition use <= instead of < (#13881) 2019-11-15 15:14:03 -08:00
Jason Simmons f5c002254b Use Skia's matchStyleCSS3 to find bundled asset typefaces matching a font style (#13848)
This will improve font matching in SkParagraph for fonts that are bundled as
assets within the app.  Libtxt was using Minikin's FontFamily class to select
the closest matching font, but SkParagraph will rely on the matchStyle
implementation in the asset font manager.
2019-11-13 17:44:25 -08:00
chunhtai 1f1e2ba58e reland add lifecycle enum (#13767)
This reverts commit 8ebb318401.
2019-11-13 11:26:25 -08:00
Greg Spencer f68de3f451 Add line boundary information to LineMetrics. (#13727)
This exposes the line boundary information a line by adding getLineBoundary to return the indices corresponding to a line around a TextPosition. The information is already calculated when calculating line metrics, so that we can enable moving the selection/cursor to the beginning/end of a line in a text field.
2019-11-11 16:42:40 -08:00