Kaushik Iska
f2dbeb8aa7
Reland Wire up Opacity on Fuchsia ( #14559 )
...
This reverts commit 6ea69a0d43 .
On top of the revert, it reverted a commit in the PR:
https://github.com/flutter/engine/pull/14024
This reverts commit ea67e5b0b9 .
2019-12-18 16:05:38 -08:00
Kaushik Iska
6ea69a0d43
Revert "Wire up Opacity on Fuchsia, round 2 ( #14024 )" ( #14543 )
...
This reverts commit d117ac979c .
2019-12-18 10:29:47 -08:00
Chinmay Garde
871246172d
Allow custom embedders to post low memory notifications. ( #14506 )
...
This is a non-breaking addition to the stable Flutter Embedder API.
2019-12-16 11:42:13 -08:00
Chinmay Garde
f05832153b
Allow embedders to post Dart objects on send ports from the native side. ( #14477 )
...
This is a non-breaking addition to the stable Flutter Embedder API and exposes a
subset of the functionality provided by Dart_PostCObject API in a stable and
tested manner to custom embedder implementations.
Send port acquisition can currently be done as described in the unit-test but
there may be opportunities to extend this API in the future to access ports more
easily or create ports from the native side.
The following capabilities of the the Dart_PostCObject API are explicitly NOT
exposed:
* Object arrays: This allows callers to create complex object graphs but only
using the primitives specified in the native API. I could find no current use
case for this and would have made the implementation a lot more complex. This
is something we can add in the future if necessary however.
* Capabilities and ports: Again no use cases and I honestly I didn’t understand
how to use capabilities. If needed, these can be added at a later point by
appending to the union.
Fixes https://github.com/flutter/flutter/issues/46624
Fixes b/145982720
2019-12-13 17:28:21 -08:00
Chinmay Garde
03f45a1edd
Verify embedders can convert clip rects from mutation stack into surface space. ( #14483 )
...
Add a test to verify behavior discussed in b/143612326
2019-12-13 15:28:01 -08:00
Chinmay Garde
181ad4e18f
Use futures to images used for comparison with fixtures in embedder unit-tests. ( #14465 )
...
This earlier pattern was to use callbacks with latching.
2019-12-12 14:07:53 -08:00
Chinmay Garde
0a40f3d784
Assert that arc end caps on canvases with root surface transformations are drawn correctly. ( #14359 )
...
Verifies that the Skia commit https://skia-review.googlesource.com/c/skia/+/259174 has been pulled into the engine. This should have happened in the roll https://github.com/flutter/engine/pull/14345 .
Fixes https://github.com/flutter/flutter/issues/46691
Fixes b/142280381
2019-12-11 15:17:34 -08:00
David Worsham
d117ac979c
Wire up Opacity on Fuchsia, round 2 ( #14024 )
...
* Remove erroneous ChildView opacity
* Wire frame metrics through contexts
* Maintain layer stack inside of SceneBuilder
* Remove EnsureSingleChild
* Centralize system-composite and elevation logic
* Wire up OpacityLayer to Scenic
2019-12-04 19:29:31 -08:00
Chinmay Garde
e6887328a1
Fix platform view offsets incorrectly taking into account device pixel ratios. ( #14135 )
...
This issue was hidden by an incorrect test expectation that has been corrected.
Fixes b/144555069
Fixes https://github.com/flutter/flutter/issues/45991
2019-12-04 13:15:47 -08:00
David Worsham
2fc1e1bce1
Relanding: Add Flow unittests and fixtures ( #14091 )
2019-12-03 14:33:02 -08:00
liyuqian
84bf72917c
Revert PRs to unblock David and Jim's work ( #14088 )
...
* Revert "Add flow test fixtures and tests (#13986 )"
This reverts commit 620f5281b8 .
* Revert "Dynamically determine whether to use offscreen surface based on need (#13976 )"
This reverts commit a86ef94656 .
2019-12-03 12:02:37 -08:00
David Worsham
620f5281b8
Add flow test fixtures and tests ( #13986 )
2019-12-03 09:43:02 -08:00
Chinmay Garde
9f6401362d
Don't crash but warn when the scene builder specifies no layers. ( #14008 )
2019-11-25 15:38:41 -08:00
gaaclarke
89e395853c
Refactor to passing functions by const ref ( #13975 )
...
Moved our code to passing functions by const ref
2019-11-22 12:20:02 -08:00
Chinmay Garde
75ea3e2445
Expose the platform view mutator stack to custom compositors. ( #13731 )
...
This allows custom compositors to affect scene builder modifications made
to the platform view.
Fixes https://github.com/flutter/flutter/issues/44211
Fixes b/143612326
2019-11-19 10:35:41 -08:00
chunhtai
132d38cd22
Moves pointer event sanitizing to engine. ( #13697 )
...
* Moves pointer event sanitizing to engine
* fix comment format
* fix formatting
* addressing comment
* fix format
* fix format
* addressing comment
2019-11-19 09:48:25 -08:00
Todd Volkert
762294cf2d
Revert "RendererContextSwitch guard flutter's gl context rework. ( #13812 )" ( #13906 )
...
This reverts commit f456423cfb .
This is being reverted because it caused flutter/flutter#45098
(images don't load on iOS).
2019-11-18 18:28:04 -08:00
Chinmay Garde
6bab64e6dc
Fix test to account for pixel ratio transformations being framework responsibility. ( #13850 )
...
This incorrect assumption led to the introduction of a failure on an external embedder. Also dries up the section that copies the picture to the embedder managed render targets.
Fixes https://github.com/flutter/flutter/issues/43906
Fixes https://b.corp.google.com/issues/143529469
2019-11-14 12:15:33 -08:00
Chris Yang
f456423cfb
RendererContextSwitch guard flutter's gl context rework. ( #13812 )
2019-11-14 11:50:45 -08:00
Chinmay Garde
a59c96910d
Document the coordinate space of points in FlutterPointerEvent. ( #13782 )
2019-11-12 12:21:50 -08:00
Chris Yang
6d66993b1d
Revert "Reland "Guarding EAGLContext used by Flutter #13314 " ( #13759 )" ( #13788 )
...
This reverts commit 2dcfaaeb5d .
2019-11-11 17:17:18 -08:00
Chris Yang
2dcfaaeb5d
Reland "Guarding EAGLContext used by Flutter #13314 " ( #13759 )
2019-11-08 20:09:18 -08:00
Michael Klimushyn
8a99d10748
Turn on RasterCache based on view hierarchy ( #13762 )
...
This is a duplicate of flutter/engine#13360 with the test switched to use the software backend instead of the GL backend.
After some debugging and testing on another GL embedder I think the issue with the test is some bug having to do with the GL implementation in the test harness specifically.
Fixes flutter/flutter#38903
2019-11-08 17:14:50 -08:00
Chris Yang
f5754357b6
Revert "Reland "Guarding EAGLContext used by Flutter #13314 " ( #13755 )" ( #13757 )
...
This reverts commit 618e6666ce .
2019-11-08 13:44:29 -08:00
Chris Yang
618e6666ce
Reland "Guarding EAGLContext used by Flutter #13314 " ( #13755 )
2019-11-08 12:26:48 -08:00