From b0dc4a6316daef72f2ff74b0afbc46633b69c96b Mon Sep 17 00:00:00 2001 From: James Robinson Date: Fri, 26 Aug 2016 13:48:01 -0700 Subject: [PATCH] [gn] Explicitly include common.gni in build files that use vars from it (#2973) runtime/BUILD.gn and ..core/BUILD.gn use flutter_runtime_mode which is defined in common.gni. If the build comes through common/BUILD.gn this is imported (implicity) but builds that depend on specific files, like the Fuchsia build, won't have this imported. This imports the gni from the build files that use it instead of relying on it already being there. --- runtime/BUILD.gn | 2 ++ sky/engine/core/BUILD.gn | 1 + 2 files changed, 3 insertions(+) diff --git a/runtime/BUILD.gn b/runtime/BUILD.gn index bf90bece9..44ccfb835 100644 --- a/runtime/BUILD.gn +++ b/runtime/BUILD.gn @@ -2,6 +2,8 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. +import("//flutter/common/config.gni") + vmservice_sources_gypi = exec_script("//build/gypi_to_gn.py", [ rebase_path("//dart/runtime/bin/vmservice/vmservice_sources.gypi") ], diff --git a/sky/engine/core/BUILD.gn b/sky/engine/core/BUILD.gn index 3cd166bd9..f7f0b2386 100644 --- a/sky/engine/core/BUILD.gn +++ b/sky/engine/core/BUILD.gn @@ -2,6 +2,7 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. +import("//flutter/common/config.gni") import("//flutter/sky/engine/core/core.gni") visibility = [ "//flutter/sky/engine/*", "//flutter/sky/shell/*" ]