From 1bcb96bf3d34bb23c816d85c7cc6fc90fa73d434 Mon Sep 17 00:00:00 2001 From: liyuqian Date: Sun, 21 Apr 2019 11:04:37 -0700 Subject: [PATCH] Add framework test in engine presubmit checks (#8664) With this, no Skia or Dart roll (or any other engine commit) would accidentally break the framework. For commits that require manual engine-to-framework rolls, the `build_and_test_host` test would fail. In such cases, the author should explicitly mention **"merge on red as the failure is expected; the engine will be manually rolled into the framework"**. --- .cirrus.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index dde481e94..90437979f 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -13,6 +13,8 @@ task: ENGINE_PATH: "/tmp/clean_engine" DEPOT_TOOLS: "/tmp/depot_tools" PATH: "$DEPOT_TOOLS:$PATH" + FLUTTER_ENGINE: "/tmp/clean_engine/src" + FRAMEWORK_PATH: "/tmp/master_framework" depot_tools_script: git clone --depth 1 https://chromium.googlesource.com/chromium/tools/depot_tools.git $DEPOT_TOOLS gclient_sync_script: | @@ -31,6 +33,13 @@ task: ./flutter/tools/gn --unoptimized ninja -C out/host_debug_unopt test_host_script: cd $ENGINE_PATH/src && ./flutter/testing/run_tests.sh host_debug_unopt + fetch_framework_script: | + mkdir -p $FRAMEWORK_PATH + cd $FRAMEWORK_PATH + git clone https://github.com/flutter/flutter.git + framework_test_script: | + cd $FRAMEWORK_PATH/flutter/packages/flutter + ../../bin/flutter test --local-engine=host_debug_unopt - name: build_and_test_host_profile compile_host_script: | cd $ENGINE_PATH/src