We still delete the Sys folder though, because otherwise games will use the wrong settings due to our wildcard support. And we delete the Languages folder, any DLL files, uninst.exe, Dolphin.exe, DSPTool.exe and the qt.conf and cpack_package_description.txt that older Dolphin installers or packages accidentally create.
This change was introduced for 4.0.1 and never ported to the
master branch until now. It would be awkward to have 5.0 go back
to the 4.0 behavior after we already changed the behavior once.
To match Microsoft's recommendations better, Dolphin now has 16x16,
32x32 and 48x48 bitmaps in both 8-bit and 32-bit, in addition to the
256x256 32-bit bitmap. There used to be an 8-bit 32x32 bitmap but no
32-bit 32x32 bitmap, which led to Windows using the ugly 8-bit bitmap
at some sizes.
This PR installs an SVG icon to use as the main icon for dolphin in Linux
desktop environments (through the .desktop file) and removes the currently used
XPM icon. I've also added a 48x48 PNG for any desktops which don't support SVG
icons.
This has been the recommended way to ship application icons since forever
according to the Icon Theme Spec:
https://www.freedesktop.org/wiki/Specifications/icon-theme-spec/
This is also a prerequisite for dolphin appearing in the GNOME Software Centre
which does not support XPM icons.
Executing xdg-open on a desktop file opens the default text editor instead of
running the application which I suspect is what was intended. Since the file
is installed as non-executable, this should have no effect on anyone.