88 Commits

Author SHA1 Message Date
Jack Andersen 314563614e Remove unnecessary stropts.h include 2019-10-12 18:52:58 -10:00
Phillip Stephens a46858acec Merge pull request #38 from lioncash/cast
NintendoPowerA: Use std::memcpy within transferCycle()
2019-09-06 23:24:56 -07:00
Lioncash f445df1701 NintendoPowerA: Use std::memcpy within transferCycle()
Eliminates undefined behavior within the function.
2019-09-06 07:30:13 -04:00
Lioncash 4b82c6510f NintendoPowerA: Use std::array where applicable 2019-09-06 07:28:10 -04:00
Lioncash 2e0c7dc973 NintendoPowerA: Use deduction guides for locks
Same behavior, but without the need to explicitly hardcode the mutex
type.
2019-09-06 07:26:05 -04:00
Lioncash 7496109ff6 NintendoPowerA: Make constructor explicit
While we're at it we can also ensure that all class members have
deterministic initial state.
2019-09-06 07:24:17 -04:00
Lioncash 475037f0e5 DolphinSmashAdapter: Use std::array where applicable 2019-09-06 06:35:27 -04:00
Jack Andersen c642bccf03 Merge branch 'master' of ssh://git.axiodl.com:6431/AxioDL/boo 2019-08-31 10:34:11 -10:00
Jack Andersen 804ee871f4 MacOS build fixes 2019-08-31 10:12:12 -10:00
Phillip Stephens 4d1c7d444d Merge pull request #31 from lioncash/hid
HIDParser: Use std::array where applicable
2019-08-24 18:06:10 -07:00
Lioncash a3a9b1ada7 HIDParser: Use emplace() instead of insert()
Same thing, but shorter.
2019-08-24 20:58:56 -04:00
Lioncash c8bebc9948 HIDParser: Eliminate variable shadowing
We can rename some locals to avoid shadowing other variables.
2019-08-24 20:55:52 -04:00
Lioncash 14369a9853 HIDParser: Use std::array where applicable
Same thing, but strongly enforces the type of the array. This also
allows removing the <type_traits> include, since we can just query the
size of the array.
2019-08-24 20:51:46 -04:00
Lioncash f1ad7e5ef0 General: Correct fmt specifiers
Corrects a few fmt calls to use fmt's specifiers. This also converts
instances of printf over to fmt::print
2019-08-24 17:12:49 -04:00
Lioncash baff71cdc3 General: Tidy up includes
Alphabetizes includes and resolves quite a few instances of indirect
inclusions, making the requirements of several interfaces explicit. This
also trims out includes that aren't actually necessary (likely due to
changes in the API over time).
2019-08-19 21:02:56 -04:00
Lioncash 90485ac1b9 DeviceFinder: Make use of unordered_map's emplace within _insertToken
Same thing, but less reading.
2019-08-18 05:50:37 -04:00
Lioncash 6cc5b30127 DeviceFinder: Invert conditionals within _insertToken and _removeToken
By converting the conditions into guard clauses, we can eliminate some
code nesting.
2019-08-18 05:48:57 -04:00
Lioncash 9853a97dd2 DeviceFinder: Move includes into cpp file where applicable
Avoids over-exposing inclusions that don't need to be propagated across
headers.
2019-08-18 05:45:13 -04:00
Lioncash 84f62a0f2c BooObject: Remove destructorLock()
Now that we have the fencing and atomic operations in place to ensure
access to data on other threads will always occur before the use of
delete, we can remove the destructor lock. This will be useful for
making ObjToken's move assignment operator noexcept.
2019-08-17 14:12:23 -04:00
Lioncash 78ce16aa9f General: Make use of nullptr where applicable 2019-08-16 18:27:23 -07:00
Lioncash 386ec8e6cc General: Add missing override specifiers
Adds override specifiers that I missed for other platforms when
initially applying them to the codebase.
2019-08-16 18:27:23 -07:00
Lioncash 80c1103b44 General: Make member functions const where applicable
These functions don't modify instance state, so they can be marked
const.
2019-08-16 18:27:23 -07:00
Lioncash d4cd2b4dce General: Make use of override where applicable
Continues the override modernizations, but now targeting boo.
2019-08-12 22:44:45 -04:00
Jack Andersen af50bc0bc2 Windows build fixes 2019-07-27 15:19:25 -10:00
Jack Andersen deefc8e995 Massive fmtlib refactor 2019-07-19 18:22:36 -10:00