From e153d075939fb628a7dc42b12e1b3461842db541 Mon Sep 17 00:00:00 2001 From: Jack Wotherspoon Date: Fri, 27 Jun 2025 09:42:14 -0700 Subject: [PATCH] chore: updating CONTRIBUTING.md with missing extra Merge https://github.com/google/adk-python/pull/1679 Contributing doc says to do the following: ```sh uv sync --extra test --extra eval pytest ./tests/unittests ``` If you follow this the tests will fail: ```sh tests/unittests/a2a/executor/test_task_result_aggregator.py:27: in from a2a.types import Message E ModuleNotFoundError: No module named 'a2a' ``` This makes sense since the `a2a` package is not part of ADK's core dep, it is an extra: https://github.com/google/adk-python/blob/e79651cd86ba3f0c998109f2140f1db2cab78708/pyproject.toml#L79-L83 Thus for a2a tests to pass we must include the extra in the sync command: ```sh uv sync --extra test --extra eval --extra a2a pytest ./tests/unittests ``` COPYBARA_INTEGRATE_REVIEW=https://github.com/google/adk-python/pull/1679 from jackwotherspoon:main c1a536780409065db817088a8d5ed5979cca8d8f PiperOrigin-RevId: 776617515 --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0d7b2d67..597feef6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -147,11 +147,11 @@ For any changes that impact user-facing documentation (guides, API reference, tu pytest ./tests/unittests ``` - NOTE: for accurately repro test failure, only include `test` and `eval` as - extra dependencies. + NOTE: for accurate repro of test failure, only include `test`, `eval` and + `a2a` as extra dependencies. ```shell - uv sync --extra test --extra eval + uv sync --extra test --extra eval --extra a2a pytest ./tests/unittests ```