encounter/adk-python
0
0
Fork 0
mirror of https://github.com/encounter/adk-python.git synced 2026-07-09 18:19:28 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): ignore session_db_kwargs for sqlite session services

Browse Source 
Close issue #4317

Co-authored-by: Liang Wu <wuliang@google.com>
PiperOrigin-RevId: 864979145
This commit is contained in:
Liang Wu
2026-02-03 11:49:13 -08:00
committed by Copybara-Service
parent 706a6dda81
commit ce07cd8144
2 changed files with 28 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unittests/cli/test_service_registry.py
+18 -6
View File
@@ -63,13 +63,25 @@ def test_create_session_service_sqlite(registry, mock_services):
mock_services["sqlite_session"].assert_called_once_with(db_path="test.db")
def test_create_session_service_sqlite_with_kwargs(registry, mock_services):
registry.create_session_service(
"sqlite:///test.db", pool_size=10, agents_dir="foo"
)
mock_services["sqlite_session"].assert_called_once_with(
db_path="test.db", pool_size=10
def test_create_session_service_sqlite_ignores_unsupported_kwargs(
registry, mock_services, caplog
):
"""Test that SqliteSessionService ignores unsupported kwargs and logs warning."""
import logging
with caplog.at_level(logging.WARNING):
registry.create_session_service(
"sqlite:///test.db", pool_size=10, agents_dir="foo"
)
# SqliteSessionService should only receive db_path, not pool_size
mock_services["sqlite_session"].assert_called_once_with(db_path="test.db")
# Verify warning was logged about ignored kwargs
assert (
"SqliteSessionService does not support additional kwargs" in caplog.text
)
assert "pool_size" in caplog.text
def test_create_session_service_postgresql(registry, mock_services):