encounter/adk-python
0
0
Fork 0
mirror of https://github.com/encounter/adk-python.git synced 2026-07-09 18:19:28 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: include delimiter when matching events from parent nodes in content processor

Browse Source 
Previously we only do a simple prefix string matching, thus `agent_00` will match with `agent_0`

With this new change, we either check directly equality, or must expect seeing `agent_0.`. See added test for branches we now match / skip.

TBF `.` is also not a perfect delimiter (I would imagine users might put dot in agent names). We might consider a follow up that bans such agent names.

Tested with script in the linked issue (I updated prompt so we see which agent they see from):

Before:

```
[agent_8]: 73
[agent_0]: 97
[agent_1]: 73
[agent_5]: 97
[agent_4]: 73
[agent_2]: 73
[agent_3]: 73
[agent_9]: 93
[agent_6]: 73
[agent_7]: 1
[agent_70]: 1 (agent_7)
[agent_20]: 73 (agent_2)
[agent_30]: 73 (agent_3)
[agent_00]: 97 (agent_0)
[agent_40]: 73 (agent_4)
[agent_80]: 73 (agent_8)
[agent_50]: 97 (agent_5)
[agent_90]: 93 (agent_9)
[agent_10]: 73 (agent_1)
[agent_60]: 73 (agent_6)
```

After:
```
[agent_9]: 73
[agent_6]: 73
[agent_2]: 73
[agent_7]: 93
[agent_4]: 73
[agent_1]: 73
[agent_3]: 73
[agent_5]: 97
[agent_0]: 73
[agent_8]: 87
[agent_50]: 0
[agent_80]: 0
[agent_10]: 0
[agent_90]: 0
[agent_30]: 0
[agent_20]: 0
[agent_60]: 0
[agent_00]: 0
[agent_40]: 0
[agent_70]: 0
```

Closes #2948

Co-authored-by: Kevin Qian <kqian@google.com>
PiperOrigin-RevId: 826187198
This commit is contained in:
Kevin Qian
2025-10-30 14:26:39 -07:00
committed by Copybara-Service
parent 2274c4f304
commit b8a2b6c570
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unittests/flows/llm_flows/test_contents_branch.py
+12
View File
@@ -58,6 +58,18 @@ async def test_branch_filtering_child_sees_parent():
content=types.ModelContent("Child agent response"),
branch="parent_agent.child_agent", # Current branch - should be included
),
Event(
invocation_id="inv4",
author="child_agent",
content=types.ModelContent("Excluded response 1"),
branch="parent_agent.child_agent000", # Prefix match BUT not itself/ancestor - should be excluded
),
Event(
invocation_id="inv5",
author="child_agent",
content=types.ModelContent("Excluded response 2"),
branch="parent_agent.child", # Prefix match BUT not itself/ancestor - should be excluded
),
]
invocation_context.session.events = events