From b4310727d90421a81a8afc47e3c344646ee7aee2 Mon Sep 17 00:00:00 2001 From: "Xiang (Sean) Zhou" Date: Wed, 3 Sep 2025 11:34:58 -0700 Subject: [PATCH] chore: Use lazy % formatting in logging functions to fix pylint warnings PiperOrigin-RevId: 802639682 --- src/google/adk/cli/cli_eval.py | 2 +- src/google/adk/flows/llm_flows/base_llm_flow.py | 4 ++-- src/google/adk/sessions/database_session_service.py | 2 +- src/google/adk/sessions/vertex_ai_session_service.py | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/google/adk/cli/cli_eval.py b/src/google/adk/cli/cli_eval.py index 89e7f415..7ccc8252 100644 --- a/src/google/adk/cli/cli_eval.py +++ b/src/google/adk/cli/cli_eval.py @@ -329,7 +329,7 @@ async def run_evals( except Exception: # Catching the general exception, so that we don't block other eval # cases. - logger.exception(f"Eval failed for `{eval_set_id}:{eval_name}`") + logger.exception("Eval failed for `%s:%s`", eval_set_id, eval_name) def _get_evaluator(eval_metric: EvalMetric) -> Evaluator: diff --git a/src/google/adk/flows/llm_flows/base_llm_flow.py b/src/google/adk/flows/llm_flows/base_llm_flow.py index 2785abea..aa5c039c 100644 --- a/src/google/adk/flows/llm_flows/base_llm_flow.py +++ b/src/google/adk/flows/llm_flows/base_llm_flow.py @@ -210,11 +210,11 @@ class BaseLlmFlow(ABC): except (ConnectionClosed, ConnectionClosedOK) as e: # when the session timeout, it will just close and not throw exception. # so this is for bad cases - logger.error(f'Connection closed: {e}.') + logger.error('Connection closed: %s.', e) raise except Exception as e: logger.error( - f'An unexpected error occurred in live flow: {e}', exc_info=True + 'An unexpected error occurred in live flow: %s', e, exc_info=True ) raise diff --git a/src/google/adk/sessions/database_session_service.py b/src/google/adk/sessions/database_session_service.py index d2bb71d0..959524c6 100644 --- a/src/google/adk/sessions/database_session_service.py +++ b/src/google/adk/sessions/database_session_service.py @@ -411,7 +411,7 @@ class DatabaseSessionService(BaseSessionService): # Get the local timezone local_timezone = get_localzone() - logger.info(f"Local timezone: {local_timezone}") + logger.info("Local timezone: %s", local_timezone) self.db_engine: Engine = db_engine self.metadata: MetaData = MetaData() diff --git a/src/google/adk/sessions/vertex_ai_session_service.py b/src/google/adk/sessions/vertex_ai_session_service.py index 5c4ca1f6..db864b3a 100644 --- a/src/google/adk/sessions/vertex_ai_session_service.py +++ b/src/google/adk/sessions/vertex_ai_session_service.py @@ -130,7 +130,7 @@ class VertexAiSessionService(BaseSessionService): reasoning_engine_id, session_id, api_client ) except ClientError: - logger.info(f'Polling session resource') + logger.info('Polling session resource') return None try: @@ -320,7 +320,7 @@ class VertexAiSessionService(BaseSessionService): request_dict={}, ) except Exception as e: - logger.error(f'Error deleting session {session_id}: {e}') + logger.error('Error deleting session %s: %s', session_id, e) raise e @override