encounter/adk-python
0
0
Fork 0
mirror of https://github.com/encounter/adk-python.git synced 2026-07-09 18:19:28 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: avoid local .adk storage in Cloud Run/GKE

Browse Source 
Default session and artifact services to in-memory when running in Cloud Run/Kubernetes (or when agents_dir isn’t writable) to prevent startup failures from attempting to create .adk under read-only/unwritable container paths (e.g. /app/agents/.adk). Local development defaults are unchanged.

  - ADK_FORCE_LOCAL_STORAGE=1 to always use .adk defaults
  - ADK_DISABLE_LOCAL_STORAGE=1 to always avoid local storage

If local artifact initialization raises PermissionError, fall back to in-memory and log a warning

Close #3907

Co-authored-by: George Weale <gweale@google.com>
PiperOrigin-RevId: 853315459
This commit is contained in:
George Weale
2026-01-07 10:18:11 -08:00
committed by Copybara-Service
parent d5bd8d939e
commit b30c2f4e13
8 changed files with 487 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unittests/cli/utils/test_cli_deploy.py
+43 -4
View File
@@ -128,13 +128,15 @@ def test_resolve_project_from_gcloud_fails(
@pytest.mark.parametrize(
"adk_version, session_uri, artifact_uri, memory_uri, expected",
"adk_version, session_uri, artifact_uri, memory_uri, use_local_storage, "
"expected",
[
(
"1.3.0",
"sqlite://s",
"gs://a",
"rag://m",
None,
(
"--session_service_uri=sqlite://s --artifact_service_uri=gs://a"
" --memory_service_uri=rag://m"
@@ -145,6 +147,7 @@ def test_resolve_project_from_gcloud_fails(
"sqlite://s",
"gs://a",
"rag://m",
None,
"--session_db_url=sqlite://s --artifact_storage_uri=gs://a",
),
(
@@ -152,6 +155,7 @@ def test_resolve_project_from_gcloud_fails(
"sqlite://s",
"gs://a",
"rag://m",
None,
"--session_db_url=sqlite://s",
),
(
@@ -159,16 +163,49 @@ def test_resolve_project_from_gcloud_fails(
"sqlite://s",
None,
None,
"--session_service_uri=sqlite://s ",
None,
"--session_service_uri=sqlite://s",
),
(
"1.3.0",
None,
"gs://a",
"rag://m",
" --artifact_service_uri=gs://a --memory_service_uri=rag://m",
None,
"--artifact_service_uri=gs://a --memory_service_uri=rag://m",
),
(
"1.2.0",
None,
"gs://a",
None,
None,
"--artifact_storage_uri=gs://a",
),
(
"1.21.0",
None,
None,
None,
False,
"--no_use_local_storage",
),
(
"1.21.0",
None,
None,
None,
True,
"--use_local_storage",
),
(
"1.21.0",
"sqlite://s",
"gs://a",
None,
False,
"--session_service_uri=sqlite://s --artifact_service_uri=gs://a",
),
("1.2.0", None, "gs://a", None, " --artifact_storage_uri=gs://a"),
],
)
def test_get_service_option_by_adk_version(
@@ -176,6 +213,7 @@ def test_get_service_option_by_adk_version(
session_uri: str | None,
artifact_uri: str | None,
memory_uri: str | None,
use_local_storage: bool | None,
expected: str,
) -> None:
"""It should return the correct service URI flags for a given ADK version."""
@@ -184,6 +222,7 @@ def test_get_service_option_by_adk_version(
session_uri=session_uri,
artifact_uri=artifact_uri,
memory_uri=memory_uri,
use_local_storage=use_local_storage,
)
assert actual.rstrip() == expected.rstrip()