From 97318bcd199acdacadfe8664da3fbfc3c806cdd2 Mon Sep 17 00:00:00 2001 From: Google Team Member Date: Mon, 4 Aug 2025 19:25:13 -0700 Subject: [PATCH] fix: correct type annotation Overridden `supported_models` should be a `classmethod` rather than a `staticmethod`. PiperOrigin-RevId: 790989895 --- src/google/adk/models/anthropic_llm.py | 4 ++-- src/google/adk/models/google_llm.py | 4 ++-- src/google/adk/models/lite_llm.py | 4 ++-- tests/unittests/testing_utils.py | 5 +++-- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/google/adk/models/anthropic_llm.py b/src/google/adk/models/anthropic_llm.py index bd64e2c4..ae69a652 100644 --- a/src/google/adk/models/anthropic_llm.py +++ b/src/google/adk/models/anthropic_llm.py @@ -249,9 +249,9 @@ class Claude(BaseLlm): model: str = "claude-3-5-sonnet-v2@20241022" max_tokens: int = 8192 - @staticmethod + @classmethod @override - def supported_models() -> list[str]: + def supported_models(cls) -> list[str]: return [r"claude-3-.*", r"claude-.*-4.*"] @override diff --git a/src/google/adk/models/google_llm.py b/src/google/adk/models/google_llm.py index 50c820c1..a68af629 100644 --- a/src/google/adk/models/google_llm.py +++ b/src/google/adk/models/google_llm.py @@ -75,9 +75,9 @@ class Gemini(BaseLlm): ``` """ - @staticmethod + @classmethod @override - def supported_models() -> list[str]: + def supported_models(cls) -> list[str]: """Provides the list of supported models. Returns: diff --git a/src/google/adk/models/lite_llm.py b/src/google/adk/models/lite_llm.py index ddce6a73..7c78d6f1 100644 --- a/src/google/adk/models/lite_llm.py +++ b/src/google/adk/models/lite_llm.py @@ -848,9 +848,9 @@ class LiteLlm(BaseLlm): response = await self.llm_client.acompletion(**completion_args) yield _model_response_to_generate_content_response(response) - @staticmethod + @classmethod @override - def supported_models() -> list[str]: + def supported_models(cls) -> list[str]: """Provides the list of supported models. LiteLlm supports all models supported by litellm. We do not keep track of diff --git a/tests/unittests/testing_utils.py b/tests/unittests/testing_utils.py index 59cb7250..44e68b84 100644 --- a/tests/unittests/testing_utils.py +++ b/tests/unittests/testing_utils.py @@ -282,8 +282,9 @@ class MockModel(BaseLlm): return cls(responses=responses) - @staticmethod - def supported_models() -> list[str]: + @classmethod + @override + def supported_models(cls) -> list[str]: return ['mock'] def generate_content(