feat(agents): Add warning for duplicate sub-agent names

Co-authored-by: Shangjie Chen <deanchen@google.com>
PiperOrigin-RevId: 836409638
This commit is contained in:
Shangjie Chen
2025-11-24 16:48:45 -08:00
committed by Copybara-Service
parent 4eb2a11403
commit 728abe4d81
2 changed files with 149 additions and 0 deletions
+42
View File
@@ -15,6 +15,7 @@
from __future__ import annotations
import inspect
import logging
from typing import Any
from typing import AsyncGenerator
from typing import Awaitable
@@ -49,6 +50,8 @@ from .callback_context import CallbackContext
if TYPE_CHECKING:
from .invocation_context import InvocationContext
logger = logging.getLogger('google_adk.' + __name__)
_SingleAgentCallback: TypeAlias = Callable[
[CallbackContext],
Union[Awaitable[Optional[types.Content]], Optional[types.Content]],
@@ -563,6 +566,45 @@ class BaseAgent(BaseModel):
)
return value
@field_validator('sub_agents', mode='after')
@classmethod
def validate_sub_agents_unique_names(
cls, value: list[BaseAgent]
) -> list[BaseAgent]:
"""Validates that all sub-agents have unique names.
Args:
value: The list of sub-agents to validate.
Returns:
The validated list of sub-agents.
"""
if not value:
return value
seen_names: set[str] = set()
duplicates: set[str] = set()
for sub_agent in value:
name = sub_agent.name
if name in seen_names:
duplicates.add(name)
else:
seen_names.add(name)
if duplicates:
duplicate_names_str = ', '.join(
f'`{name}`' for name in sorted(duplicates)
)
logger.warning(
'Found duplicate sub-agent names: %s. '
'All sub-agents must have unique names.',
duplicate_names_str,
)
return value
def __set_parent_agent_for_sub_agents(self) -> BaseAgent:
for sub_agent in self.sub_agents:
if sub_agent.parent_agent is not None: