mirror of
https://github.com/encounter/adk-python.git
synced 2026-07-09 18:19:28 -07:00
fix: Conditionally preserve function call IDs in LLM requests
Function call and response IDs generated by ADK are now preserved in the LLM request contents when the agent is using a Gemini model with `use_interactions_api` enabled Close #4381 Co-authored-by: George Weale <gweale@google.com> PiperOrigin-RevId: 867675945
This commit is contained in:
committed by
Copybara-Service
parent
64a44c2897
commit
663cb75b32
@@ -19,6 +19,7 @@ from google.adk.flows.llm_flows import contents
|
||||
from google.adk.flows.llm_flows.contents import request_processor
|
||||
from google.adk.flows.llm_flows.functions import REQUEST_CONFIRMATION_FUNCTION_CALL_NAME
|
||||
from google.adk.flows.llm_flows.functions import REQUEST_EUC_FUNCTION_CALL_NAME
|
||||
from google.adk.models.google_llm import Gemini
|
||||
from google.adk.models.llm_request import LlmRequest
|
||||
from google.genai import types
|
||||
import pytest
|
||||
@@ -931,3 +932,139 @@ async def test_function_response_with_thought_not_filtered():
|
||||
fr_parts = [p for p in fr_content.parts if p.function_response]
|
||||
assert len(fr_parts) == 1
|
||||
assert fr_parts[0].function_response.name == "calc_tool"
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_adk_function_call_ids_are_stripped_for_non_interactions_model():
|
||||
"""Test ADK generated ids are removed for non-interactions requests."""
|
||||
agent = Agent(model="gemini-2.5-flash", name="test_agent")
|
||||
llm_request = LlmRequest(model="gemini-2.5-flash")
|
||||
invocation_context = await testing_utils.create_invocation_context(
|
||||
agent=agent
|
||||
)
|
||||
|
||||
function_call_id = "adk-test-call-id"
|
||||
events = [
|
||||
Event(
|
||||
invocation_id="inv1",
|
||||
author="user",
|
||||
content=types.UserContent("Call the tool"),
|
||||
),
|
||||
Event(
|
||||
invocation_id="inv2",
|
||||
author="test_agent",
|
||||
content=types.Content(
|
||||
role="model",
|
||||
parts=[
|
||||
types.Part(
|
||||
function_call=types.FunctionCall(
|
||||
id=function_call_id,
|
||||
name="test_tool",
|
||||
args={"x": 1},
|
||||
)
|
||||
)
|
||||
],
|
||||
),
|
||||
),
|
||||
Event(
|
||||
invocation_id="inv3",
|
||||
author="test_agent",
|
||||
content=types.Content(
|
||||
role="user",
|
||||
parts=[
|
||||
types.Part(
|
||||
function_response=types.FunctionResponse(
|
||||
id=function_call_id,
|
||||
name="test_tool",
|
||||
response={"result": 2},
|
||||
)
|
||||
)
|
||||
],
|
||||
),
|
||||
),
|
||||
]
|
||||
invocation_context.session.events = events
|
||||
|
||||
async for _ in contents.request_processor.run_async(
|
||||
invocation_context, llm_request
|
||||
):
|
||||
pass
|
||||
|
||||
model_fc_part = llm_request.contents[1].parts[0]
|
||||
assert model_fc_part.function_call is not None
|
||||
assert model_fc_part.function_call.id is None
|
||||
|
||||
user_fr_part = llm_request.contents[2].parts[0]
|
||||
assert user_fr_part.function_response is not None
|
||||
assert user_fr_part.function_response.id is None
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_adk_function_call_ids_preserved_for_interactions_model():
|
||||
"""Test ADK generated ids are preserved for interactions requests."""
|
||||
agent = Agent(
|
||||
model=Gemini(
|
||||
model="gemini-2.5-flash",
|
||||
use_interactions_api=True,
|
||||
),
|
||||
name="test_agent",
|
||||
)
|
||||
llm_request = LlmRequest(model="gemini-2.5-flash")
|
||||
invocation_context = await testing_utils.create_invocation_context(
|
||||
agent=agent
|
||||
)
|
||||
|
||||
function_call_id = "adk-test-call-id"
|
||||
events = [
|
||||
Event(
|
||||
invocation_id="inv1",
|
||||
author="user",
|
||||
content=types.UserContent("Call the tool"),
|
||||
),
|
||||
Event(
|
||||
invocation_id="inv2",
|
||||
author="test_agent",
|
||||
content=types.Content(
|
||||
role="model",
|
||||
parts=[
|
||||
types.Part(
|
||||
function_call=types.FunctionCall(
|
||||
id=function_call_id,
|
||||
name="test_tool",
|
||||
args={"x": 1},
|
||||
)
|
||||
)
|
||||
],
|
||||
),
|
||||
),
|
||||
Event(
|
||||
invocation_id="inv3",
|
||||
author="test_agent",
|
||||
content=types.Content(
|
||||
role="user",
|
||||
parts=[
|
||||
types.Part(
|
||||
function_response=types.FunctionResponse(
|
||||
id=function_call_id,
|
||||
name="test_tool",
|
||||
response={"result": 2},
|
||||
)
|
||||
)
|
||||
],
|
||||
),
|
||||
),
|
||||
]
|
||||
invocation_context.session.events = events
|
||||
|
||||
async for _ in contents.request_processor.run_async(
|
||||
invocation_context, llm_request
|
||||
):
|
||||
pass
|
||||
|
||||
model_fc_part = llm_request.contents[1].parts[0]
|
||||
assert model_fc_part.function_call is not None
|
||||
assert model_fc_part.function_call.id == function_call_id
|
||||
|
||||
user_fr_part = llm_request.contents[2].parts[0]
|
||||
assert user_fr_part.function_response is not None
|
||||
assert user_fr_part.function_response.id == function_call_id
|
||||
|
||||
Reference in New Issue
Block a user