encounter/adk-python
0
0
Fork 0
mirror of https://github.com/encounter/adk-python.git synced 2026-07-09 18:19:28 -07:00
Code Issues Packages Projects Releases Wiki Activity

chore: Avoid mutable default arguments in local_eval_service and runners

Browse Source 
Changed default values for `session_service`, `artifact_service`, and `run_config` from instances of mutable classes to `None`. Instances are now created within the function body if the argument is not provided, preventing unexpected shared state across function calls.

PiperOrigin-RevId: 804624564
This commit is contained in:
Google Team Member
2025-09-08 16:11:24 -07:00
committed by Copybara-Service
parent d56dd08072
commit 64f11a6a67
3 changed files with 9 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/google/adk/evaluation/local_eval_service.py
+3 -8
View File
@@ -68,19 +68,14 @@ class LocalEvalService(BaseEvalService):
self,
root_agent: BaseAgent,
eval_sets_manager: EvalSetsManager,
metric_evaluator_registry: Optional[MetricEvaluatorRegistry] = None,
session_service: Optional[BaseSessionService] = None,
artifact_service: Optional[BaseArtifactService] = None,
metric_evaluator_registry: MetricEvaluatorRegistry = DEFAULT_METRIC_EVALUATOR_REGISTRY,
session_service: BaseSessionService = InMemorySessionService(),
artifact_service: BaseArtifactService = InMemoryArtifactService(),
eval_set_results_manager: Optional[EvalSetResultsManager] = None,
session_id_supplier: Callable[[], str] = _get_session_id,
):
self._root_agent = root_agent
self._eval_sets_manager = eval_sets_manager
metric_evaluator_registry = (
metric_evaluator_registry or DEFAULT_METRIC_EVALUATOR_REGISTRY
)
session_service = session_service or InMemorySessionService()
artifact_service = artifact_service or InMemoryArtifactService()
self._metric_evaluator_registry = metric_evaluator_registry
self._session_service = session_service
self._artifact_service = artifact_service