encounter/adk-python
0
0
Fork 0
mirror of https://github.com/encounter/adk-python.git synced 2026-07-09 18:19:28 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: Include list of skills in every message and remove list_skills tool from system instruction

Browse Source 
The list_skills method is not for model tool listing, but for giving the developer flexibility to load the skill name/description at runtime (from discussion in go/orcas-rfc-555)

Co-authored-by: Kathy Wu <wukathy@google.com>
PiperOrigin-RevId: 871406905
This commit is contained in:
Kathy Wu
2026-02-17 11:12:11 -08:00
committed by Copybara-Service
parent ea034877ec
commit 4285f852d5
2 changed files with 36 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unittests/tools/test_skill_toolset.py
+21
View File
@@ -14,6 +14,7 @@
from unittest import mock
from google.adk.models import llm_request as llm_request_model
from google.adk.skills import models
from google.adk.tools import skill_toolset
from google.adk.tools import tool_context
@@ -249,3 +250,23 @@ async def test_load_resource_run_async(
tool = skill_toolset.LoadSkillResourceTool(toolset)
result = await tool.run_async(args=args, tool_context=tool_context_instance)
assert result == expected_result
@pytest.mark.asyncio
async def test_process_llm_request(
mock_skill1, mock_skill2, tool_context_instance
):
toolset = skill_toolset.SkillToolset([mock_skill1, mock_skill2])
llm_req = mock.create_autospec(llm_request_model.LlmRequest, instance=True)
await toolset.process_llm_request(
tool_context=tool_context_instance, llm_request=llm_req
)
llm_req.append_instructions.assert_called_once()
args, _ = llm_req.append_instructions.call_args
instructions = args[0]
assert len(instructions) == 1
assert "<available_skills>" in instructions[0]
assert "skill1" in instructions[0]
assert "skill2" in instructions[0]