From 214986ebeb53b2ef34c8aa37cd6403106de82c1b Mon Sep 17 00:00:00 2001 From: "Xiang (Sean) Zhou" Date: Mon, 13 Oct 2025 11:51:31 -0700 Subject: [PATCH] chore: Adjust the instruction about default model PiperOrigin-RevId: 818765464 --- .../instruction_embedded.template | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/contributing/samples/adk_agent_builder_assistant/instruction_embedded.template b/contributing/samples/adk_agent_builder_assistant/instruction_embedded.template index b384d617..00c9aad6 100644 --- a/contributing/samples/adk_agent_builder_assistant/instruction_embedded.template +++ b/contributing/samples/adk_agent_builder_assistant/instruction_embedded.template @@ -64,7 +64,9 @@ Always reference this schema when creating configurations to ensure compliance. - **MANDATORY CONFIRMATION**: Say "Please confirm what model you want to use" - do NOT assume or suggest defaults - **EXAMPLES**: "gemini-2.5-flash", "gemini-2.5-pro", etc. - **RATIONALE**: Only LlmAgent requires model specification; workflow agents do not -- **DEFAULT ONLY**: Use "{default_model}" only if user explicitly says "use default" or similar +- **DEFAULT MODEL**: If user says "use default" or "proceed with default model", use: {default_model} + * This is the actual model name, NOT the literal string "default" + * The default model for this session is: {default_model} - **WORKFLOW**: Complete all Discovery steps (including this model selection) → Then proceed to Design Phase with model already chosen ### 2. Design Phase @@ -369,7 +371,7 @@ def log_tool_result(tool: BaseTool, args: Dict[str, Any], context: ToolContext, **ADK AgentConfig Schema Compliance:** - Always reference the embedded ADK AgentConfig schema to verify field requirements - **MODEL FIELD RULES**: - * **LlmAgent**: `model` field is REQUIRED (unless inherited from ancestor) - Ask user for preference only when LlmAgent is needed, use "{default_model}" if not specified + * **LlmAgent**: `model` field is REQUIRED (unless inherited from ancestor) - Ask user for preference only when LlmAgent is needed, use {default_model} if user says to use default * **Workflow Agents**: `model` field is FORBIDDEN - Remove model field entirely for Sequential/Parallel/Loop agents - Optional fields: description, instruction, tools, sub_agents as defined in ADK AgentConfig schema