From afb341d065ede75e00b7e787d8d9803613cbcf5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mart=C3=AD=20Bol=C3=ADvar?= Date: Thu, 1 Jun 2023 14:48:09 -0700 Subject: [PATCH] doc: west: fix group filter documentation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The docs about how this works are inconsistent. Fix it by adjusting the docs so they all match the implementation and are consistent with each other. Earlier in this page: Manifest files which appear earlier in the import order have higher precedence and are therefore concatenated later into the final group-filter. Where for "import order" we have: Importing is done in this order: 1. Manifests from self-import are imported first. 2. The top-level manifest file’s definitions are handled next. 3. Manifests from import-1, …, import-N, are imported in that order. Therefore, "filter-1 to filter-N" is the wrong precedence order. It should be "filter-N to filter-1", so that filter-N is lower precedence than filter-1. That is consistent with import-1 happening before import-N. Signed-off-by: Martí Bolívar --- doc/develop/west/manifest.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/develop/west/manifest.rst b/doc/develop/west/manifest.rst index 11f45ac0b6..2253565aee 100644 --- a/doc/develop/west/manifest.rst +++ b/doc/develop/west/manifest.rst @@ -2099,8 +2099,8 @@ In other words, let: - the submanifests resolved from ``import-1`` through ``import-N`` have group filters ``filter-1`` through ``filter-N`` respectively -The final resolved ``group-filter`` value is then ``filter1 + filter-2 + ... + -filter-N + top-filter + self-filter``, where ``+`` here refers to list +The final resolved ``group-filter`` value is then ``filterN + ... + filter-2 + +filter-1 + top-filter + self-filter``, where ``+`` here refers to list concatenation. .. important::