Djalal Harouni
84dd59b51c
sd-rtnl: add missing IFLA_INET6_ADDR_GEN_MODE definition
...
Add missing IFLA_INET6_ADDR_GEN_MODE definition so we can build with
kernel headers < 3.17
2015-02-14 00:17:47 +01:00
Lennart Poettering
c74f883c6f
bus-proxy: ECONNRESET/ENOTCONN can hit us on every step, hence handle it on every step
2015-02-13 17:18:36 +01:00
Lennart Poettering
5569b33a8c
bus-proxy: a few simplifications
2015-02-13 17:18:36 +01:00
Lennart Poettering
e044970a29
sd-bus: initialize a few structs at time or declaration
2015-02-13 17:18:36 +01:00
Lennart Poettering
95eb099fa8
bus-proxy: close each connection fd only once
...
After passing the fds over to the sd_bus object, we should forget them,
so that we don't close them a second time when the object goes away.
2015-02-13 17:18:36 +01:00
Lennart Poettering
557b5d4a94
bus-proxy: also consider ENOTCONN a clean termination condition
...
Sometimes, when we try to reply to messages we don't check return
values. This means we might miss a ECONNRESET, and will get a ENOTCONN
on next command. Treat both the same hence.
2015-02-13 17:18:35 +01:00
Tom Gundersen
a8ba6cd15d
exit-on-idle: only exit if actually idle
...
sd_event_wait() returning 0 usually means that it timed out, which means it must
have been idle. However, sd_event_wait() may return 0 in case an event was triggered
but it turned out there was nothing to do. Make the check for idle explicit to avoid
this edge-case.
2015-02-13 16:32:02 +01:00
Lennart Poettering
5f6cb09127
bus-proxy: whenever we cannot forward a message, report this back to caller, but don't exit
...
Errors like EPERM from the kernel should certainly not be reason to
exit. Let's try to be defensive here, and try to continue on most send
errors, but possibly tell the sender about it.
2015-02-13 15:49:51 +01:00
Lennart Poettering
1433efd219
bus-proxy: rename synthetic_reply_return_strv() to synthetic_reply_method_return_strv()
...
That way it matches more closely the nomenclature of our other
success reply calls.
2015-02-13 15:49:51 +01:00
Lennart Poettering
418e4cb07d
bus-proxy: minor simplifications
2015-02-13 15:49:51 +01:00
Lennart Poettering
07a0d22f9e
sd-bus: export sd_bus_error_set_errnofv()
2015-02-13 15:49:51 +01:00
Lennart Poettering
61adca52f6
bus-proxy: no need to negate error codes, log_error_errno() already does it
2015-02-13 15:49:51 +01:00
Lennart Poettering
1140e15410
bus-proxy: tell Coverity we don't care about these return values
2015-02-13 15:49:51 +01:00
Lennart Poettering
d27efd9384
bus-proxy: we don't pointlessly abbreviate function names
...
It's fine to abbreviate local variables, but it's not OK to abbreviate
function names needlessly. This is not an excercise in writing
unreadable code.
2015-02-13 15:49:51 +01:00
Daniel Mack
403193f54b
sd-bus: sync kdbus.h (ABI break)
...
Another slice logic rework in kdbus made KDBUS_ITEM_PAYLOAD_OFF items
relative to the message header again. Catch up with that in sd-bus.
2015-02-13 14:55:51 +01:00
Thomas Hindoe Paaboel Andersen
0a6f50c0af
include <poll.h> instead of <sys/poll.h>
...
include-what-you-use automatically does this and it makes finding
unnecessary harder to spot. The only content of poll.h is a include
of sys/poll.h so should be harmless.
2015-02-12 20:47:38 +01:00
Thomas Hindoe Paaboel Andersen
c1ff5570f4
Add missing includes in header files
...
This fixes various issues found by globally reordering the include
sections of all .c files.
2015-02-12 20:44:32 +01:00
Thomas Hindoe Paaboel Andersen
76f282c636
test-util: remove superfluous const
2015-02-12 20:44:11 +01:00
Thomas Hindoe Paaboel Andersen
8744505aae
remove unused variable
2015-02-12 20:44:06 +01:00
Lennart Poettering
cf1d0302ae
exec: also evaluate working_directory_missing_ok when not applying chroots
2015-02-12 18:58:43 +01:00
Tom Gundersen
5c3072eab6
networkd: explicitly enable/disable ipv6ll addresses
...
The kernel does not like getting an empty container, so just always pass the parameter, even if
it is the default.
2015-02-12 14:23:02 +01:00
Lennart Poettering
424d110ac0
hwdb: adjust --help text to be more like other --help texts
...
Fix capitalization, indentation, make sure we support --version, and
similar.
2015-02-12 13:17:08 +01:00
Lennart Poettering
c2cc6b9aef
core: disarm shutdown watchdog if we fail to set timeout
...
Better safe than sorry, if drivers are stupid, and reset immediately on
device closing if the timeout could not be initialized.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=777735
2015-02-12 12:28:48 +01:00
Lennart Poettering
4c08c8242a
core: don't fail to run services in --user instances if $HOME is missing
...
Otherwise we cannot even invoke systemd-exit.service anymore, thus not
even exit.
https://bugs.freedesktop.org/show_bug.cgi?id=83100
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759320
2015-02-12 12:21:16 +01:00
Lennart Poettering
a38d99451f
Revert "tree-wide: Always use recvmsg with MSG_CMSG_CLOEXEC"
...
This reverts commit d6d810fbf8 .
It's apparently not OK to pass MSG_CMSG_CLOEXEC to recvmsg() of raw
sockets.
2015-02-12 11:45:39 +01:00