diff --git a/src/core/dbus-manager.c b/src/core/dbus-manager.c index 242a662bca..6d2ed62f94 100644 --- a/src/core/dbus-manager.c +++ b/src/core/dbus-manager.c @@ -1530,7 +1530,7 @@ static void log_caller(sd_bus_message *message, Manager *manager, const char *me log_info("%s requested from client PID " PID_FMT "%s%s%s%s%s%s...", method, pid, comm ? " ('" : "", strempty(comm), comm ? "')" : "", - caller ? " (unit " : "", caller ? caller->id : NULL, caller ? ")" : ""); + caller ? " (unit " : "", caller ? caller->id : "", caller ? ")" : ""); } static int method_reload(sd_bus_message *message, void *userdata, sd_bus_error *error) { diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c index f2dc02c0c4..533c09f72e 100644 --- a/src/core/load-fragment.c +++ b/src/core/load-fragment.c @@ -202,7 +202,7 @@ bool contains_instance_specifier_superset(const char *s) { return false; /* %i, %n and %N all expand to the instance or a superset of it. */ - for (; p < q; p++) { + for (; p < q; p++) if (*p == '%') percent = !percent; else if (percent) { @@ -210,7 +210,6 @@ bool contains_instance_specifier_superset(const char *s) { return true; percent = false; } - } return false; } @@ -4382,15 +4381,13 @@ int config_parse_io_limit( } if (!l) { - CGroupIOLimitType ttype; - l = new0(CGroupIODeviceLimit, 1); if (!l) return log_oom(); l->path = TAKE_PTR(resolved); - for (ttype = 0; ttype < _CGROUP_IO_LIMIT_TYPE_MAX; ttype++) - l->limits[ttype] = cgroup_io_limit_defaults[ttype]; + for (CGroupIOLimitType i = 0; i < _CGROUP_IO_LIMIT_TYPE_MAX; i++) + l->limits[i] = cgroup_io_limit_defaults[i]; LIST_PREPEND(device_limits, c->io_device_limits, l); }