From 5515f2169cb5980996044eabb5f1b35e00fd81eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 20 Sep 2022 20:41:31 +0200 Subject: [PATCH] networkctl: use "-" for empty fields This looks nicer. Some fields were already using "-" as fallback, e.g. Speed, so this makes things more consistent too. --- src/network/networkctl.c | 2 +- test/test-network/systemd-networkd-tests.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/network/networkctl.c b/src/network/networkctl.c index c489ccbf4e..f69cde7e4d 100644 --- a/src/network/networkctl.c +++ b/src/network/networkctl.c @@ -817,7 +817,7 @@ static int list_links(int argc, char *argv[], void *userdata) { table_set_width(table, 0); table_set_header(table, arg_legend); - if (table_set_empty_string(table, "n/a") < 0) + if (table_set_empty_string(table, "-") < 0) return log_oom(); assert_se(cell = table_get_cell(table, 0, 0)); diff --git a/test/test-network/systemd-networkd-tests.py b/test/test-network/systemd-networkd-tests.py index 2f638d158a..b90a07e22b 100755 --- a/test/test-network/systemd-networkd-tests.py +++ b/test/test-network/systemd-networkd-tests.py @@ -1047,8 +1047,8 @@ class NetworkctlTests(unittest.TestCase, Utilities): output = check_output(*networkctl_cmd, '-n', '0', 'status', 'lo', env=env) print(output) - self.assertRegex(output, r'Link File: n/a') - self.assertRegex(output, r'Network File: n/a') + self.assertRegex(output, r'Link File: -') + self.assertRegex(output, r'Network File: -') def test_delete_links(self): copy_network_unit('11-dummy.netdev', '11-dummy.network',