diff --git a/src/basic/string-util.c b/src/basic/string-util.c index 854cf963ac..7329bfacdf 100644 --- a/src/basic/string-util.c +++ b/src/basic/string-util.c @@ -627,14 +627,23 @@ char* strshorten(char *s, size_t l) { } int strgrowpad0(char **s, size_t l) { + size_t sz; + assert(s); + if (*s) { + sz = strlen(*s) + 1; + if (sz >= l) /* never shrink */ + return 0; + } else + sz = 0; + char *q = realloc(*s, l); if (!q) return -ENOMEM; + *s = q; - size_t sz = strlen(*s); memzero(*s + sz, l - sz); return 0; } diff --git a/src/partition/repart.c b/src/partition/repart.c index 2cc4881ada..da7cbe1152 100644 --- a/src/partition/repart.c +++ b/src/partition/repart.c @@ -4159,6 +4159,9 @@ static int partition_format_verity_sig(Context *context, Partition *p) { if (r < 0) return log_error_errno(r, "Failed to format verity signature JSON object: %m"); + if (strlen(text)+1 > p->new_size) + return log_error_errno(SYNTHETIC_ERRNO(E2BIG), "Verity signature too long for partition: %m"); + r = strgrowpad0(&text, p->new_size); if (r < 0) return log_error_errno(r, "Failed to pad string to %s", FORMAT_BYTES(p->new_size));