dasharo/slimbootloader
0
0
Fork 0
mirror of https://github.com/Dasharo/slimbootloader.git synced 2026-06-14 04:16:15 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: [Common] Fix Coverity issues

Browse Source 
Fixed resource leak. Free resource prior to return (CWE 404)

Signed-off-by: Kevin Tsai <kevin.tsai@intel.com>
This commit is contained in:
Kevin Tsai
2023-08-01 17:17:02 -07:00
committed by Guo Dong
parent 971048cfc1
commit 74e12f7708
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PayloadPkg/FirmwareUpdate/FirmwareUpdate.c
+1
View File
@@ -1452,6 +1452,7 @@ InitFirmwareUpdate (
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
// //
// Error condition // Error condition
FreePool(CapsuleImage);
return Status; return Status;
} }
PayloadPkg/FirmwareUpdate/FirmwareUpdateHelper.c
+2
View File
@@ -577,6 +577,7 @@ UpdateSystemFirmware (
Status = VerifyFwStruct (ImageHdr); Status = VerifyFwStruct (ImageHdr);
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, " VerifyFwStruct failed with Status = 0x%x\n", Status)); DEBUG ((DEBUG_ERROR, " VerifyFwStruct failed with Status = 0x%x\n", Status));
FreePool(UpdatePartition);
return Status; return Status;
} }
@@ -655,6 +656,7 @@ UpdateSingleComponent (
DEBUG ((DEBUG_ERROR, "Updating component %4a failed with status = %r\n", (CHAR8 *)&CompName, Status)); DEBUG ((DEBUG_ERROR, "Updating component %4a failed with status = %r\n", (CHAR8 *)&CompName, Status));
} }
FreePool(UpdatePartition);
return Status; return Status;
} }