From 712cb1e867b42bd86ba94ec3ebb657555e27bb12 Mon Sep 17 00:00:00 2001 From: Bruno Achauer Date: Fri, 18 Oct 2024 08:37:26 +0200 Subject: [PATCH] fix: [common] Fix Coverity issue Check fdt_getprop_by_offset() return value for NULL pointer (like all other callers) to prevent a Coverity issue (CWE-476). Signed-off-by: Bruno Achauer --- MdePkg/Library/BaseFdtLib/libfdt/libfdt/fdt_overlay.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdePkg/Library/BaseFdtLib/libfdt/libfdt/fdt_overlay.c b/MdePkg/Library/BaseFdtLib/libfdt/libfdt/fdt_overlay.c index 7a34fa65..56e82dc1 100644 --- a/MdePkg/Library/BaseFdtLib/libfdt/libfdt/fdt_overlay.c +++ b/MdePkg/Library/BaseFdtLib/libfdt/libfdt/fdt_overlay.c @@ -557,6 +557,8 @@ static int overlay_apply_node(void *fdt, int target, return -FDT_ERR_INTERNAL; if (prop_len < 0) return prop_len; + if (!prop) + return -FDT_ERR_INTERNAL; ret = fdt_setprop(fdt, target, name, prop, prop_len); if (ret)