dasharo/skiboot
0
0
Fork 0
mirror of https://github.com/Dasharo/skiboot.git synced 2026-03-06 14:50:44 -08:00
Code Issues Packages Projects Releases Wiki Activity

hdata: Make sure reserved node name starts with "ibm, "

Browse Source 
HDAT does not provide consistent label format for reserved memory label.
Few starts with "ibm," while few other starts with component name.

Lets make sure all the reserved node name starts with "ibm,".

Reported-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
This commit is contained in:
Vasant Hegde
2018-09-07 10:46:55 +05:30
committed by Stewart Smith
parent 70a7a3fdfa
commit 50d508c3cd
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hdata/memory.c
+9 -2
View File
@@ -567,6 +567,8 @@ static struct dt_node *dt_hb_reserves;
static struct dt_node *add_hb_reserve_node(const char *name, u64 start, u64 end)
{
/* label size + "ibm," + NULL */
char node_name[HB_RESERVE_MEM_LABEL_SIZE + 5] = { 0 };
struct dt_node *node, *hb;
if (!dt_hb_reserves) {
@@ -580,10 +582,15 @@ static struct dt_node *add_hb_reserve_node(const char *name, u64 start, u64 end)
dt_add_property_cells(dt_hb_reserves, "#address-cells", 2);
}
node = dt_new_addr(dt_hb_reserves, name, start);
/* Add "ibm," to reserved node name */
if (strncasecmp(name, "ibm", 3))
snprintf(node_name, 5, "ibm,");
strcat(node_name, name);
node = dt_new_addr(dt_hb_reserves, node_name, start);
if (!node) {
prerror("Unable to create node for %s@%llx\n",
name, (unsigned long long) start);
node_name, (unsigned long long) start);
return NULL;
}