From e104e7cd57fc97fc2d73ef7b3b7d1b5f1d758613 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Kr=C3=B3l?= Date: Mon, 11 Dec 2023 12:41:23 +0100 Subject: [PATCH] dug4: pre-commit fixes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Piotr Król --- .codespellx | 2 + dasharo_roadmap.md | 132 +++++++++--------- dts_status.md | 34 ++--- duc_introduction.md | 27 ++-- dug_4.md | 56 ++++---- dug_4/diagrams/dasharo_forks.py | 2 +- dug_4/diagrams/dasharo_issues.py | 2 +- ...sharo_issues_resolution_progress.vega-lite | 1 - dug_4/diagrams/dasharo_users.py | 1 - dug_4/diagrams/dts_issues.py | 2 +- 10 files changed, 133 insertions(+), 126 deletions(-) diff --git a/.codespellx b/.codespellx index 14e0acc..cc23223 100644 --- a/.codespellx +++ b/.codespellx @@ -1,2 +1,4 @@ - - "PCI bridge: Synopsys, Inc. DWC_usb3 (rev 01)" + - "PCI bridge: Synopsys, Inc. DWC_usb3 / PCIe bridge (rev 01)" +- **Chipsec and HSI Checks Integration**: Enhance DCU by incorporating Chipsec + for in-depth security analysis and Host Security ID (HSI) checks, along with diff --git a/dasharo_roadmap.md b/dasharo_roadmap.md index c55396d..8c9af1f 100644 --- a/dasharo_roadmap.md +++ b/dasharo_roadmap.md @@ -21,13 +21,13 @@ contact the Dasharo Team directly._ --- -# From OST2 to Dasharo Support Pacakage +# From OST2 to Dasharo Support Package .center.image-85[![](/img/ost2_to_dasharo_packages.svg)] ??? -* How to improve that infromation? +* How to improve that information? * Maybe focus more on OST2 and tracking deliverables for it. --- @@ -39,7 +39,7 @@ contact the Dasharo Team directly._ ] * How we qualify platforms for Dasharo Community Support? -* Buisness goals alignment with 3mdeb. +* Business goals alignment with 3mdeb. * Synergy with other projects e.g. TrenchBoot. * Above stages very roughly map to real work/tasks performed by team. @@ -50,8 +50,8 @@ contact the Dasharo Team directly._ * This process shows how flow look like for new platforms, already supported platforms typically get through Validation/Release cycle. * TODO: - - define publicly visible deliverables of each phase - - document frameworks and tools on which given release will be based on + - define publicly visible deliverables of each phase + - document frameworks and tools on which given release will be based on * We need more focused slides, saying precisely what we plan for given release, what features what will be validated etc. @@ -59,8 +59,8 @@ contact the Dasharo Team directly._ * Customer stories? * Dasharo Team release performance metrics * Other 3mdeb roadmaps - - EST - - UEFI Secure Boot focus - OSFV + - EST + - UEFI Secure Boot focus - OSFV * Features matrix concept * Inform about our priorities @@ -88,8 +88,8 @@ contact the Dasharo Team directly._ Notes for expanding this part of the roadmap: - new potential vendors/products: Intel Simics, AMD SimNow - new potential release types to be supported for QEMU Q35 target - - Dasharo (coreboot+UEFI) - - Xen target (XCP-ng) although I'm not sure how how much firmware would be + - Dasharo (coreboot+UEFI) + - Xen target (XCP-ng) although I'm not sure how how much firmware would be different, there is definitely stuff Xen-specific in OvmfPkg - show milestone on github @@ -100,14 +100,14 @@ Notes for expanding this part of the roadmap: - shift left firmware development - new potential vendors/products: Intel Simics, AMD SimNow - new potential release types to be supported for QEMU Q35 target - - Dasharo (coreboot+UEFI) - - Xen target (XCP-ng) although I'm not sure how how much firmware would be + - Dasharo (coreboot+UEFI) + - Xen target (XCP-ng) although I'm not sure how how much firmware would be different, there is definitely stuff Xen-specific in OvmfPkg - firmware will play role in Confidential VMs - references: - - [MSFT talk about CVM](https://youtu.be/2GxaBAS2_no) - - MSFT: DCasv5 and ECasv5 - - [Edgeless Systems](https://www.edgeless.systems/blog/how-confidential-computing-and-ai-fit-together/) + - [MSFT talk about CVM](https://youtu.be/2GxaBAS2_no) + - MSFT: DCasv5 and ECasv5 + - [Edgeless Systems](https://www.edgeless.systems/blog/how-confidential-computing-and-ai-fit-together/) --- @@ -164,11 +164,11 @@ but have no actual backend hooked up: ??? - DUG#3: - - (NEW) PC Engines apu3 planned for Q4'23 -- DUG#4: - - (CHANGED) PC Engines apu3 planned for Q4'23 - - release date changed to Q1'23 (+1) - - add support for apu2 and apu6 + - (NEW) PC Engines apu3 planned for Q4'23 +- DUG#4: + - (CHANGED) PC Engines apu3 planned for Q4'23 + - release date changed to Q1'23 (+1) + - add support for apu2 and apu6 - DUG#3: (NEW) Protectli VP4670 planned for Q2'24 --- @@ -186,9 +186,9 @@ but have no actual backend hooked up: * Legacy boot is deprecated by Intel since 11th Gen * To make it work with Dasharo(coreboot+UEFI) we have to complete TB AEM P5 -- DUG#3: - - (CHANGED) Protectli VP4670 planned for Q2'24 - - release date changed to Q3'23 (+1) +- DUG#3: + - (CHANGED) Protectli VP4670 planned for Q2'24 + - release date changed to Q3'23 (+1) --- @@ -205,11 +205,11 @@ but have no actual backend hooked up: ??? -- DUG#3: - - (NEW) Novacustom NV4x Dasharo (coreboot+Heads) v0.9.0 planned for Q4'23 -- DUG#4: - - (CHANGED) Novacustom NV4x Dasharo (coreboot+Heads) v0.9.0 planned for Q4'23 - - release date changed to Q1'24 (+1) +- DUG#3: + - (NEW) Novacustom NV4x Dasharo (coreboot+Heads) v0.9.0 planned for Q4'23 +- DUG#4: + - (CHANGED) Novacustom NV4x Dasharo (coreboot+Heads) v0.9.0 planned for Q4'23 + - release date changed to Q1'24 (+1) --- @@ -225,10 +225,10 @@ Manufacturing Mode - Dasharo Porting Ready. ??? - DUG#3: - - (NEW) Lenovo M920Q planned for Q2'24 + - (NEW) Lenovo M920Q planned for Q2'24 - DUG#4: - - (CHANGED) Lenovo M920Q planned for Q2'24 - - release date changed to Q3'24 (+1) + - (CHANGED) Lenovo M920Q planned for Q2'24 + - release date changed to Q3'24 (+1) - progress regarding Lenovo ThinkCenter M700: https://github.com/Dasharo/coreboot/pull/121 @@ -251,15 +251,15 @@ Manufacturing Mode - Dasharo Porting Ready. - (CHANGED) Dell T1650 v0.1.0 planned for Q3'23 - release date changed to Q1'24 (+2) - DUG#3 - - (CHANGED) Dell OptiPlex 7010/9010 v0.1.0 planned for Q4'23 - - release type changed to DES - - (CHANGED) Dell T1650 v0.1.0 planned for Q1'24 - - release type changed to DES +- (CHANGED) Dell OptiPlex 7010/9010 v0.1.0 planned for Q4'23 + - release type changed to DES +- (CHANGED) Dell T1650 v0.1.0 planned for Q1'24 + - release type changed to DES - DUG#4 - - (CHANGED) Dell OptiPlex 7010/9010 v0.1.0 planned for Q4'23 - - release date changed to Q1'24 (+1) - - (CHANGED) Dell T1650 v0.1.0 planned for Q1'24 - - release date changed to Q3'24 (+2) +- (CHANGED) Dell OptiPlex 7010/9010 v0.1.0 planned for Q4'23 + - release date changed to Q1'24 (+1) +- (CHANGED) Dell T1650 v0.1.0 planned for Q1'24 + - release date changed to Q3'24 (+2) --- @@ -282,12 +282,12 @@ Community Release date changed because of PC Engines and NovaCustom. - (CHANGED) MSI Z690-A v1.2.0 planned for Q4'23 - release date changed to Q1'24 (+1) - DUG#3 - - (RELEASED) MSI Z690-A v1.1.2 planned for Q3'23 - - MSI Z690-A v1.1.3 release planned for Q4'23 - - MSI Z690-A v1.2.0 planned for Q1'24 + - (RELEASED) MSI Z690-A v1.1.2 planned for Q3'23 + - MSI Z690-A v1.1.3 release planned for Q4'23 + - MSI Z690-A v1.2.0 planned for Q1'24 - DUG#4 - - (CHANGED) MSI Z690-A v1.2.0 planned for Q1'24 - - release date changed to Q2'24 (+1) + - (CHANGED) MSI Z690-A v1.2.0 planned for Q1'24 + - release date changed to Q2'24 (+1) --- @@ -308,12 +308,12 @@ Community Release date changed because of PC Engines and NovaCustom. - (NEW) MSI Z790-A v0.9.1 planned for Q4'23 - MSI Z790-A v1.0.0 planned for Q1'24 - DUG#3 - - (RELEASED) MSI Z790-A v0.9.0 planned for Q3'23 - - MSI Z790-A v0.9.1 planned for Q4'23 - - MSI Z790-A v1.0.0 planned for Q1'24 + - (RELEASED) MSI Z790-A v0.9.0 planned for Q3'23 + - MSI Z790-A v0.9.1 planned for Q4'23 + - MSI Z790-A v1.0.0 planned for Q1'24 - DUG#4 - - (CHANGED) MSI Z790-A v1.0.0 planned for Q1'24 - - release date changed to Q2'24 (+1) + - (CHANGED) MSI Z790-A v1.0.0 planned for Q1'24 + - release date changed to Q2'24 (+1) --- @@ -330,11 +330,11 @@ Community Release date changed because of PC Engines and NovaCustom. ??? - DUG#3 - - (NEW) MSI Z790-A Dasharo (coreboot+Heads) v1.0.1 planned for Q2'24 + - (NEW) MSI Z790-A Dasharo (coreboot+Heads) v1.0.1 planned for Q2'24 - DUG#4 - - (CHANGED) MSI Z790-A Dasharo (coreboot+Heads) v0.9.0 planned for Q1'24 - - release date changed to Q1'24 (-1) - - version changed to v0.9.0 + - (CHANGED) MSI Z790-A Dasharo (coreboot+Heads) v0.9.0 planned for Q1'24 + - release date changed to Q1'24 (-1) + - version changed to v0.9.0 --- @@ -376,17 +376,17 @@ Community Release date changed because of PC Engines and NovaCustom. - release date changed to Q1'24 (+2) - RCS Talos II v0.7.0 planned for Q3'23 - DUG#3 - - (CHANGED) ASUS KGPE-D16 v0.5.0 planned for Q1'24 - - release type changed to DES - - release date changed to Q2'24 (+1) - - (RELEASED) RCS Talos II v0.7.0 planned for Q3'23 + - (CHANGED) ASUS KGPE-D16 v0.5.0 planned for Q1'24 + - release type changed to DES + - release date changed to Q2'24 (+1) + - (RELEASED) RCS Talos II v0.7.0 planned for Q3'23 - DUG#4: - - no response from Immunefi - - we have to cancel KGPE-D16 from roadmap at some point - - (CHANGED) ASUS KGPE-D16 v0.5.0 planned for Q2'24 - - release date changed to Q3'24 (+1) - - (NEW) RCS Talos II v0.8.0 planned for Q1'24 - - depends on agreeing on Heads commit on which we should inteagrate things, + - no response from Immunefi + - we have to cancel KGPE-D16 from roadmap at some point + - (CHANGED) ASUS KGPE-D16 v0.5.0 planned for Q2'24 + - release date changed to Q3'24 (+1) + - (NEW) RCS Talos II v0.8.0 planned for Q1'24 + - depends on agreeing on Heads commit on which we should inteagrate things, we already one month blocked because lack of decision --- @@ -407,11 +407,11 @@ Community Release date changed because of PC Engines and NovaCustom. - (CHANGED) Supermicro X11SSH-TF v0.1.0 planned for Q4'23 - release date changed to Q1'24 (+1) - DUG#3 - - (CHANGED) Supermicro X11SSH-TF v0.1.0 planned for Q1'24 - - release date changed to Q2'24 (+1) + - (CHANGED) Supermicro X11SSH-TF v0.1.0 planned for Q1'24 + - release date changed to Q2'24 (+1) - DUG#4 - - (CHANGED) Supermicro X11SSH-TF v0.1.0 planned for Q2'24 - - release type changed to DES + - (CHANGED) Supermicro X11SSH-TF v0.1.0 planned for Q2'24 + - release type changed to DES --- class: center, middle, intro diff --git a/dts_status.md b/dts_status.md index 002871a..81da273 100644 --- a/dts_status.md +++ b/dts_status.md @@ -24,13 +24,13 @@ class: center, middle, intro .center.image-99[![](/img/dts-logo.jpg)] * Set of tools and scripts running in minimal Linux environment - - https://docs.dasharo.com/dasharo-tools-suite/overview + - https://docs.dasharo.com/dasharo-tools-suite/overview * DRY: https://bit.ly/dasharo-tools-suite -* We continue slient releases: - - by silent we mean not announced in Dasharo Universe documentation, - - v1.2.8 - last stable release recommended for community, published on +* We continue silent releases: + - by silent we mean not announced in Dasharo Universe documentation, + - v1.2.8 - last stable release recommended for community, published on docs.dasharo.com, - - v1.2.9-v1.2.12 silent releases made as part of Dasharo Support Package + - v1.2.9-v1.2.12 silent releases made as part of Dasharo Support Package ??? @@ -42,29 +42,29 @@ class: center, middle, intro # DTS silent releases * **v1.2.9 - 2023-09-29** - * Added [Firmware Update + * Added [Firmware Update Mode](https://docs.dasharo.com/guides/firmware-update/#firmware-update-mode) integration, which speed up the process of Dasharo firmware update. - * Added efivars support and efivar utility to support FUM. - * Improved logging of DTS menu options to not throw redundant and confusing + * Added efivars support and efivar utility to support FUM. + * Improved logging of DTS menu options to not throw redundant and confusing logs e.g. from flashrom. - * Fixed problem with EC firmware using incorrect link. + * Fixed problem with EC firmware using incorrect link. * **v1.2.10 - 2023-10-17** - * Added [Dasharo Configuration Utility](https://github.com/Dasharo/dcu) which + * Added [Dasharo Configuration Utility](https://github.com/Dasharo/dcu) which allow to change logo displayed on boot and many more. More about that in dedicated presentation. - * Added SMMSTORE migration for NovaCustom laptops, so the Dasharo Setup settings + * Added SMMSTORE migration for NovaCustom laptops, so the Dasharo Setup settings are preserved after firmware update. - * Added CI/CD pipeline to generate signatures. + * Added CI/CD pipeline to generate signatures. --- # DTS silent releases * **v1.2.11 - 2023-10-31** - * Bumped supported firmware versions of NovaCustom to 1.5.1/1.7.1 + * Bumped supported firmware versions of NovaCustom to 1.5.1/1.7.1 * **v1.2.12 - 2023-11-03** - * Fix updating boards without Vboot slot B + * Fix updating boards without Vboot slot B * So far in 2023 we released seven DTS versions from v1.1.1 to v1.2.12. * We plan to continue improving DTS in 2024. @@ -74,9 +74,9 @@ class: center, middle, intro .center.image-80[![](/img/dts_issues_2023q4.png)] -* We have to improve issues tracking and resoltion. +* We have to improve issues tracking and resolution. * If you feel you found some problem please report it: - - https://github.com/Dasharo/dasharo-issues/issues + - https://github.com/Dasharo/dasharo-issues/issues --- @@ -106,7 +106,7 @@ class: center, middle, intro ??? * Other ideas - - automatic bug reporting from DTS + - automatic bug reporting from DTS --- diff --git a/duc_introduction.md b/duc_introduction.md index a7fd4fa..3014a06 100644 --- a/duc_introduction.md +++ b/duc_introduction.md @@ -10,8 +10,8 @@ class: center, middle, intro # Agenda -* Short Introduction to Dasharo Confgiuration Utility (DUC) -* Exploring Dasharo Confgiuration Utility v0.2.1 +* Short Introduction to Dasharo Configuration Utility (DUC) +* Exploring Dasharo Configuration Utility v0.2.1 * Q&A ??? @@ -27,7 +27,7 @@ class: center, middle, intro and setting unique UUIDs or Serial Numbers in SMBIOS tables. * DCU can be run in two modes - standalone, or as a container. The container setup contains all of the prerequisites, so it should be easier to use. -* Python, Apache 2.0 licensed, https://github.com/Dasharo/dcu +* Bash, Apache 2.0 licensed, https://github.com/Dasharo/dcu ??? @@ -39,6 +39,7 @@ class: center, middle, intro # DCU Vison ### Support for Mass Deployment Features + - **Custom Configuration Profiles**: Enable the creation of custom configuration profiles that can be applied across multiple systems, ensuring consistency in deployment. @@ -100,18 +101,18 @@ cd dcu && ./dcuc # Getting Started .medium-code[ -``` +```text Unable to find image 'ghcr.io/dasharo/dasharo-sdk:v1.2.0' locally v1.2.0: Pulling from dasharo/dasharo-sdk -8285c3e1284d: Pull complete -0f8ccaf821af: Pull complete -6e515abfab04: Pull complete -f3904770b5ac: Pull complete -a442011cbbb3: Pull complete -ff420ae8a2ab: Pull complete -0f1475b56e0c: Pull complete -ec99378fd72f: Pull complete -d650a0f92b92: Pull complete +8285c3e1284d: Pull complete +0f8ccaf821af: Pull complete +6e515abfab04: Pull complete +f3904770b5ac: Pull complete +a442011cbbb3: Pull complete +ff420ae8a2ab: Pull complete +0f1475b56e0c: Pull complete +ec99378fd72f: Pull complete +d650a0f92b92: Pull complete Digest: sha256:12044628c33a77989822f416ef884609d60b7fc5c045183c53e4f97a7080019a Status: Downloaded newer image for ghcr.io/dasharo/dasharo-sdk:v1.2.0 dcu - Dasharo Configuration Utility diff --git a/dug_4.md b/dug_4.md index 1621a8b..bf5a162 100644 --- a/dug_4.md +++ b/dug_4.md @@ -24,11 +24,17 @@ class: center, middle, intro ### .center[🚀 Dasharo User Group #3 Meeting Agenda 🚀] * #### 👋 17:00 UTC Greetings, Agenda and Dasharo Community Status + * #### 🧭 17:10 UTC Dasharo Tools Suite Status + * #### 🧰 17:25 UTC Dasharo Configuration Utility Introduction -* #### 🧰 17:40 UTC Open Source Firmare Validation Status + +* #### 🧰 17:40 UTC Open Source Firmware Validation Status + * #### 🧰 18:00 UTC Dasharo Community Release Roadmap + * #### 💻 18:45 UTC NovaCustom-Dasharo: Call for Beta Testers + * #### 👏 18:55 UTC Closing remarks ➡️ 🍺🍻 vPub 0x9 ??? @@ -37,7 +43,7 @@ TODO: try to say what specific will be presented as part of every presentation. --- -# Community Hearbeat 💓 +# Community Heartbeat 💓 .image-100[![](/img/community_heartbeat_dug_4.png)] @@ -46,37 +52,37 @@ TODO: try to say what specific will be presented as part of every presentation. Date of data snapshot: 03/12/2023 * Consider replacement of that graphics with: - - https://github.com/lowlighter/metrics/blob/master/source/plugins/followup/README.md + - https://github.com/lowlighter/metrics/blob/master/source/plugins/followup/README.md * Commands cheat sheet - - issues - - gh issue list -s all -L 1000 - - gh issue list -s closed -L 1000 - - prs (Dasharo/coreboot, Dasharo/edk2) - - all: gh pr list --state all - privde all PRs number as well as diff from last DUG - - merged: gh pr list --state merged - privde all PRs merged number as well + - issues + - gh issue list -s all -L 1000 + - gh issue list -s closed -L 1000 + - prs (Dasharo/coreboot, Dasharo/edk2) + - all: gh pr list --state all - provide all PRs number as well as diff from last DUG + - merged: gh pr list --state merged - provide all PRs merged number as well as diff from last DUG - - closed: gh pr list --state closed - privde all PRs closed number as well + - closed: gh pr list --state closed - provide all PRs closed number as well as diff from last DUG, to calculate it you have to calculate difference between closed and merged number - - number of unique users active in Dasharo community - - PAGER="less -R" gh issue list -s all -L 5000 --json author,comments --jq '.[].author.login'|sort|uniq|wc -l - - count all comments - - PAGER="less -R" gh issue list -s all -L 5000 --json comments --jq '.[].[].[].createdAt'|wc -l - - count how many comments each user posted - - PAGER="less -R" gh issue list -s all -L 5000 --json comments --jq '.[].[].[].author.login'|sort|uniq -c|sort -h - - matrix activity - - fetching all communication may be not the most effective way to get data (general: 00:11-TBD), + - number of unique users active in Dasharo community + - PAGER="less -R" gh issue list -s all -L 5000 --json author,comments --jq '.[].author.login'|sort|uniq|wc -l + - count all comments + - PAGER="less -R" gh issue list -s all -L 5000 --json comments --jq '.[].[].[].createdAt'|wc -l + - count how many comments each user posted + - PAGER="less -R" gh issue list -s all -L 5000 --json comments --jq '.[].[].[].author.login'|sort|uniq -c|sort -h + - matrix activity + - fetching all communication may be not the most effective way to get data (general: 00:11-TBD), there seem to be need for differential download, but it looks like matrix does not support that - - number of messages for DUG#4 snapshot: - - matrix comments per user: - - grep -E "\-.+: " matrix\ -\ Dasharo\ -\ General\ -\ Chat\ Export\ -\ 2023-07-02T22-37-07.435Z.txt |cut -d"-" -f2|cut -d":" -f1|grep -E "^ "|sort|uniq -c|grep -v "banned"|sort -h|grep -v import|grep -v "'"|grep -v "removed"|grep -v coreboot + - number of messages for DUG#4 snapshot: + - matrix comments per user: + - grep -E "\-.+: " matrix\ -\ Dasharo\ -\ General\ -\ Chat\ Export\ -\ 2023-07-02T22-37-07.435Z.txt |cut -d"-" -f2|cut -d":" -f1|grep -E "^ "|sort|uniq -c|grep -v "banned"|sort -h|grep -v import|grep -v "'"|grep -v "removed"|grep -v coreboot * TBD: look at community status of other projects, news? - - consider news presentation with Dasharo status about the OpenSIL - - maybe announcements section + - consider news presentation with Dasharo status about the OpenSIL + - maybe announcements section * Documentation releases? - - in long run everything should be a release, it would be easier to track + - in long run everything should be a release, it would be easier to track ideas related to improvements of given area of development --- @@ -86,7 +92,7 @@ Date of data snapshot: 03/12/2023 .center.image-80[![](img/dasharo_coreboot_2023q4.png)] * Experiment v2 with data presentation. -* Since DUG#3 we merged 25 PRs, what is avarage results for Dasharo/coreboot. +* Since DUG#3 we merged 25 PRs, what is average results for Dasharo/coreboot. --- diff --git a/dug_4/diagrams/dasharo_forks.py b/dug_4/diagrams/dasharo_forks.py index d93cc64..946b915 100755 --- a/dug_4/diagrams/dasharo_forks.py +++ b/dug_4/diagrams/dasharo_forks.py @@ -32,7 +32,7 @@ def run_gh_command(command): def count_prs(repo, state, date): # Construct the GitHub CLI command command = f"gh pr list --repo {repo} --state {state} --search 'created:<={date}' -L 10000 --json number --jq '. | length'" - + # Run the command and capture the output output = run_gh_command(command) diff --git a/dug_4/diagrams/dasharo_issues.py b/dug_4/diagrams/dasharo_issues.py index 70d3867..1ab1697 100755 --- a/dug_4/diagrams/dasharo_issues.py +++ b/dug_4/diagrams/dasharo_issues.py @@ -32,7 +32,7 @@ def run_gh_command(command): def count_issues(repo, state, date): # Construct the GitHub CLI command command = f"gh issue list --repo {repo} --state {state} --search 'created:<={date}' -L 10000 --json number --jq '. | length'" - + # Run the command and capture the output output = run_gh_command(command) diff --git a/dug_4/diagrams/dasharo_issues_resolution_progress.vega-lite b/dug_4/diagrams/dasharo_issues_resolution_progress.vega-lite index 9b13d52..aabfe6a 100644 --- a/dug_4/diagrams/dasharo_issues_resolution_progress.vega-lite +++ b/dug_4/diagrams/dasharo_issues_resolution_progress.vega-lite @@ -88,4 +88,3 @@ } } } - diff --git a/dug_4/diagrams/dasharo_users.py b/dug_4/diagrams/dasharo_users.py index 4f4aed9..3ae43be 100755 --- a/dug_4/diagrams/dasharo_users.py +++ b/dug_4/diagrams/dasharo_users.py @@ -36,4 +36,3 @@ plt.savefig('dasharo_users.png') # Optionally, close the plot to free up memory plt.close() - diff --git a/dug_4/diagrams/dts_issues.py b/dug_4/diagrams/dts_issues.py index eb74b70..ccfb973 100755 --- a/dug_4/diagrams/dts_issues.py +++ b/dug_4/diagrams/dts_issues.py @@ -32,7 +32,7 @@ def run_gh_command(command): def count_issues(repo, state, date): # Construct the GitHub CLI command command = f"gh issue list --label DasharoToolsSuite --repo {repo} --state {state} --search 'created:<={date}' -L 10000 --json number --jq '. | length'" - + # Run the command and capture the output output = run_gh_command(command)