mirror of
https://github.com/Dasharo/open-source-firmware-validation.git
synced 2026-06-13 10:16:18 -07:00
develop
24
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
   
|
a1a542fd5f |
Osfv stable release improvements (#1254)
* osfv_stability_{run,reports}.py: Add
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
osfv_stability_run: add release rules file
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
osfv_stability_reports: add run count
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
osfv_stability_reports: Fix: account for parallelism in total run time
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
osfv_stability_run.py: accept env vars
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
osfv_stability_reports.py: save logs to dirs depending on date and revision
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
osfv_stability_run.py: Save results in paths per run date and rev
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
osfv_stability_reports.py: Parse date, revision, branch and support json output
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
osfv_stability_*.py: Allow configurable LOGS_DIR using env vars
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
osfv_stability_reports.py: Handle broken robot xmls
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
osfv_stability_reports.py: Unpack merged results
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
osfv_stability_reports.py: Add suites to skip config
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Deploy Uefi Shell: Ensure it doesnt break the bootorder
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* os-specific-tasks/201.yml: Remove uefi shell installation
it breaks bootorder and tests deploy it anyway
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Login To OS: Rename to Boot And Login To OS
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Login To Windows: Rename to Boot And Login To Windows
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Login To Windows: Add keyword
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Logint To Booted OS: Add keyword
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Serial User Login Linux: Remove dead code
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Login To Linux: Remove retrials of Login To Linux Via SSH
Login To Linux Via SSH already retries all its code,
so this is redundant and multiplies the wait time
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* fix login ssh timeouts
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Login To Windows Via SSH: Reduce login timeout from 1h@20 tries to 5m@5 tries
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* keywords.robot: Implement login to OS recovery
When the boot order unexpectedly changes and testing via SSH,
the whole regression will start failing.
With this fallback, after we fail to log in to an OS, there
will at least be the hope of recovering the regression
eventually.
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Ensure Custom Bootentry: fix indexing empty list
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* BPS010: Deploy UEFI Shell: Add
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* linux-packages-playbook.yaml: Add systemwide update task
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Login To Windows Via SSH: Fail if login fails
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* TMP TEST: reduce trials for linux login
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* basic-platform-setup.robot: Normalize Boot&Login keyword variants usage in suite
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Set Nextboot Bootentry: Move implementation to lib/custom_boot_entries
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Load OS Credentials: Create keyword for flaky repeated import
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Recover Broken Bootorder: resume login after recover
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* options-lib_dcu.robot: Boot System... Do not assume default_boot is the target
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* lib/flash.robot: Fix missing 'x' in Wait Unil KW Succeeds
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Login To* kwds: Add configurable retries amount for ssh variants
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* capsule-update.robot: Flash rc0 before tests, update instructions
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Revert "TMP TEST: reduce trials for linux login"
This reverts commit d41693da2a3a600beb7a4a26d95f6e7f90a2430a.
* lib/dcu.robot: Remove redundant sleep after flashing
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* lib/network.robot: Send File To DUT: check hashes, rm before send
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* platform-configs: Update INTEL_CBNT_BOOTGUARD_FUSING_SUPPORT state
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* options-lib_dcu.robot: Remove redundant sleep in Set UEFI Option
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* keywords.robot: Load OS Credentials: Remove redundant OS login
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* lib/flash.robot: Flash ME in BTG supported devices
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* lib/flash.robot: Increase timeouts a bit to compensate for large RAM training
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* keywords.robot: Fix Login To Linux Via SSH not doing retries
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* capsule-update.robot: Rework suite to work without additional manual setup steps
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* novacustom-nuc_box.robot: Remove capsule update support: No capsules published
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* flash.robot: Flash FD using internal programmer to avoid FD mismatch bricks
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* regression-scope/configs/devices: Add capsule update env vars
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* capsule-update.robot: Remove manual step from Flash Firmware If Not QEMU
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* keyword & options-lib_dcu: Remove redundant Login To Windows keyword variant
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* capsule-update.robot: Remove redundant serial console test flow
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* release_tests_suite_list*: Add Basic Platform Setup to release tests
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* capsule-update.robot: Restore custom logo checking
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* requirements.txt: Bump osfv-scripts to fix time import
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* lib/dcu.robot: Prevent temp file collisions with uuids
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* msi-pro-690-a-wifi-ddr4_00039.json: change fw version to support custom logo
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* lib/flash.robot: Increase response timeout after flash to 300s
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* keywords.robot: Fix Login To Linux With Root Priviledges doing nothing on serial
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* keywords.robot: Login To Booted OS: Only attempt recover when via pure SSH
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* capsule-update.robot: Restore FUM dialog handling when serial console supported
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* capsule-update.robot: Adjust for execution on both serial and ssh
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* capsule_update_tests.sh: Remove only previous run files of the same name
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* lib/network.robot: Rm target path before moving
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Revert "lib/network.robot: Rm target path before moving"
This reverts commit 3bca42177f528f17eba13095dff0189a932fce8d.
* lib/network.robot: Add sync on the end to prevent interrupting the file transfer
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* capsule-update.robot: Make FUM screen optional, it depends on FW version
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* capsule-update.robot: Fix mismatch in waiting for tianocore string
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* ci//pcengines-apu3_00252.json: Fix FW file apu variant
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* platform-configs/protectli: Reduce repeated DMIDECODE values
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* protectli-vp6650_00002.json: Update sonoff ip
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* keys-and-keywords/ubuntu-keywords.robot: Fix applying log level immediately
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* ci//pcengines-apu3_00252.json: Update device IP address
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* menus.robot: Add warning if OS not found and will try to boot the default disk
Otherwise leads to cryptic fails failing because some disk name was not
found, while the real culprit is the OS not being installed.
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* linux-packages-playbook.yaml: accept gsettings modifications to fail
will fail if Gnome is not installed (server OSes)
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* BPS006: Add workaround for sudo-rs which is incompatible with ansible
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* release_tests_devices.txt: Fix protectli vp6650 filename
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* novacustom-nu_box-155H_00254.json: Update device IP
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* msi-z690-common.robot: Change keyboard model to fit hardware matrix
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* uefi-shell.robot: Use library keywords to perform test
Otherwise it was failing on MSI z690.
It's always better to use common and working
keywords instead of reinventing the wheel.
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* osfv-test-data: Bump version
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* tpm-support.robot: Add missing skips for serial-only tests
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* verified-boot.robot: Run DCU locally to keep DUT from downloading containers
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* platform-configs/pcengines: Update dmidecode values
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* platform-configs/novacustom: Update dmidecode values
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* lib/dcu.robot: Put temp tiles in /tmp to prevent littering if cleanup fails
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* BPS006: Put temp tiles in /tmp to prevent littering if cleanup fails
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* lib/flash.robot: Read Firmware include ME and IFD
We might assume the read firmware contains some IFD
or ME later, not reading them would result in a brick
and doesn't increase the read time that much.
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* SSH Boot System: Always reinit connection to fix 'No open connections' errors
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* cpu-performance.robot: Limit test runs to 3
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* manual_cpu_performance.robot: Limit runs to 3
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* novacustom-v540tnd_00266.json: Update device ip
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* novacustom-nuc_box-155H_00254.json: Update device IP
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Login To Booted OS: Fix infinite recovery loop
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* release_tests_devices.txt: Remove nucbox
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* keywords.robot: Fix ssh_retries being passed as timeout
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* SSH Login keywords: Limit retries to 5m instead of fixed try count
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* release_tests_suite_list.txt: Remove duplicated __init__s
robot crashes otherwise
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* lib/prepare-platform.resource: Unify redundant Prepare Platform definitions
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* util/prepare-platform.robot: Add util test for running Prepare Platform
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* release_tests_suite_list.txt: Use util/prepare-platform instead of module inits
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* dts-lib.robot: Add semiauto test skip for flashing kwd
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* develop_pr_auto_regression.py: Only compare revs if files list not overridden
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* osfv_stability_run.py: Fix logs_base undefined on custom logs dir
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* scripts/ci/regression-scope: Preserve suites order
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* develop_pr_auto_regression.py: Fix orphan robot processes
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* release_tests_rules.json: Add automated tag filter
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* osfv_stability_reports.py: Add per-suite cache
For suites which take a long long time to process,
to not lose the time spent processing it if the
processing is interrupted
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* osfv_stability_reports.py: Differentiate run dates in caches and reports
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* release_tests_devices.tst: Revert using temporary desk setup devices
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* scripts/regression.sh: Fix scope change
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* cpu-performance: Fix FORCE_TIMES_TO_RUN envvar set command
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* Login To Booted OS: Fix continuing on fail to login
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* test_cases.json: fix spelling and such (#1244)
* test_cases.json: fix spelling and such
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
test_cases.json: fix
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
* test_cases.json: fixname
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
* test_cases.json:remaining tests
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
* test_cases.json: add WLE
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
* check_tests_consistency.py: script lists diffs in test_cases.json and modules
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
* dasharo-compatibility/*:fix
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
* test_cases.json: fix
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
---------
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
* test_cases.json: Add missing tests and fix changed_to's (#1246)
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
* test_cases.json:fix net spd test (#1247)
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
* docs/novacustom.md: document v0.9.0 downgrade bug
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
* docs/novacustom.md: add link to ec downgrade procedure
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
---------
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Co-authored-by: Wiktor Mówiński <wiktor.mowinski@3mdeb.com>
Co-authored-by: Michał Kopeć <michal.kopec@3mdeb.com>
|
||
|
|
120f200c6d |
V560tnx v1.0.0 rc10 (#1202)
* .gitignore: Add _envvars, _roms directories Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * keywords.robot: Allow for the DUT ssh key to change when trying to connect via SSH in Login To Linux via SSH * lib/tpm.robot: Check all PCRs before failing in Validate PCRs Against Event Log Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * miniPCIe-slot-verification: Skip LTE_CARD tests if card is not defined * Stress Test Windows: use Execute Command In Terminal Otherwise there is no timeout for the keyword and the tests could hang forever Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * CBMEM001: Add semiauto implementation Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * Set Nextboot Bootentry: compare strings as variables to fix utf decode errors Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * novacustom-mtl.robot: Add USB model t oconfig Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * novacustom-v560tne: v1.0.0-rc10 platform configs changes Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> novacustom-v560tne: Add windows support Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> v560tne: temp RTE serial tests Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> v560tne: dmidecode update version Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> v560tne: Restore fedora support flag Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> v560tne: Add USB drives model names for detection tests Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> v560tne: Add DOCKING_STATION_USB_C_CHARGING_SUPPORT Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> v560tne: add qubes support Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> v540tnd: Restore ubuntu default boot os Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> REMOVE platform-configs: restore SSH Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * acpi-driver.robot: Fix typo in deb package name Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * minipcie-slot-verification: Replace hardcoded wifi name with the configs Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * Switch To Root User: Add workaround for passwordless root Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * os-specific-tasks/203.yml: Add qubesos ansible config Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * fwupd-support.robot: automate qubes Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * cpu-performance.robot: Add missing phoronix batch mode setup to automated suite Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * Login To Windows Via SSH: Allow the key to change across retries Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * Get Index Of Matching Option In Menu: do not use fuzzy match It works a bit differently - the * is not a special character in fuzzy search Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * Execute Shutdown Command: Add linux systemd support Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> Execute Shutdown Command: Add some workaround for no power_led Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * Measure Warmboot Time: add workaround for no RTC boot Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * platform-configs: Add RTC_BOOT_SUPPORT https://github.com/Dasharo/open-source-firmware-validation/issues/1068 Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * CBMEM suite: dynamic semiauto skips for no RTC boot support Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * network-interface-after-suspend: Add workaroud for no RTC boot https://github.com/Dasharo/open-source-firmware-validation/issues/1068 Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * linux-packages-playbook.yaml: Remove masking systemd suspend It makes it impossible to suspend the device in conventional ways like using the UI or via suspend key combination. It has more cons that pros Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * cbnt.robot: Fix invalid ibg menu parsing Due to confusing line wrapping in the menu the state of the options following to the target were being parsed Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * SBO: Fix test ids ENV_ID Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * fast-boot.robot: Increase wait time for systemd-analyze 50s was not always enough for bootup to finish. 150s should be better. Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * gpu-performance.robot: stability fixes Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> gpu-performance.robot: Fix string comparison error and x11 invalid display Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> gpu-performance.robot: Detect not running x11 Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> gpu-performance.robot: Note that X11 is required Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> gpu-performance.robot: fix check for installed unigine-super Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> gpu-performance.robot: Add comment about display numbering bug https://github.com/Dasharo/open-source-firmware-validation/issues/1215 Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> lib/performance/common: Setup Phoronix: Upload results to openbenchmarking Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> disk-io.robot: Verify correct disk model before checking performance Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> disk-io.robot: move sleep to after skips to reduce unnecessary idle time Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * phoronix-test-suite tests: Cap run count to 3 Using: FORCE_TIMES_TO_RUN env variable Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * lib/docs.robot: Increase time for docking station to init Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * util/fwupd-support-lvfs: stylistic changes Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> util/fwupd-support-lvfs: Remove unused variable Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> util/fwupd-support-lvfs.robot: Add missing newline in fwupd config Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * cbnt.robot: Remove newline characters from cbmem regex The newline characters are not matched by this keyword. Its matched line-by-line so newline characters never appear Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * lib/utc.robot: stability fixes Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> lib/utc.robot: reboot tests add delay to prevent immediate re-login Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> lib/utc: hotplug tests: reorder disconnect/connect to end with connected Otherwise the docking station would be left disconnected after the tests causing further automated tests to possibly fail Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> UTC: Add dynamic skips for laptop semiautos Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * fwupd-support: Add --assume-yes to get-devices First time its executed after a fwupd update it will prompt to send the results to the vendor. It was not handled before. Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * Execute Reboot Command: Add delay for no-power-ctrl devices Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * EXTERNAL_HEADSET: Change to list of acceptable values Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * BOOTED_OS_ID: Prevent resetting on new suite Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * warm/coldboot tests: Add dynamic semiauto skips if not supported Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * lib/robot.sh: Run all suites at once and split results later We've made it so that the test suites are run separately so that the logs can be organized neatly before. Turns out that makes the state between suites get lost. It's especially important for SSH tests which need to always remember which OS is booted to use the correct SSH credentials. This commit changes this so that everything is run at once, but the results are later parsed and split per-suite using rebot. An important thing to remember is that testers will often interrupt the run using ctrl+c to get the test results early and skip further execution. The change handles that by trapping the INT signal and running the split anyway. Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> lib/robot.sh: Move robot to fg instead of waiting When running robot as a subprocess it wont receive the control over stdin otherwise. Some semi-auto tests require user input in terminal which will crash otherwise. Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> lib/robot.sh: fix detecting tags tests that are fullauto on some and semi on some platforms need to have both tags so that they are executed no matter the `-i` param and the skips can take care of whether the test is automated on given platform or not Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * TEST_TAGS: rename to INCLUDE_TAGS Theres a builtin ${TEST TAGS}, but for some reason ${TEST_TAGS} seems to be like an alias to it. Our variable that keeps track of the tags requested by tester needs to be changed because of that Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * options-lib_dcu: Set nextboot before Set UEFI Option Set UEFI Option of options-lib_dcu reads the current SMM Store, modifies it, and flashes it back. If we set the Nextboot variable in SMM before reading the SMM store it will stay after flash and reboot reducing an unnecessary DEFAULT_BOOT_OS_ID boot. Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * sleep-lib.robot: warn on failed fwts sleep Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> sleep-lib: Add description of s3 test also working for s2idle(soix) Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * keywords.robot: Identify Path To USB: Fix returning TYPE instead of PATH Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * capsule-update.robot: Skip unnecessary setup when on ssh Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * scripts/lib/robot.sh & related: Restore old logs directory structure Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * audio-subsystem.robot: Delete old version of suite Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * platform-configs/include/protectli-vp66xx.robot: enable redundant boot Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com> * coreboot-redundant-boot.robot: work with the new log convention Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com> * platform-configs/include/protectli-vp66xx.robot: enable CBnT w/ status menu Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com> * lib/bios/menus.robot: Parse Menu Snapshot Into Construction: drop fuzzy search Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com> * platform-configs/include/protectli-vp66xx.robot: remove unused variable Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com> * coreboot-redundant-boot.robot: RTC BUC Control Bit Should Be: don't convert case Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com> * coreboot-redundant-boot.robot: parse log from current boot only Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com> --------- Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com> Co-authored-by: Michał Kopeć <michal.kopec@3mdeb.com> |
||
 Mateusz Maciejewski
|
69102fd792 |
os-config/ansible/linux-packages-playbook.yaml: changes reverted.
Ubuntu Server-enabling chnages reverted, issue created: https://github.com/Dasharo/open-source-firmware-validation/issues/1159 Changes & log in attachment. Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com> |
||
|
Mateusz Maciejewski
|
72cd642458 |
PC Engines APU: GNOME power control removed from Ansible Ubuntu playbook
DO NOT MERGE. We need either Ubuntu Server ENV_ID or some conditional playbook control. Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com> |
||
|
Filip GołaśandGitHub
|
9db1f5a8a2 |
V540tnd v1.0.0 rc6 (#1082)
* requirements.txt: bump fuzzysearch Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * platform-configs: Use max_insertions and max_deletions in fuzzy telnet Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * [REMOVE ME] variables.robot: Add temporary desk RTE setup Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * platform-configs: Update supported OSes for v1.0.0-rc6 Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * requirements.txt: bump osfv-scripts to include v56tnx models Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * novacustom-v560tu: Change Default boot to Ubuntu for faster tests Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * Revert "novacustom-v560tu: Change Default boot to Ubuntu for faster tests" This reverts commit |
||
|
Filip GołaśandGitHub
|
57d4cbdc46 |
os-specific-tasks/202.yaml: Add docker installation on Fedora (#1057)
* linux-packages-playbook.yaml: run geerlingguy.docker Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> * os-specific-tasks/201.yaml: Remove docker installation, covered by geerlingguy.docker Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> --------- Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
 Michał ŻygowskiandGitHub
|
4f10afbdbc |
Odroid h4 ultra tests (#881)
* dasharo-compatibility/network-speed.robot: Move keywords to lib The keywords are generic for network performance testing. They can be reused by other tests, e.g. incoming ODROID netcard test. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility/odroid-netcard.robot: Add netcard test Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility/memory-ibecc.robot: Add IBECC tests Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs: Add ODROID H4 Ultra Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-performance/fast-boot.robot: Make the test work with telnet The test assumed that the device is already booted to an OS, which probably is true for laptops. Add necessary Power On's and initial booting to OS on the beginning of the test to handle a case where the serial connection can be used to navigate and select OSes to boot. Also do not log in to OS again after "Measure FW Boot Time On Linux", because this keyword keeps the connection to the OS. TEST=Run the test and PASS it on ODROID H4 Ultra Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * lib/sleep-lib.robot: Make sleep tests work with telnet Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * test_cases.json: Add new test cases Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4: Do not verify FW version after flashing Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * compatibility/custom-network-boot-entries.robot: Ensure netboot is enabled Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4: Add CPU temperature threshold Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4: Update release date Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * variables.robot: Fix the configs for ODROID platforms Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility/miniPCIe-slot-verification.robot: Fix skip Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility/nvme-support.robot: Use configs to get disk name Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs: Drop unused CLEVO_DISK Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4: Synchronize configs Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4: Enable Windows tests Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * os-config/ansible/os-specific-tasks/201.yaml: Add docker installation Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * scripts/lib/robot.sh: Fix typo in directory name Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4: Disable fan speed measurements Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * lib/usb-hid-msc-lib.robot: Fix condition for mounting USB Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * compatibility/device-detection.robot: Close connections at the end of teardown Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * compatibility/device-detection.robot: Add proper checks for suite skip Judging by the content of test cases, the suite depends on the SSH connection method and the DCU backed for option manipulation. It is not suitable for runnign in other configuration, like telnet connection method and option management via firmware setup. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4: Update release version Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * compatibility/efibootmgr.robot: Make test suitable for telnet platforms Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * keywords.robot: Wait for the power to stabilize before pressing power button Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * util/basic-platform-setup.robot: Mark suite as automated Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * test_cases.json: Sort new tests by ID Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * compatibility/audio-subsystem.robot: Use generic keyword for command Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * compatibility/cpu-fan-speed-measure.robot: Skip suite earlier to save time Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * lib/network.robot: Make intervals larger for Get Hostname Ip Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4: Disable hybrid core support Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * lib/network.robot: Add variable for Get Ip interval Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * scripts/regression-rerun-failed.sh: Add script to rerun failed tests Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * compatibility/efibootmgr.robot: Ensure network boot is disabled initially Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4: Fix CPU temperature threshold Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * lib/power-after-fail-lib.robot: Fix import failure Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * compatibility/reset-to-defaults.robot: Skip fan profile test if not supported Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * compatibility/platform-suspend-and-resume.robot: Check for skip in suite setup Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * compatibility/reset-to-defaults.robot: Skip sleep type test if not supported Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * Deploy UEFI Shell where necessary Basic platform setup deploye UEFI SHell, however running a whole suite like comaptibility, e.g. during regression, causes the FW to eb flashed again and the UEFI Shell is lost right after basic platform setup finishes its job. Ensure the UEFI Shell is deployed wherever it is used. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * lib/esp-scanning-lib.robot: Sync filesystem after cleaning ESP Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility/DTS: Skip flashing if FW variable not set Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility/dasharo-tools-suite.robot: Fix internal flashing "Flash Via Internal Programmer" sends a file to DUT from host. However, the test downloads th binary with wget prior to the keyword execution. Skip the wrapper and call "Flash Via Internal Programmer With Args" directly. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-security/tpm: Fix TPM tests Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-security/verified-boot.robot: Sync filesystem before power cycling Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility/audio-subsystem.robot: Fix headphones Windows tests Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility/audio-subsystem.robot: Make audo devices platform-specific Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * lib/bios/menus.robot: Fix variable type Fixes the error of variable value not a list or list-like. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-security/verified-boot.robot: Drop VBO011.001 duplication Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * lib/sleep-lib.robot: Fix suspend test on Telnet Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4: Remove obsolete override Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * scripts/regression.sh: Run stability suite too Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4-ultra.robot: Sync DTS E2E variables Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4: Sync DMI info Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-stability/tpm-detect.robot: Drop check for NVME in TPM detection Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility/power-after-fail.robot: Fix powering on based on var state When power after fail test are executed, the state of power after fail variable is changed. The Power On keyword does not take it int oaccount and uses only the default state of the variable. This results in obsolete power button presses which often lead to powering off the platform right after PSU is powered on. Because of that the tests fail due to power LED not being lit up. Define another variable that is updated runtime and represents current state of the power after faile variable. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * keywords: Fix usage in teardown Fixes the problem: 'Set Tags' cannot be used in suite teardown. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility: Fix list comparison in Ethernet tests Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs/odroid-h4-ultra.robot: Update Ethernet info Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * util/basic-platform-setup.robot: Add minimal-regression tag Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * lib/secure-boot-lib.robot: Fix launching UEFI Shell Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * lib/linux.robot: Add MKTME to dmesg error allowlist Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * variables.robot: Add ODROID H4 Ultra Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility: Move netcard test to ETHPERF Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility/network-speed.robot: merge netcard test with ETHPERF001 Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * dasharo-compatibility/device-detection.robot: Fix duplicated close connection Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> * platform-configs: Drop unused ODROID_NETCARD_SUPPORT Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> --------- Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> |
||
|
Filip Gołaś
|
0b2fa204b9 |
linux-packages-playbook.yaml: Add packages update_cache
The latest documentation does not list this option https://docs.ansible.com/ansible/latest/collections/ansible/builtin/package_module.html It is awailable in the more specific builtin `apt` and `dnf` though: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/dnf_module.html https://docs.ansible.com/ansible/latest/collections/ansible/builtin/apt_module.html Despite that it works in the builtin `package` . Logs in PR Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
 Filip GołaśandGitHub
|
0d614f9183 |
202-packages.yaml: Update ffmpeg package name (#900)
It's now called ffmpeg-free. You can still install it manually using `dnf install ffmpeg`, which will result in installing ffmpeg-free, but when running it via ansible the old name won't work. Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
 Filip GołaśandFilip Lewiński
|
e48bed1cf7 |
os-config/ansible: Add AUD tests required packages
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
 Sebastian CzaplaandMichał Żygowski
|
18056eaf67 |
osfv: Add UEFI Shell back to tests
Signed-off-by: Sebastian Czapla <sebastian.czapla@3mdeb.com> |
||
|
Mateusz Maciejewski
|
0d35a2e2b1 |
WLE002.201 & .202: required packages are now also in ansible playbook
- network-manager & pciutils are now installed by ansible playbook - regexp comment removed Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com> |
||
|
Filip GołaśandMichał Kopeć
|
5dd95e703f |
os-specific-tasks/202: Load acpi_call module automatically
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
|
Filip GołaśandMichał Kopeć
|
85eadf11fe |
ansible/linux-packages-playbook: Disable suspend and lock on linux
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
|
Filip GołaśandMichał Kopeć
|
643dbea5c2 |
os-specific-tasks/202.yaml: Downgrade kernel from 6.13 on Fedora
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
|
Filip GołaśandMichał Kopeć
|
8a8bf2abbc |
ansible/linux-packages-playbook: Disable auto suspend on gnome
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
|
Filip GołaśandMichał Kopeć
|
8b016bde91 |
os-specific-tasks/202.yaml: Downgrade kernel from 6.13 on Fedora
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
|
Filip GołaśandMichał Kopeć
|
28b4952738 |
os-specific-tasks/202.yaml: Disable spi_intel_pci module on fedora
it conflicts with flashrom Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
|
Filip GołaśandMichał Kopeć
|
d45056a749 |
linux-packages-playbook: Add installing cb tools from osfv submodule
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
|
Filip GołaśandMichał Kopeć
|
9783eced53 |
linux-packages-playbook: Add installing all osfv required packages
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
|
Filip GołaśandMichał Kopeć
|
3e94a454bd |
os-config/ansible/os-specific-tasks: Add files for os specific tasks
that will only be run on the os with the ID in the name of the file Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
|
Filip GołaśandMichał Kopeć
|
af966d468b |
os-config/ansible/vars: Add all packages required in osfv
except for acpi_call on fedora, which is not in fedora repositories, has to be installed manually Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
|
Filip GołaśandMichał Kopeć
|
e7566857f0 |
202-packages.yaml: Fix lm-sensors package name on fedora
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |
||
|
Filip GołaśandMichał Kopeć
|
e7367bc7c3 |
os-config/ansible: Add ansible-playbook config files
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com> |