Jaben Carsey
885f7fd0c7
ShellPkg: Fix duplicate String IDs
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15562 6f19259b-4bc3-4df7-8a09-765794883524
2014-06-16 21:58:50 +00:00
Jaben Carsey
33eb033f86
ShellPkg: fix Comp command output
...
The comp command was potentially displaying the incorrect offset into the file due to comparing 3 extra bytes for difference groups.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: Tapan Shah <tapandshah@hp.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15558 6f19259b-4bc3-4df7-8a09-765794883524
2014-06-05 22:02:12 +00:00
Jaben Carsey
09a43a5d5c
ShellPkg: report error when EfiDecompress is run on a non-compressed file
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: Tapan Shah <tapandshah@hp.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15529 6f19259b-4bc3-4df7-8a09-765794883524
2014-05-14 16:54:09 +00:00
Brendan Jackman
0698723204
ShellPkg: ShellCommands/SetVar: Make '-rt' imply '-bs'
...
It's invalid to set a variable that's available from runtime services but not
from boot services.
Currently if you pass '-rt' without '-bs' you get a generic
'Invalid Parameter' message. We should either print a more useful message in
this case, or make '-rt' imply '-bs' (as this patch does). The Shell Spec is
ambiguous on the matter.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Brendan Jackman <Brendan.Jackman@arm.com >
Reviewed-By: Olivier Martin <olivier.martin@arm.com >
Reviewed-By: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15323 6f19259b-4bc3-4df7-8a09-765794883524
2014-03-10 18:13:13 +00:00
Jaben Carsey
e8c737ae79
ShellPkg: Add missing header files
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.Carsey@intel.com >
Reviewed-by: Daryl McDaniel daryl.mcdaniel@intel.com
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15262 6f19259b-4bc3-4df7-8a09-765794883524
2014-02-25 23:03:17 +00:00
Shumin Qiu
14868afbb8
Update prints of variable attributes from 'RS' to 'RT' for 'Dmpstore' command.
...
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15164 6f19259b-4bc3-4df7-8a09-765794883524
2014-01-23 00:29:53 +00:00
Shumin Qiu
f614ce7ebb
Update the comments in function headers to follow Doxygen special documentation blocks in section 2.3.5.
...
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15163 6f19259b-4bc3-4df7-8a09-765794883524
2014-01-23 00:27:52 +00:00
Tian, Hot
d42aab6e61
Fix CRLF format
...
Signed-off-by: Tian, Hot <hot.tian@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15160 6f19259b-4bc3-4df7-8a09-765794883524
2014-01-22 08:40:29 +00:00
Shumin Qiu
5511b319f2
1. Change the implementation of function 'LoadVariableFromFile' to return SHELL_STATUS. 2. Add code to check whether the pointer 'FoundVarName' in 'DmpStore.c' is NULL before used.
...
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com >
Reviewed-by: Ni, Ruiyu <ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15112 6f19259b-4bc3-4df7-8a09-765794883524
2014-01-14 07:30:50 +00:00
Olivier Martin
8da53ddd3b
ShellPkg: remove unreachable break statements
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15108 6f19259b-4bc3-4df7-8a09-765794883524
2014-01-13 18:52:12 +00:00
Shumin Qiu
483b86b918
Set the type of return value from function 'LoadVariablesFromFile' in 'DmpStore.c' to match the type of 'ShellStatus'.
...
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com >
Reviewed-by: Ni, Ruiyu <ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15102 6f19259b-4bc3-4df7-8a09-765794883524
2014-01-13 07:28:01 +00:00
Jaben Carsey
9f7f0697b7
ShellPkg: add the last PCIe extended capability decodings
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15097 6f19259b-4bc3-4df7-8a09-765794883524
2014-01-10 22:34:13 +00:00
Ruiyu Ni
7e63fc9de9
Add the feature "dmpstore -l" and "dmpstore -s".
...
The file format is as below:
<File> := <Variable>+
<Variable> := <Name-Size> <Data-Size> <Name> <GUID> <Attributes> <Data> <Crc32>
Each variable representation in the file has a CRC32 value which can provide a mechanism to detect the file modification.
When any CRC32 is incorrect, dmpstore rejects to load the variables from the file.
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15083 6f19259b-4bc3-4df7-8a09-765794883524
2014-01-10 01:52:24 +00:00
Jaben Carsey
705bffb568
ShellPkg: Add more output to PCI command for extended configuration.
...
there is a new non-spec parameter "-_e" which allows additional information output to be controlled.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15070 6f19259b-4bc3-4df7-8a09-765794883524
2014-01-09 16:54:13 +00:00
Shumin Qiu
03bc7c2b09
Add code to check whether the pointer 'NewBuffer' in 'FileHandelWrappers.c' and the pointer 'FoundVarName' in 'Dmpstore.c' are NULL before used.
...
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15060 6f19259b-4bc3-4df7-8a09-765794883524
2014-01-09 00:30:27 +00:00
Shumin Qiu
de4ebdcfcd
Add the comment for function 'IsValidSplit' in 'Shell.c'. Add code to check whether pointer 'DataBuffer' in 'DmpStore.c' is NULL before used.
...
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15051 6f19259b-4bc3-4df7-8a09-765794883524
2014-01-07 01:51:08 +00:00
Jaben Carsey
5bd12b0555
ShellPkg: fix DmpStore for deleting
...
This change allows DmpStore command to delete all variables whereas before it would stop after a single deletion due to looping errors. It uses a recursive function and deletes the last item returned from GetNextVariableName() first and then goes "backwards" to the first items.
This can't delete authenticated variables.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15014 6f19259b-4bc3-4df7-8a09-765794883524
2013-12-20 22:33:01 +00:00
Ruiyu Ni
d4468cdf14
Rollback the change to EFI_BOOT_KEY_DATA structure since UEFI Spec adds the clarification that bitfields are ordered such that bit 0 is the least significant bit.
...
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15000 6f19259b-4bc3-4df7-8a09-765794883524
2013-12-18 05:51:22 +00:00
Chris Phillips
6855763eb2
ShellPkg: Fix pci command to parse seg, bus, dev, and func arguments as hex
...
- Added STR_GEN_PARAM_INV_HEX string
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14926 6f19259b-4bc3-4df7-8a09-765794883524
2013-12-02 21:45:28 +00:00
Chris Phillips
541ddf4436
ShellPkg: Fix pci command output of Max and Current Link Speed, and ASPM Support values to match PCIe Base Spec rev 3.0
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14892 6f19259b-4bc3-4df7-8a09-765794883524
2013-11-22 21:17:25 +00:00
Chris Phillips
c37e0f16be
ShellPkg: Update pci command to use ShellPrintEx()
...
- Also minor simplification to the PciPrintClassCode() function.
- Remove invalid duplicate gShellDebug1HiiHandle argument in STR_PCI_NO_FIND print.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14880 6f19259b-4bc3-4df7-8a09-765794883524
2013-11-21 17:21:59 +00:00
Jaben Carsey
f79868cd18
ShellPkg: Change MM command output during script execution
...
- Automatically use non-interactive mode during script execution.
- Automatically use non-interactive mode when a specific value is read (omitting this behavior was a violation of the UEFI Shell Spec)
- Only output the value read in when reading a value in a script; this allows automated use of the MM command.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Chris Phillips <chrisp@hp.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14874 6f19259b-4bc3-4df7-8a09-765794883524
2013-11-20 17:25:02 +00:00
Jordan Justen
14b5e3fd78
ShellPkg pci command: Fix a typo; /r/n => \r\n
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14865 6f19259b-4bc3-4df7-8a09-765794883524
2013-11-19 23:02:59 +00:00
Chris Phillips
abbea36e3e
ShellPkg: Fixes ‘edit’ command to correctly display ASCII or UNICODE for the file type.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
reviewed-by: jaben carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14785 6f19259b-4bc3-4df7-8a09-765794883524
2013-10-18 18:11:52 +00:00
Sergei Antonov
6b6aa6d136
ShellPkg: Handle pool allocation failure
...
If AllocateZeroPool() returns NULL,
GetVariable() will return EFI_BUFFER_TOO_SMALL,
FreePool() will receive NULL.
So check for NULL before FreePool().
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Sergei Antonov <saproj@gmail.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14688 6f19259b-4bc3-4df7-8a09-765794883524
2013-09-19 17:23:10 +00:00