Carsey, Jaben
6fcd911c32
BaseTools: AutoGen - remove unused variables.
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-26 14:43:25 +08:00
Carsey, Jaben
fe0a9af881
BaseTools: AutoGen - remove dictionary populated, but never accessed
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-26 14:43:24 +08:00
Carsey, Jaben
9759febdb8
BaseTools: Workspace - refactor GetStructurePcdInfo
...
the function doesn't use self and can be static
defaultdict replaces dict and removes the dict initialization code
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-26 14:42:20 +08:00
Carsey, Jaben
b813843cca
BaseTools: simplify if call
...
the variable is a string type since we just used .strip() on it.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-26 14:36:05 +08:00
Carsey, Jaben
6b1f2cf41a
BaseTools: Autogen - replace string constants with those from DataType
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-26 14:36:05 +08:00
Carsey, Jaben
3e4faa268e
BaseTools: Workspace - refactor RegEx to minimize multiple compiling
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-26 14:35:36 +08:00
Carsey, Jaben
1eb72acddd
BaseTools: Share RegEx between files
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-26 14:27:59 +08:00
Carsey, Jaben
2a9aac46a6
BaseTools: GenPatchPcdTable - refactor RegEx to minimize multiple compiling
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-26 14:27:59 +08:00
Carsey, Jaben
6686d9a125
BaseTools: Misc - refactor RegEx to minimize multiple compiling
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-26 14:27:58 +08:00
Carsey, Jaben
656d2539be
BaseTools: replace 'UINT8','UINT16','UINT32','UINT64','VOID*' with shared constants.
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-23 11:11:20 +08:00
Carsey, Jaben
b491aa95ab
BaseTools: remove un-needed use of .keys() on dictionaries
...
sometimes just delete it.
sometimes the loop needed .values() instead
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-23 11:11:19 +08:00
Carsey, Jaben
4e50eba1b6
BaseTools: remove PlatformClass as it's not used
...
v2 - update makefile too.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-23 11:08:44 +08:00
Carsey, Jaben
66d04638e5
BaseTools: remove EdkIIWorkspace as its not used.
...
v2 - update makefile too.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-23 11:08:24 +08:00
Yunhua Feng
3378782691
BaseTools: Support DSC component !include PCD items
...
DSC format:
[Components]
TestPkg/TestDriver.inf {
<PcdsFixedAtBuild>
!include TestPkg/Test.txt
}
Test.txt content:
PcdToken.PcdCName | 0x123
Per spec we should support this usage.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-19 15:47:36 +08:00
Carsey, Jaben
25598f8bdb
BaseTools: merge towards minimum PCD MAX <something> methods
...
we have 5 different max val or max byte for PCDs.
refactor and remove 2 methods.
we need 3, as one computes for VOID* PCDs.
Cc: Bob Feng <bob.feng@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-18 22:15:36 +08:00
Carsey, Jaben
9eb87141ec
BaseTools: refactor and remove un-needed use of .keys() on dictionaries
...
sometimes just delete it.
sometimes the loop needed .values() instead
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-18 22:15:36 +08:00
Carsey, Jaben
55c84777ee
BaseTools: use predefined constants instead of local strings
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-18 22:15:35 +08:00
Carsey, Jaben
5a693b89a1
BaseTools: refactor and remove more keys() usage
...
this is no longer required to make dictionary objects iterable.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-18 22:15:35 +08:00
Carsey, Jaben
d498274fcd
BaseTools: Eot - Remove FvImage file
...
move the single used class from FvImage to Eot
delete the FvImage file
remove FvImage from makefile
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-18 22:15:34 +08:00
Carsey, Jaben
5f446994a2
BaseTools: Remove un-needed list comprehension
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-18 22:15:34 +08:00
Carsey, Jaben
b96c7cf8ca
BaseTools: remove duplicate function name
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-18 22:15:33 +08:00
Carsey, Jaben
9e508f3acc
BaseTools: change DscBuildData functions without need for self to staticmethod
...
prepend functiosn with @staticmethod
change calls to use class name, not self
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-17 21:17:55 +08:00
Carsey, Jaben
e1a76b4702
BaseTools: remove an unused file
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-17 21:02:06 +08:00
Carsey, Jaben
9fb9cbfb65
BaseTools: delete an unused file
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-17 20:54:15 +08:00
Carsey, Jaben
80bfbd3e83
BaseTools: FfsInfStatement - remove unused function
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-04-17 20:49:55 +08:00