Liming Gao
5d9af6a55a
BaseTools: Retrieve /U and -U CC flags to structure PcdValueInit Makefile
...
/D and -D flags have been added. So, /U and -U flags should be added.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-07 15:24:30 +08:00
Carsey, Jaben
a4c35dedd9
BaseTools: Ecc - add dict for config file to internal translation
...
Commit eece4292ac changed a variable name, which was tied directly to
a config file entry. This seperates the internal variable names from
the config file entries by having the internal dict accessed through a
translation of key words.
added a test when this is run straight from command line.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Cc: Laszlo Ersek <lersek@redhat.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Tested-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-06 20:08:38 +08:00
Carsey, Jaben
8252e6bf2d
BaseTools: dont make iterator into list if not needed
...
functions (like join) can use the iterator just as easily.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:08:09 +08:00
Carsey, Jaben
4d601fc6b1
BaseTools: use set instead of list
...
as we only do membership (in) testing for this, set is better
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:07:57 +08:00
Carsey, Jaben
b2aeaf573e
BaseTools: create base expression class
...
this class has a fucntion to share between Exception and RangeExpression
change both classes to call this function init in their init
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:07:56 +08:00
Carsey, Jaben
cf3062901d
BaseTools: refactor Depex optomization
...
No need to make a list from the set. just pop the item off.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:07:56 +08:00
Carsey, Jaben
c5c7e68a91
BaseTools: Remove lists form set construction
...
There is no need to make a list to make a set. remove lists
that are only used in constructing sets.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:07:55 +08:00
Carsey, Jaben
0ed0372a6b
BaseTools: missed a copyright update
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:07:55 +08:00
Carsey, Jaben
ef4f218b3d
BaseTools: GenFds - use existing shared string
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:07:54 +08:00
Carsey, Jaben
d5d2b6bd24
BaseTools: remove unused variable
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:07:54 +08:00
Carsey, Jaben
d0a0c52c22
BaseTools: standardize GUID and pack size
...
currently GUID packing and pack size determination is spread
throughout the code. This introduces a shared function and dict and
routes all code paths through them.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:07:34 +08:00
Carsey, Jaben
31ff1c443e
BaseTools: AutoGen - add Opcode constants
...
add constants for dependency expression opcode strings
use these new opcode string constants
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:11 +08:00
Carsey, Jaben
6c2d8cb238
BaseTools: remove redundant content in InfSectionParser
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:11 +08:00
Carsey, Jaben
1360bcb84e
BaseTools: remove unused member variable
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:11 +08:00
Carsey, Jaben
cb7e6aa77a
BaseTools: AutoGen - refactor more functions only called in __init__
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:10 +08:00
Carsey, Jaben
1549328f5f
BaseTools: AutoGen - refactor function to remove extra variables
...
we dont need to keep data we already have in different formats...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:10 +08:00
Carsey, Jaben
d3054be59e
BaseTools: Refactor to share GUID packing function
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:09 +08:00
Carsey, Jaben
a2e721704b
BaseTools: AutoGen - remove another function no one calls
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:09 +08:00
Carsey, Jaben
8b88b1634f
BaseTools: AutoGen - move function to clean file namespace
...
the function is only used in one other function.
just move it there.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:08 +08:00
Carsey, Jaben
032a7c9fe2
BaseTools: AutoGen - remove function no one calls
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:08 +08:00
Carsey, Jaben
64bb8d4d51
BaseTools: refactor __init__ functions to not compute temporary variable
...
just assign correct value to member variable in __init__ or call
parent __init__
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:08 +08:00
Carsey, Jaben
61f5b77dd5
BaseTools: AutoGen - no need to recompute
...
looping over a list and recomputing the same value has no impact on final value
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:07 +08:00
Carsey, Jaben
92a4eebb37
BaseTools: AutoGen - refactor out a useless class
...
this class was never instantiated. the static function was called.
save the function, remove the rest.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:07 +08:00
Carsey, Jaben
0caa769dbb
BaseTools: AutoGen - refactor out a list
...
the lists were used in __init__ then converted to sets
instead just use the sets from the begining
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:06 +08:00
Carsey, Jaben
def89ed025
BaseTools: AutoGen - refactor out functions only called in __init__
...
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-05-04 13:03:06 +08:00