Aaron Pop
35216819b5
SourceLevelDebugPkg DxeDebugAgent: Handle additional initialize cases.
...
Handle both DEBUG_AGENT_INIT_REINITIALIZE and
DEBUG_AGENT_INIT_DXE_CORE_LATE InitFlags to prevent an assert.
No additional initlization takes place for these cases.
Signed-off-by: Aaron Pop <aaronpop@microsoft.com >
2024-12-16 20:49:45 +00:00
Oliver Smith-Denny
ef4f3aa3f7
MdePkg: MdeLibs.dsc.inc: Apply StackCheckLibNull to All Module Types
...
Now that the ResetVectors are USER_DEFINED modules, they will not
be linked against StackCheckLibNull, which were the only modules
causing issues. So, we can now remove the kludge we had before
and the requirement for every DSC to include StackCheckLibNull
for SEC modules and just apply StackCheckLibNull globally.
This also changes every DSC to drop the SEC definition of
StackCheckLibNull.
Continuous-integration-options: PatchCheck.ignore-multi-package
Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com >
2024-11-13 21:01:46 +00:00
Oliver Smith-Denny
d7a0a7ae4a
SourceLevelDebugPkg: Add StackCheckLib
...
Add null implementation of StackCheckLib
Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com >
2024-09-13 03:58:46 +00:00
Joey Vagedes
7c10472983
SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml: Add PrEval CI config
...
Adds an entry to the package's CI configuration file that enable policy
5 for stuart_pr_eval. With this Policy, all INFs used by the package are
extracted from the provided DSC file and compared against the list of
changed *.inf (INF) files in the PR. If there is a match, stuart_pr_eval
will specify that this package is affected by the PR and needs to be
tested.
Signed-off-by: Joey Vagedes <joey.vagedes@gmail.com >
2024-09-02 23:20:35 +00:00
Jiaxin Wu
7b3b39a2e4
SourceLevelDebugPkg/Library: Indicate SMM Debug Agent support or not
...
This patch is to use the Context to indicate SMM Debug Agent support
or not if InitFlag is DEBUG_AGENT_INIT_SMM. Context must point to a
BOOLEAN if it's not NULL.
Cc: Ray Ni <ray.ni@intel.com >
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com >
Reviewed-by: Ray Ni <ray.ni@Intel.com >
2023-12-26 07:18:26 +00:00
Rebecca Cran
457b4e42f7
SourceLevelDebugPkg: Update code to be more C11 compliant by using __func__
...
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
SourceLevelDebugPkg.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com >
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com >
Reviewed-by: Ard Biesheuvel <ardb@kernel.org >
Reviewed-by: Ray Ni <ray.ni@intel.com >
2023-04-10 14:19:57 +00:00
Yu Pu
16bd7aa076
SourceLevelDebugPkg: Remove UefiCpuLib from module INFs.
...
Because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib, remove the
dependency of UefiCpuLib.
Cc: Hao A Wu <hao.a.wu@intel.com >
Acked-by: Hao A Wu <hao.a.wu@intel.com >
Signed-off-by: Yu Pu <yu.pu@intel.com >
Reviewed-by: Ray Ni <ray.ni@intel.com >
2023-03-10 08:23:56 +00:00
Michael Kubacki
cf01fdd5d7
SourceLevelDebugPkg: Add package CI YAML file
...
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4091
Adds the package as a supported package to .pytool/CISettings.py
and adds a CI YAML for the package so it can be run in CI.
Cc: Hao A Wu <hao.a.wu@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com >
2022-10-06 02:09:28 +00:00
Michael Kubacki
d6d4a81f8a
SourceLevelDebugPkg: Fix spelling errors
...
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4091
Fixes spelling errors in the package so the SpellCheck CI plugin can
be enabled.
Cc: Hao A Wu <hao.a.wu@intel.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com >
2022-10-06 02:09:28 +00:00
Jason
7bc8b1d9f4
SourceLevelDebugPkg: Replace Opcode with the corresponding instructions.
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790
Replace Opcode with the corresponding instructions.
The code changes have been verified with CompareBuild.py tool, which
can be used to compare the results of two different EDK II builds to
determine if they generate the same binaries.
(tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild )
Signed-off-by: Jason Lou <yun.lou@intel.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
2022-03-01 01:45:47 +00:00
Michael Kubacki
c1e126b119
SourceLevelDebugPkg: Apply uncrustify changes
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737
Apply uncrustify changes to .c/.h files in the SourceLevelDebugPkg package
Cc: Andrew Fish <afish@apple.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
Reviewed-by: Ray Ni <ray.ni@intel.com >
2021-12-07 17:24:28 +00:00
Michael D Kinney
f9c9215b55
SourceLevelDebugPkg: Change OPTIONAL keyword usage style
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3760
Update all use of ', OPTIONAL' to ' OPTIONAL,' for function params.
Cc: Andrew Fish <afish@apple.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
Reviewed-by: Ray Ni <ray.ni@intel.com >
2021-12-07 17:24:28 +00:00
Michael D Kinney
586fda4800
SourceLevelDebugPkg: Change use of EFI_D_* to DEBUG_*
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3739
Update all use of EFI_D_* defines in DEBUG() macros to DEBUG_* defines.
Cc: Andrew Fish <afish@apple.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
2021-12-07 17:24:28 +00:00
Dandan Bi
42a492fb3e
SourceLevelDebugPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
MdeLibs.dsc.inc was added for some basic/default library
instances provided by MdePkg and RegisterFilterLibNull Library
was also added into it as the first version of MdeLibs.dsc.inc.
So update platform dsc to consume MdeLibs.dsc.inc for
RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
Cc: Hao A Wu <hao.a.wu@intel.com >
Signed-off-by: Dandan Bi <dandan.bi@intel.com >
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
Acked-by: Ard Biesheuvel <ardb@kernel.org >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
2021-03-31 05:47:10 +00:00
Kirkendall, Garrett
7da5f343bc
SourceLevelDebugPkg: SourceLevelDebugPkg.dsc add UefiCpuLib LibraryClass
...
In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib
in UefiCpuPkg, SourceLevelDebugPkg/SourceLevelDebugPkg.dsc needs
LibraryClass UefiCpuLib.
LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need
UefiCpuLib LibraryClass. Likely most "real" platforms will be using
BaseX2XApicLib instance which already required UefiCpuLib.
Cc: Hao A Wu <hao.a.wu@intel.com >
Signed-off-by: Garrett Kirkendall <garrett.kirkendall@amd.com >
Message-Id: <20200622131825.1352-3-Garrett.Kirkendall@amd.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
2020-07-07 23:25:16 +00:00
Antoine Coeur
6b81166fff
SourceLevelDebugPkg: Fix few typos
...
Correctly write 'definitions' in comments and documentation.
Cc: Hao A Wu <hao.a.wu@intel.com >
Signed-off-by: Antoine Coeur <coeur@gmx.fr >
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com >
Message-Id: <20200207010831.9046-74-philmd@redhat.com >
2020-02-10 22:30:07 +00:00
Antoine Coeur
1825c24fd8
SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos
...
Fix various typos in comments and documentation.
Cc: Hao A Wu <hao.a.wu@intel.com >
Signed-off-by: Antoine Coeur <coeur@gmx.fr >
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com >
Message-Id: <20200207010831.9046-73-philmd@redhat.com >
2020-02-10 22:30:07 +00:00
Antoine Coeur
a302263ebb
SourceLevelDebugPkg/DebugAgent: Fix various typos
...
Fix various typos in documentation, comments and debug strings.
Cc: Hao A Wu <hao.a.wu@intel.com >
Signed-off-by: Antoine Coeur <coeur@gmx.fr >
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com >
Message-Id: <20200207010831.9046-72-philmd@redhat.com >
2020-02-10 22:30:07 +00:00
Zeng, Star
4053587347
SourceLevelDebugPkg DebugCommLibUsb3: Address NULL ptr dereference case
...
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2051
Original code GetConfigTable for AddrPtr first, if failed,
InstalConfigTable with allocated AddrPtr. So the AddrPtr
should not be NULL and the NULL pointer dereference case
should be false positive. This patch is just to address
the case raised from static analysis.
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
2019-08-12 09:46:47 +08:00
Bret Barkelew
34857c2ff9
SourceLevelDebugPkg: Add missing instances for build only
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1903
Add the missing instances to the [Components] of dsc file
for build only.
Cc: Hao A Wu <hao.a.wu@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Cc: Sean Brogan <sean.brogan@microsoft.com >
Cc: Michael Turner <Michael.Turner@microsoft.com >
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com >
Cc: Leif Lindholm <leif.lindholm@linaro.org >
Signed-off-by: Zhichao gao <zhichao.gao@intel.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
2019-06-17 09:19:00 +08:00
Michael D Kinney
85f7e11021
SourceLevelDebugPkg: Replace BSD License with BSD+Patent License
...
https://bugzilla.tianocore.org/show_bug.cgi?id=1373
Replace BSD 2-Clause License with BSD+Patent License. This change is
based on the following emails:
https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
RFCs with detailed process for the license change:
V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html
V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html
V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com >
Reviewed-by: Hao Wu <hao.a.wu@intel.com >
2019-04-09 10:58:27 -07:00
Zhang, Shenglei
7ed72121b7
SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF
...
AsmFuncs.S is removed at c7d22535f7 .
And also it should be removed in SecPeiDebugAgentLib.inf and
SmmDebugAgentLib.inf.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com >
Reviewed-by: Hao Wu <hao.a.wu@intel.com >
2019-04-03 15:24:22 +08:00
Shenglei Zhang
fb5c9ed843
SourceLevelDebugPkg/PeCoffExtraActionLibDebug: Remove .S files
...
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Hao Wu <hao.a.wu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com >
Reviewed-by: Hao Wu <hao.a.wu@intel.com >
2019-04-03 13:27:44 +08:00
Shenglei Zhang
c7d22535f7
SourceLevelDebugPkg/DebugAgentCommon: Remove .S files
...
.nasm file has been added for X86 arch. .S assembly code
is not required any more.
https://bugzilla.tianocore.org/show_bug.cgi?id=1594
Cc: Hao Wu <hao.a.wu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
2019-04-03 13:27:44 +08:00
Hao Wu
3eacb4751a
SourceLevelDebugPkg/Readme.txt: Update UDK Debugger Tool & manual URL
...
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1289
The commit updates the link to get access to the Intel(R) UDK Debugger
Tool and its detailed user manual.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com >
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com >
2018-11-08 12:00:34 +08:00