You've already forked edk2-upstream
mirror of
https://github.com/Dasharo/edk2-upstream.git
synced 2026-03-06 15:03:57 -08:00
8472271dae
Replace traditional `#ifndef`/`#define`/`#endif` include guards with
`#pragma` once.
`#pragma once` is a widely supported preprocessor directive that
prevents header files from being included multiple times. It is
supported by all toolchains used to build edk2: GCC, Clang/LLVM, and
MSVC.
Compared to macro-based include guards, `#pragma once`:
- Eliminates the risk of macro name collisions or copy/paste errors
where two headers inadvertently use the same guard macro.
- Eliminate inconsistency in the way include guard macros are named
(e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.).
- Reduces boilerplate (three lines replaced by one).
- Avoids polluting the macro namespace with guard symbols.
- Can improve build times as the preprocessor can skip re-opening the
file entirely, rather than re-reading it to find the matching
`#endif` ("multiple-include optimization").
- Note that some compilers may already optimize traditional include
guards, by recognzining the idiomatic pattern.
This change is made acknowledging that overall portability of the
code will technically be reduced, as `#pragma once` is not part of the
C/C++ standards.
However, this is considered acceptable given:
1. edk2 already defines a subset of supported compilers in
BaseTools/Conf/tools_def.template, all of which have supported
`#pragma once` for over two decades.
2. There have been concerns raised to the project about inconsistent
include guard naming and potential macro collisions.
Approximate compiler support dates:
- MSVC: Supported since Visual C++ 4.2 (1996)
- GCC: Supported since 3.4 (2004)
(http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html)
- Clang (LLVM based): Since initial release in 2007
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
44 lines
1.2 KiB
C
44 lines
1.2 KiB
C
/** @file
|
|
Library providing 'acpiview' functionality to display and
|
|
validate installed ACPI tables.
|
|
|
|
Copyright (c) 2016 - 2020, ARM Limited. All rights reserved.<BR>
|
|
SPDX-License-Identifier: BSD-2-Clause-Patent
|
|
**/
|
|
|
|
#pragma once
|
|
|
|
/**
|
|
Dump a buffer to a file. Print error message if a file cannot be created.
|
|
|
|
@param[in] FileName The filename that shall be created to contain the buffer.
|
|
@param[in] Buffer Pointer to buffer that shall be dumped.
|
|
@param[in] BufferSize The size of buffer to be dumped in bytes.
|
|
|
|
@return The number of bytes that were written
|
|
**/
|
|
UINTN
|
|
EFIAPI
|
|
ShellDumpBufferToFile (
|
|
IN CONST CHAR16 *FileNameBuffer,
|
|
IN CONST VOID *Buffer,
|
|
IN CONST UINTN BufferSize
|
|
);
|
|
|
|
/**
|
|
Display and validate ACPI tables.
|
|
|
|
@param[in] ImageHandle Handle to the Image (NULL if internal).
|
|
@param[in] SystemTable Pointer to the System Table (NULL if internal).
|
|
|
|
@retval SHELL_INVALID_PARAMETER The command line invocation could not be parsed.
|
|
@retval SHELL_NOT_FOUND The command failed.
|
|
@retval SHELL_SUCCESS The command was successful.
|
|
**/
|
|
SHELL_STATUS
|
|
EFIAPI
|
|
ShellCommandRunAcpiView (
|
|
IN EFI_HANDLE ImageHandle,
|
|
IN EFI_SYSTEM_TABLE *SystemTable
|
|
);
|