Sathya Ravichandran and mergify[bot]
98d1f8a6fd
BaseTools: Remove DXE_SAL_DRIVER
...
The DXE_SAL_DRIVER module type was introduced to support
Itanium (IPF) platforms. Since support for Itanium processors has been
dropped, the instances of DXE_SAL_DRIVER have been removed.
Ref: [3cb0a311cb ]
Cc: Sachin Ganesh <sachinganesh@ami.com >
Signed-off-by: Sathya Ravichandran <sathyar@ami.com >
2025-10-30 10:00:32 +00:00
Pierre Gondois and Liming Gao
fa2c27514c
BaseTools: GenFds: Remove unnecessary code
...
Running the vulture tool on the GenFds folder gave the following
report. Remove the unnecessary code.
- GenFds/Fd.py:146:
unused method 'GenFlashMap' (60% confidence)
- GenFds/FdfParser.py:1539:
unused attribute 'BaseAddressPcd' (60% confidence)
- GenFds/FdfParser.py:1556:
unused attribute 'SizePcd' (60% confidence)
- GenFds/FdfParser.py:2394:
unused attribute 'CurrentLineNum' (60% confidence)
- GenFds/FdfParser.py:2395:
unused attribute 'CurrentLineContent' (60% confidence)
- GenFds/FdfParser.py:2653:
unused attribute 'CurrentLineNum' (60% confidence)
- GenFds/FdfParser.py:2654:
unused attribute 'CurrentLineContent' (60% confidence)
- GenFds/FdfParser.py:3229:
unused attribute 'CreateFile' (60% confidence)
- GenFds/FfsFileStatement.py:36:
unused attribute 'CurrentLineNum' (60% confidence)
- GenFds/FfsFileStatement.py:37:
unused attribute 'CurrentLineContent' (60% confidence)
- GenFds/FfsInfStatement.py:68:
unused attribute 'CurrentLineNum' (60% confidence)
- GenFds/FfsInfStatement.py:69:
unused attribute 'CurrentLineContent' (60% confidence)
- GenFds/GenFds.py:68:
unused attribute 'LibDir' (60% confidence)
- GenFds/GenFds.py:557:
unused method 'GetFvBlockSize' (60% confidence)
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com >
2025-07-01 09:51:38 +08:00
Pierre Gondois and Liming Gao
f54fe78d9a
BaseTools: Remove unused import
...
Running the vulture tool gave the following report.
Remove the unused import.
- BPDG/BPDG.py:21:
unused import 'encodings' (90% confidence)
- build/build.py:61:
unused import 'Manager' (90% confidence)
- Ecc/CParser4/CLexer.py:4:
unused import 'TextIO' (90% confidence)
- Ecc/CParser4/CParser.py:5:
unused import 'TextIO' (90% confidence)
- Eot/CParser4/CLexer.py:4:
unused import 'TextIO' (90% confidence)
- Eot/CParser4/CParser.py:5:
unused import 'TextIO' (90% confidence)
- Eot/EotMain.py:28:
unused import 'ConvertGuid' (90% confidence)
- GenFds/FdfParser.py:16:
unused import 'hexdigits' (90% confidence)
- Table/TableEotReport.py:16:
unused import 'EotToolError' (90% confidence)
- UPT/Library/CommentGenerating.py:19:
unused import 'USAGE_ITEM_NOTIFY' (90% confidence)
- UPT/Library/ParserValidate.py:18:
unused import 'COMPONENT_TYPE_LIST' (90% confidence)
- UPT/Library/UniClassObject.py:25:
unused import 'CheckUTF16FileHeader' (90% confidence)
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com >
2025-07-01 09:51:38 +08:00
Joey Vagedes via groups.io and mergify[bot]
9f0061a03b
BaseTools: Resolve regex syntax warnings
...
Switches regex patterns to raw text to resolve python 3.12 syntax
warnings in regards to invalid escape sequences, as is suggested by the
re (regex) module in python.
Cc: Rebecca Cran <rebecca@bsdio.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Bob Feng <bob.c.feng@intel.com >
Cc: Yuwei Chen <yuwei.chen@intel.com >
Signed-off-by: Joey Vagedes <joey.vagedes@gmail.com >
Reviewed-by: Rebecca Cran <rebecca@bsdio.com >
2023-12-21 00:33:31 +00:00
Konstantin Aladyshev and mergify[bot]
d23eb3aa99
BaseTools/GenFds: Correct file type set for the PIC section
...
Corrently the set of file types for the PIC section contains two
duplicate values.
Replace the duplicate value with the correct one to fix the issue.
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com >
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
2022-10-19 06:32:07 +00:00
Konstantin Aladyshev and mergify[bot]
225810a182
BaseTools: Add support for SUBTYPE_GUID section generation
...
EFI_SECTION_FREEFORM_SUBTYPE_GUID is a leaf section type that contains
a single EFI_GUID in the header to describe the raw data.
Currently is is not possible to generate such section.
This patch adds initial support for the generation of such sections.
The added syntax for this type of section corresponds to EDKII
"[FV] section" documentation from the FDF Specification:
```
SECTION SUBTYPE_GUID <GUID> = <File>
```
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
2022-10-19 06:32:07 +00:00
Michael D Kinney and mergify[bot]
3c13938079
BaseTools/Source/Python: Remove CPU architecture assumptions
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3308
The EDK II Build Specifications do not restrict the set of
CPU architectures that can be supported. Remove places in
the EDK II that assume a fixed set of CPU architectures.
Remove build breaks in the following tools when a check against
a fixed set of CPU architectures is made.
* Build
* GenFds
* TargetTool
Cc: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Yuwei Chen <yuwei.chen@intel.com >
Cc: Andrew Fish <afish@apple.com >
Cc: Abner Chang <abner.chang@hpe.com >
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com >
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
2021-04-15 15:58:44 +00:00
Yuwei Chen and mergify[bot]
d35773d5c0
BaseTools: Add Guid name support in GenFfs.
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2762
The Fv Section in the FDF files use hard coding Guid values
which is inconvenient to manage. This patch adds Guid name
support in GenFfs to solve this problem.
Signed-off-by: Yuwei Chen <yuwei.chen@intel.com >
Reviewed-by: Bob Feng<bob.c.feng@intel.com >
2020-07-17 05:25:41 +00:00
Jiewen Yao and Liming Gao
a79841a024
BaseTools: Add HOST_APPLICATION module type.
...
It can be used to indicate a module can be build to run
as OS application and run in OS environment.
Cc: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Cc: Jiewen Yao <jiewen.yao@intel.com >
Signed-off-by: Xiaoyu Lu <xiaoyux.lu@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
2019-07-12 21:06:57 +08:00
Fan, ZhijuX and Feng, Bob C
04797875d1
BaseTools:Make BaseTools support new rules to generate RAW FFS FILE
...
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1765
If RAW FFS File Rule has no section for its data.For RAW FFS File,
directly call GenFfs tool to generate FFS file.
Ffs Rule:
[Rule.Common.USER_DEFINED.MicroCode]
FILE RAW = $(NAMED_GUID) {
$(INF_OUTPUT)/$(MODULE_NAME).bin
}
[Rule.Common.USER_DEFINED.LOGO]
FILE RAW = $(NAMED_GUID) {
|.bmp
}
As shown in the rule above,if SectionType and FileType not defined,
FFS files are generated directly, and no other type of file is
generated.
The patch is to make the BaseTools support these two rules
Cc: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
2019-06-10 19:48:50 +08:00
Fan, ZhijuX and Feng, Bob C
6b74ccf0f8
BaseTools:Enables FFS to support the GUID value format
...
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1768
Per FDF spec, FFS Rule can specify the hard code FILE Guid value.
But,BaseTools reports the build failure.It should be fixed.
This patch is going to fix that issue.
Cc: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
2019-05-10 17:07:07 +08:00
Michael D Kinney
2e351cbe8e
BaseTools: Replace BSD License with BSD+Patent License
...
https://bugzilla.tianocore.org/show_bug.cgi?id=1373
Replace BSD 2-Clause License with BSD+Patent License. This change is
based on the following emails:
https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
RFCs with detailed process for the license change:
V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html
V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html
V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
2019-04-09 09:10:20 -07:00
Antoine Coeur and Liming Gao
fb0b35e05f
BaseTools: Various typo
...
Various typo in BaseTools.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Coeur <coeur@gmx.fr >
Reviewed-by: Liming Gao <liming.gao@intel.com >
2019-02-14 10:02:28 +08:00
Feng, Bob C
d943b0c339
BaseTools: Handle the bytes and str difference
...
Deal with bytes and str is different, remove the unicode(),
correct open file parameter.
Using utcfromtimestamp instead of fromtimestamp.
Cc: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com >
Tested-by: Laszlo Ersek <lersek@redhat.com >
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org >
Reviewed-by: Liming Gao <liming.gao@intel.com >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
2019-02-01 11:09:24 +08:00
Yunhua Feng and Feng, Bob C
af881abc65
BaseTools: replace long by int
...
replace long by int
Because the long() was not exist in Python3
Cc: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com >
Tested-by: Laszlo Ersek <lersek@redhat.com >
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org >
Reviewed-by: Liming Gao <liming.gao@intel.com >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
2019-02-01 11:09:18 +08:00
Feng, Bob C
39879ef267
BaseTools: Remove unused logic for IPF
...
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1350
Remove IPF support from BaseTools C code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Cc: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
2019-01-14 09:34:41 +08:00
Carsey, Jaben and BobCF
938cf4c33a
BaseTools: fix imports
...
1 - Some of these imports are cascaded from another file. Import them locally.
2 - Some of these imports are not used. Remove them.
3 - Some of these were missing the namespace used to import them.
These changes facilitate optimization of BaseTools:
https://bugzilla.tianocore.org/show_bug.cgi?id=42
Cc: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
2019-01-10 22:01:11 +08:00
Ard Biesheuvel
8ef653aa5a
BaseTools/GenFds: permit stripped MM_CORE_STANDALONE binaries
...
The standalone MM core is executed in place, and resides in a
separate execution context which may be space constrained.
Since code and data may be mapped with different attributes for
security reasons, the PE/COFF binary could have a section
alignment of 4 KB.
This means that any relocation data is not only useless, but it
will also take up 4 KB of valuable space.
So add support for the RELOCS_STRIPPED attribute on FFS files of
this type, so that we can get rid of the .reloc section altogether.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Bob Feng <bob.c.feng@intel.com >
2019-01-04 09:42:17 +01:00
Jaben Carsey and BobCF
bc39c5cbea
BaseTools: create and use a standard shared variable for '*'
...
add a variable for the string '*' and then use it instead of lots of '*'
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by : Bob Feng <bob.c.feng@intel.com >
2018-12-06 17:11:24 +08:00
Feng, Bob C and Liming Gao
3d3416e892
BaseTools: Fix the problem using FILE_GUID override in .dsc
...
https://bugzilla.tianocore.org/show_bug.cgi?id=1330
This patch is going to fix the problem using FILE_GUID override in .dsc.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: BobCF <bob.c.feng@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Cc: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
2018-11-20 08:10:28 +08:00
Tomas Pilar and Yonghong Zhu
5b9639e697
BaseTools: Fix merge in FDF parser for OptionROM override
...
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Tomas Pilar <tpilar@solarflare.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-11-01 10:23:23 +08:00
Tomas Pilar and Yonghong Zhu
f157f97301
BaseTools: Allow multiple PciDeviceId in Fdf OptionROM override
...
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Tomas Pilar <tpilar@solarflare.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-10-26 20:47:54 +08:00
Carsey, Jaben and Yonghong Zhu
ea98a8254a
BaseTools/GenFds: create and use new variable in FdfParser
...
replace lots of '}' and "}" with a shared new consistent variable.
Cc: Bob Feng <bob.c.feng@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-10-25 20:17:38 +08:00
Carsey, Jaben and Yonghong Zhu
ca957eb5cd
BaseTools/GenFds: refactor FdfParser warnings
...
make functions for common error messages
refactor to use these functions
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-10-25 20:17:14 +08:00
Jaben Carsey and Yonghong Zhu
5a6a268d51
BaseTools/GenFds: remove MacroDict parameter
...
The MacroDict parameter goes around in circles through 4 functions without use.
1. GetSectionData calls into GetLeafSection, otherwise doesn?t use MacroDict
2. GetLeafSection calls into GetFileStatement, otherwise doesn?t use MacroDict
3. GetFileStatement calls into GetFilePart, otherwise doesn?t use MacroDict
4. GetFilePart calls into GetSectionData, otherwise doesn?t use MacroDict
Go to 1 and repeat forever.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com >
2018-10-25 20:16:31 +08:00