Michael D Kinney
072ab3846c
Revert "SecurityPkg: CodeQL Fixes."
...
This reverts commit ba6a8eb045https://github.com/tianocore/edk2/pull/11307 introduced a
logic change that caused regressions in FV verification on
some platforms. This PR is being reverted to restore the prior
logic.
The Code QL fixes in https://github.com/tianocore/edk2/pull/11307
can be resubmitted without the logic change along with one
commit for each type of Code QL issue being addressed.
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com >
2025-08-12 03:50:30 +00:00
Michael Kubacki
ba6a8eb045
SecurityPkg: CodeQL Fixes.
...
Makes changes to comply with alerts raised by CodeQL.
Most of the issues here fall into the following two categories:
1. Potential use of uninitialized pointer.
2. Inconsistent integer width in comparison.
Co-authored-by: Taylor Beebe <31827475+TaylorBeebe@users.noreply.github.com >
Co-authored-by: kenlautner <85201046+kenlautner@users.noreply.github.com >
Co-authored-by: Bret Barkelew <bret@corthon.com >
Signed-off-by: Doug Flick <dougflick@microsoft.com >
2025-07-24 01:58:06 +00:00
Rebecca Cran
194cdc1700
SecurityPkg: remove unused EfiSig variable in SecureBootFetchData
...
The `EfiSig` variable in SecureBootFetchData is unused, so remove it.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com >
2024-12-04 11:05:10 +00:00
Rebecca Cran
dfab971e91
SecurityPkg: Improve formatting of msg when GetVariable fails
...
Improve the formatting of the error message when GetVariable
fails: start the message with an upper-case character, and close the
quotes around the variable name.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com >
2024-12-04 09:30:53 +00:00
Rebecca Cran
dd0b33e3e5
SecurityPkg: Update code to be more C11 compliant by using __func__
...
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
SecurityPkg.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com >
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com >
Reviewed-by: Ard Biesheuvel <ardb@kernel.org >
2023-04-10 14:19:57 +00:00
Kun Qin
fe73e9cd89
SecurityPkg: SecureBootVariableProvisionLib: Updated implementation
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910
This change is in pair with the previous SecureBootVariableLib, which
removes the explicit invocation of `CreateTimeBasedPayload` and used new
interface `EnrollFromInput` instead.
The original `SecureBootFetchData` is also moved to this library and
incorporated with the newly defined `SecureBootCreateDataFromInput` to
keep the original code flow.
Cc: Jiewen Yao <jiewen.yao@intel.com >
Cc: Jian J Wang <jian.j.wang@intel.com >
Cc: Min Xu <min.m.xu@intel.com >
Signed-off-by: Kun Qin <kun.qin@microsoft.com >
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com >
Acked-by: Michael Kubacki <michael.kubacki@microsoft.com >
2022-07-07 01:07:00 +00:00
Michael Kubacki
c411b485b6
SecurityPkg: Apply uncrustify changes
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737
Apply uncrustify changes to .c/.h files in the SecurityPkg package
Cc: Andrew Fish <afish@apple.com >
Cc: Leif Lindholm <leif@nuviainc.com >
Cc: Michael D Kinney <michael.d.kinney@intel.com >
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com >
Reviewed-by: Jian J Wang <jian.j.wang@intel.com >
2021-12-07 17:24:28 +00:00
Grzegorz Bernacki
9732659698
SecurityPkg: Create library for enrolling Secure Boot variables.
...
This commits add library, which consist functions to
enrolll Secure Boot keys and initialize Secure Boot
default variables. Some of the functions was moved
from SecureBootConfigImpl.c file.
Signed-off-by: Grzegorz Bernacki <gjb@semihalf.com >
Reviewed-by: Sunny Wang <sunny.wang@arm.com >
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com >
2021-08-03 07:26:41 +00:00
